maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

use data-test-subj click create button in a less fragile manner

Browse source
This commit is contained in:
Matthew Bargar 2016-01-25 17:09:15 -05:00
parent af9c3dd8ce
commit d262deaba2
2 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/plugins/kibana/public/settings/sections/indices/_create.html
View file

@ -167,6 +167,7 @@
</div> </div>
<button <button
data-test-subj="submitCreateIndexPatternFromExistingForm"
ng-disabled="form.$invalid || index.fetchFieldsError" ng-disabled="form.$invalid || index.fetchFieldsError"
ng-class="index.fetchFieldsError ? 'btn-default' : 'btn-success'" ng-class="index.fetchFieldsError ? 'btn-default' : 'btn-success'"
type="submit" type="submit"

8
test/support/pages/settings_page.js
View file

@ -130,13 +130,11 @@ define(function (require) {
}, },
getCreateButton: function () { getCreateButton: function () {
return this.remote.setFindTimeout(defaultTimeout) return common.findTestSubject('submitCreateIndexPatternFromExistingForm');
.findByCssSelector('.btn');
}, },
clickCreateButton: function () { clickCreateButton: function () {
return this.remote.setFindTimeout(defaultTimeout) return common.findTestSubject('submitCreateIndexPatternFromExistingForm').click();
.findByCssSelector('.btn').click();
}, },
clickDefaultIndexButton: function () { clickDefaultIndexButton: function () {
@ -309,7 +307,7 @@ define(function (require) {
return common.tryForTime(defaultTimeout, function () { return common.tryForTime(defaultTimeout, function () {
return self.selectTimeFieldOption('@timestamp') return self.selectTimeFieldOption('@timestamp')
.then(function () { .then(function () {
return self.getCreateButton().click(); return self.clickCreateButton();
}); });
}) })
.then(function () { .then(function () {