CIT for circle processor (renewed PR) (#102277)

* Added CITs for Circle processor.

* Fixed issue with form function using int instead of string.

* Added changed per nits.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
John Dorlus 2021-06-16 12:07:50 -04:00 committed by GitHub
parent 973d057846
commit d2e81ee785
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 118 additions and 0 deletions

View file

@ -0,0 +1,114 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/
import { act } from 'react-dom/test-utils';
import { setup, SetupResult, getProcessorValue } from './processor.helpers';
const CIRCLE_TYPE = 'circle';
describe('Processor: Circle', () => {
let onUpdate: jest.Mock;
let testBed: SetupResult;
beforeAll(() => {
jest.useFakeTimers();
});
afterAll(() => {
jest.useRealTimers();
});
beforeEach(async () => {
onUpdate = jest.fn();
await act(async () => {
testBed = await setup({
value: {
processors: [],
},
onFlyoutOpen: jest.fn(),
onUpdate,
});
});
testBed.component.update();
const {
actions: { addProcessor, addProcessorType },
} = testBed;
// Open the processor flyout
addProcessor();
// Add type (the other fields are not visible until a type is selected)
await addProcessorType(CIRCLE_TYPE);
});
test('prevents form submission if required fields are not provided', async () => {
const {
actions: { saveNewProcessor },
form,
} = testBed;
// Click submit button with only the type defined
await saveNewProcessor();
// Expect form error as "field" and "shape_type" are required parameters
expect(form.getErrorsMessages()).toEqual([
'A field value is required.',
'A shape type value is required.',
]);
});
test('saves with required parameter values', async () => {
const {
actions: { saveNewProcessor },
form,
} = testBed;
// Add "field" value (required)
form.setInputValue('fieldNameField.input', 'field_1');
// Save the field
form.setSelectValue('shapeSelectorField', 'shape');
// Set the error distance
form.setInputValue('errorDistanceField.input', '10');
await saveNewProcessor();
const processors = getProcessorValue(onUpdate, CIRCLE_TYPE);
expect(processors[0].circle).toEqual({
field: 'field_1',
error_distance: 10,
shape_type: 'shape',
});
});
test('allows optional parameters to be set', async () => {
const {
actions: { saveNewProcessor },
form,
} = testBed;
// Add "field" value (required)
form.setInputValue('fieldNameField.input', 'field_1');
// Select the shape
form.setSelectValue('shapeSelectorField', 'geo_shape');
// Add "target_field" value
form.setInputValue('targetField.input', 'target_field');
form.setInputValue('errorDistanceField.input', '10');
// Save the field with new changes
await saveNewProcessor();
const processors = getProcessorValue(onUpdate, CIRCLE_TYPE);
expect(processors[0].circle).toEqual({
field: 'field_1',
error_distance: 10,
shape_type: 'geo_shape',
target_field: 'target_field',
});
});
});

View file

@ -151,6 +151,8 @@ type TestSubject =
| 'keepOriginalField.input'
| 'removeIfSuccessfulField.input'
| 'targetFieldsField.input'
| 'shapeSelectorField'
| 'errorDistanceField.input'
| 'separatorValueField.input'
| 'quoteValueField.input'
| 'emptyValueField.input'

View file

@ -97,6 +97,7 @@ export const Circle: FunctionComponent = () => {
/>
<UseField
data-test-subj="errorDistanceField"
config={fieldsConfig.error_distance}
component={NumericField}
path="fields.error_distance"
@ -105,6 +106,7 @@ export const Circle: FunctionComponent = () => {
<UseField
componentProps={{
euiFieldProps: {
'data-test-subj': 'shapeSelectorField',
options: [
{
value: 'shape',