maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Reporting] Remove unused settings for 8.0 (#114216)

Browse source 
* [Reporting] Remove unused settings for 8.0

* add helpful version comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Tim Sullivan 2021-10-12 06:35:55 -07:00 committed by GitHub
parent 9e42b32015
commit d37cf3045b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
x-pack/plugins/reporting/server/config/index.ts
View file

@ -17,13 +17,9 @@ export const config: PluginConfigDescriptor<ReportingConfigType> = {
exposeToBrowser: { poll: true, roles: true },
schema: ConfigSchema,
deprecations: ({ unused }) => [
unused('capture.browser.chromium.maxScreenshotDimension'),
unused('capture.concurrency'),
unused('capture.settleTime'),
unused('capture.timeout'),
unused('poll.jobCompletionNotifier.intervalErrorMultiplier'),
unused('poll.jobsRefresh.intervalErrorMultiplier'),
unused('kibanaApp'),
unused('capture.browser.chromium.maxScreenshotDimension'), // unused since 7.8
unused('poll.jobCompletionNotifier.intervalErrorMultiplier'), // unused since 7.10
unused('poll.jobsRefresh.intervalErrorMultiplier'), // unused since 7.10
(settings, fromPath, addDeprecation) => {
const reporting = get(settings, fromPath);
if (reporting?.index) {

4
x-pack/plugins/reporting/server/config/schema.ts
View file

@ -160,11 +160,11 @@ const RolesSchema = schema.object({
const PollSchema = schema.object({
jobCompletionNotifier: schema.object({
interval: schema.number({ defaultValue: 10000 }),
intervalErrorMultiplier: schema.number({ defaultValue: 5 }), // unused
intervalErrorMultiplier: schema.number({ defaultValue: 5 }), // deprecated as unused since 7.10
}),
jobsRefresh: schema.object({
interval: schema.number({ defaultValue: 5000 }),
intervalErrorMultiplier: schema.number({ defaultValue: 5 }), // unused
intervalErrorMultiplier: schema.number({ defaultValue: 5 }), // deprecated as unused since 7.10
}),
});