diff --git a/src/plugins/vis_type_timeseries/public/application/components/vis_editor.tsx b/src/plugins/vis_type_timeseries/public/application/components/vis_editor.tsx index 152ae43bebd6..5e4ff436ff1e 100644 --- a/src/plugins/vis_type_timeseries/public/application/components/vis_editor.tsx +++ b/src/plugins/vis_type_timeseries/public/application/components/vis_editor.tsx @@ -12,9 +12,8 @@ import { share } from 'rxjs/operators'; import { isEqual, isEmpty, debounce } from 'lodash'; import { EventEmitter } from 'events'; import type { IUiSettingsClient } from 'kibana/public'; -import { +import type { Vis, - PersistedState, VisualizeEmbeddableContract, } from '../../../../../plugins/visualizations/public'; import { KibanaContextProvider } from '../../../../../plugins/kibana_react/public'; @@ -31,8 +30,9 @@ import { TIME_RANGE_DATA_MODES, TIME_RANGE_MODE_KEY } from '../../../common/enum import { VisPicker } from './vis_picker'; import { fetchFields, VisFields } from '../lib/fetch_fields'; import { getDataStart, getCoreStart } from '../../services'; -import { TimeseriesVisParams } from '../../types'; +import type { TimeseriesVisParams } from '../../types'; import { UseIndexPatternModeCallout } from './use_index_patter_mode_callout'; +import type { EditorRenderProps } from '../../../../visualize/public'; const VIS_STATE_DEBOUNCE_DELAY = 200; const APP_NAME = 'VisEditor'; @@ -42,7 +42,9 @@ export interface TimeseriesEditorProps { embeddableHandler: VisualizeEmbeddableContract; eventEmitter: EventEmitter; timeRange: TimeRange; - uiState: PersistedState; + filters: EditorRenderProps['filters']; + query: EditorRenderProps['query']; + uiState: EditorRenderProps['uiState']; vis: Vis; } @@ -189,6 +191,8 @@ export class VisEditor extends Component , this.el diff --git a/src/plugins/vis_type_timeseries/public/metrics_type.ts b/src/plugins/vis_type_timeseries/public/metrics_type.ts index b68812b9828e..855d56169ef3 100644 --- a/src/plugins/vis_type_timeseries/public/metrics_type.ts +++ b/src/plugins/vis_type_timeseries/public/metrics_type.ts @@ -105,8 +105,8 @@ export const metricsVisDefinition: VisTypeDefinition< editor: TSVB_EDITOR_NAME, }, options: { - showQueryBar: false, - showFilterBar: false, + showQueryBar: true, + showFilterBar: true, showIndexSelection: false, }, toExpressionAst, @@ -117,6 +117,7 @@ export const metricsVisDefinition: VisTypeDefinition< return []; }, inspectorAdapters: {}, + requiresSearch: true, getUsedIndexPattern: async (params: VisParams) => { const { indexPatterns } = getDataStart(); const indexPatternValue = params.index_pattern; diff --git a/src/plugins/visualizations/public/embeddable/visualize_embeddable.ts b/src/plugins/visualizations/public/embeddable/visualize_embeddable.ts index 78230a896196..637334067b51 100644 --- a/src/plugins/visualizations/public/embeddable/visualize_embeddable.ts +++ b/src/plugins/visualizations/public/embeddable/visualize_embeddable.ts @@ -340,14 +340,6 @@ export class VisualizeEmbeddable data: { timeFieldName: this.vis.data.indexPattern?.timeFieldName!, ...event.data }, }; } - // do not trigger the filter click event if the filter bar is not visible - if ( - triggerId === VIS_EVENT_TO_TRIGGER.filter && - !this.input.id && - !this.vis.type.options.showFilterBar - ) { - return; - } getUiActions().getTrigger(triggerId).exec(context); }