maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Logs App] Fix logs permissions for alert management (#81199)

Browse source 
* Mimics metrics permissions for alert mgmt in logs feature

* Updates logs security functional tests

Alert management permissions were added for read and all logs users in this PR, so both of these users now have "Stack Management" appear in the nav.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Jason Rhodes 2020-10-29 14:04:37 -04:00 committed by GitHub
parent 052f8277fe
commit d84ac13a4a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
x-pack/plugins/infra/server/features.ts
View file

@ -68,6 +68,9 @@ export const LOGS_FEATURE = {
category: DEFAULT_APP_CATEGORIES.observability,
app: ['infra', 'logs', 'kibana'],
catalogue: ['infralogging', 'logs'],
management: {
insightsAndAlerting: ['triggersActions'],
},
alerting: [LOG_DOCUMENT_COUNT_ALERT_TYPE_ID],
privileges: {
all: {
@ -81,6 +84,9 @@ export const LOGS_FEATURE = {
alerting: {
all: [LOG_DOCUMENT_COUNT_ALERT_TYPE_ID],
},
management: {
insightsAndAlerting: ['triggersActions'],
},
ui: ['show', 'configureSource', 'save'],
},
read: {
@ -90,6 +96,9 @@ export const LOGS_FEATURE = {
alerting: {
read: [LOG_DOCUMENT_COUNT_ALERT_TYPE_ID],
},
management: {
insightsAndAlerting: ['triggersActions'],
},
savedObject: {
all: [],
read: ['infrastructure-ui-source'],

4
x-pack/test/functional/apps/infra/feature_controls/logs_security.ts
View file

@ -58,7 +58,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
it('shows logs navlink', async () => {
const navLinks = (await appsMenu.readLinks()).map((link) => link.text);
expect(navLinks).to.eql(['Overview', 'Logs']);
expect(navLinks).to.eql(['Overview', 'Logs', 'Stack Management']);
});
describe('logs landing page without data', () => {
@ -121,7 +121,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
it('shows logs navlink', async () => {
const navLinks = (await appsMenu.readLinks()).map((link) => link.text);
expect(navLinks).to.eql(['Overview', 'Logs']);
expect(navLinks).to.eql(['Overview', 'Logs', 'Stack Management']);
});
describe('logs landing page without data', () => {