maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Blocks save event filter with a white space name (#101599)

Browse source
This commit is contained in:
David Sánchez 2021-06-09 14:20:43 +02:00 committed by GitHub
parent 7604fd7c80
commit d90285f718
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
x-pack/plugins/security_solution/public/management/pages/event_filters/view/components/form/index.test.tsx
View file

@ -111,6 +111,23 @@ describe('Event filter form', () => {
expect(store.getState()!.management!.eventFilters!.form!.hasNameError).toBeFalsy();
});
it('should change name with a white space still shows an error', async () => {
component = renderComponentWithdata();
const nameInput = component.getByPlaceholderText(NAME_PLACEHOLDER);
act(() => {
fireEvent.change(nameInput, {
target: {
value: ' ',
},
});
});
expect(store.getState()!.management!.eventFilters!.form!.entry!.name).toBe('');
expect(store.getState()!.management!.eventFilters!.form!.hasNameError).toBeTruthy();
});
it('should change comments', async () => {
component = renderComponentWithdata();

5
x-pack/plugins/security_solution/public/management/pages/event_filters/view/components/form/index.tsx
View file

@ -91,11 +91,12 @@ export const EventFiltersForm: React.FC<EventFiltersFormProps> = memo(
const handleOnChangeName = useCallback(
(e: React.ChangeEvent<HTMLInputElement>) => {
if (!exception) return;
const name = e.target.value.toString().trim();
dispatch({
type: 'eventFiltersChangeForm',
payload: {
entry: { ...exception, name: e.target.value.toString() },
hasNameError: !e.target.value,
entry: { ...exception, name },
hasNameError: !name,
},
});
},