maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Stack Monitoring] add test subject to tab (#114319)

Browse source 
* pass test subject to advanced link and change name in angular version to be generic

* change name in functional test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Sandra G 2021-10-11 16:18:29 -04:00 committed by GitHub
parent 328da6f720
commit de42e5329f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
x-pack/plugins/monitoring/public/application/pages/elasticsearch/item_template.tsx
View file

@ -25,6 +25,7 @@ export const ItemTemplate: React.FC<ItemTemplateProps> = (props) => {
},
{
id: 'advanced',
testSubj: 'esItemDetailAdvancedLink',
label: i18n.translate('xpack.monitoring.esItemNavigation.advancedLinkText', {
defaultMessage: 'Advanced',
}),

2
x-pack/plugins/monitoring/public/directives/main/index.html
View file

@ -103,7 +103,7 @@
</a>
<a
ng-if="monitoringMain.instance && (monitoringMain.name === 'nodes' || monitoringMain.name === 'indices')"
data-test-subj="esNodeDetailAdvancedLink"
data-test-subj="esItemDetailAdvancedLink"
kbn-href="#/elasticsearch/{{ monitoringMain.name }}/{{ monitoringMain.resolver }}/advanced"
class="euiTab"
ng-class="{'euiTab-isSelected': monitoringMain.page === 'advanced'}"

2
x-pack/test/functional/services/monitoring/elasticsearch_node_detail.js
View file

@ -21,7 +21,7 @@ export function MonitoringElasticsearchNodeDetailProvider({ getService }) {
return new (class ElasticsearchNodeDetail {
async clickAdvanced() {
return testSubjects.click('esNodeDetailAdvancedLink');
return testSubjects.click('esItemDetailAdvancedLink');
}
async getSummary() {