added tests to prove 96aef8f02e

src/kibana/components/filter_bar/lib/watchFilters.js

@@ -11,7 +11,7 @@ define(function (require) {
       $scope.$watch('state.filters', function (newFilters, oldFilters) {
         if (newFilters === oldFilters) return;
 
-        Promise.resolve()
+        return Promise.resolve()
         .then(handlers.update)
         .then(function () {
           if (!onlyDisabled(newFilters, oldFilters)) {

test/unit/specs/components/filter_bar/watchFilters.js

@@ -0,0 +1,91 @@
+/* global sinon */
+define(function (require) {
+  describe('Filter Bar watchFilters()', function () {
+    var sinon = require('test_utils/auto_release_sinon');
+    var _ = require('lodash');
+
+		var watchFilters;
+    var Promise;
+    var $scope;
+
+		beforeEach(module('kibana'));
+    beforeEach(inject(function (Private, $injector) {
+      Promise = $injector.get('Promise');
+      watchFilters = Private(require('components/filter_bar/lib/watchFilters'));
+      $scope = {
+        $watch: sinon.stub()
+      };
+    }));
+
+    it('requires update and fetch handlers', function () {
+      expect(function () {
+        watchFilters($scope);
+      }).throwException(TypeError);
+
+      expect(function () {
+        watchFilters($scope, {});
+      }).throwException(TypeError);
+
+      expect(function () {
+        watchFilters($scope, { update: _.noop, refresh: _.noop });
+      }).throwException(TypeError);
+    });
+
+    it('listens to the filters on state', function () {
+      watchFilters($scope, { update: _.noop, fetch: _.noop });
+      expect($scope.$watch).to.have.property('callCount', 1);
+
+      var call = $scope.$watch.getCall(0);
+      expect(call.args[0]).to.be('state.filters');
+    });
+
+    describe('change handling', function () {
+      require('test_utils/no_digest_promises').activateForSuite();
+
+      it('calls update and fetch', function () {
+        var onFetch = sinon.stub();
+        var onUpdate = sinon.stub();
+
+        watchFilters($scope, { update: onUpdate, fetch: onFetch });
+        var handler = $scope.$watch.args[0][1];
+
+        return handler([ {} ], [])
+        .then(function () {
+          expect(onUpdate).to.have.property('callCount', 1);
+          expect(onFetch).to.have.property('callCount', 1);
+        });
+      });
+
+      it('only calls update if all filters are disabled', function () {
+        var onFetch = sinon.stub();
+        var onUpdate = sinon.stub();
+
+        watchFilters($scope, { update: onUpdate, fetch: onFetch });
+        var handler = $scope.$watch.args[0][1];
+
+        return handler([ ], [ { meta: { disabled: true } } ])
+        .then(function () {
+          expect(onUpdate).to.have.property('callCount', 1);
+          expect(onFetch).to.have.property('callCount', 0);
+        });
+      });
+
+      it('calls nothing if there were no changes', function () {
+        var onFetch = sinon.stub();
+        var onUpdate = sinon.stub();
+
+        watchFilters($scope, { update: onUpdate, fetch: onFetch });
+        var handler = $scope.$watch.args[0][1];
+        var cur = [];
+        var prev = cur;
+
+        return Promise.try(handler, [cur, prev])
+        .then(function () {
+          expect(onUpdate).to.have.property('callCount', 0);
+          expect(onFetch).to.have.property('callCount', 0);
+        });
+      });
+    });
+
+  });
+});