From deb154381ade433d780116e165209031e9a2de79 Mon Sep 17 00:00:00 2001
From: Matthias Wilhelm <matthias.wilhelm@elastic.co>
Date: Thu, 28 Nov 2019 15:09:17 +0100
Subject: [PATCH] [Discover] Improve Percy functional tests (#51699) (#51874)

* Implement new wait for chart rendered function

* Add findByCssSelector to ensure the charts have been rendered
---
 .../tests/discover/chart_visualization.js              | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/test/visual_regression/tests/discover/chart_visualization.js b/test/visual_regression/tests/discover/chart_visualization.js
index 540d95973b54..c90f29c66acb 100644
--- a/test/visual_regression/tests/discover/chart_visualization.js
+++ b/test/visual_regression/tests/discover/chart_visualization.js
@@ -27,6 +27,7 @@ export default function ({ getService, getPageObjects }) {
   const kibanaServer = getService('kibanaServer');
   const PageObjects = getPageObjects(['common', 'discover', 'header', 'timePicker']);
   const visualTesting = getService('visualTesting');
+  const find = getService('find');
   const defaultSettings = {
     defaultIndex: 'logstash-*',
     'discover:sampleSize': 1
@@ -48,10 +49,12 @@ export default function ({ getService, getPageObjects }) {
 
     describe('query', function () {
       this.tags(['skipFirefox']);
+      let renderCounter = 0;
 
       it('should show bars in the correct time zone', async function () {
         await PageObjects.header.awaitGlobalLoadingIndicatorHidden();
         await PageObjects.discover.waitUntilSearchingHasFinished();
+        await find.byCssSelector(`.echChart[data-ech-render-count="${++renderCounter}"]`);
         await visualTesting.snapshot({
           show: ['discoverChart'],
         });
@@ -61,6 +64,7 @@ export default function ({ getService, getPageObjects }) {
         await PageObjects.header.awaitGlobalLoadingIndicatorHidden();
         await PageObjects.discover.waitUntilSearchingHasFinished();
         await PageObjects.discover.setChartInterval('Hourly');
+        await find.byCssSelector(`.echChart[data-ech-render-count="${++renderCounter}"]`);
         await visualTesting.snapshot({
           show: ['discoverChart'],
         });
@@ -70,6 +74,7 @@ export default function ({ getService, getPageObjects }) {
         await PageObjects.header.awaitGlobalLoadingIndicatorHidden();
         await PageObjects.discover.waitUntilSearchingHasFinished();
         await PageObjects.discover.setChartInterval('Daily');
+        await find.byCssSelector(`.echChart[data-ech-render-count="${++renderCounter}"]`);
         await visualTesting.snapshot({
           show: ['discoverChart'],
         });
@@ -79,6 +84,7 @@ export default function ({ getService, getPageObjects }) {
         await PageObjects.header.awaitGlobalLoadingIndicatorHidden();
         await PageObjects.discover.waitUntilSearchingHasFinished();
         await PageObjects.discover.setChartInterval('Weekly');
+        await find.byCssSelector(`.echChart[data-ech-render-count="${++renderCounter}"]`);
         await visualTesting.snapshot({
           show: ['discoverChart'],
         });
@@ -92,6 +98,7 @@ export default function ({ getService, getPageObjects }) {
         });
         await PageObjects.header.awaitGlobalLoadingIndicatorHidden();
         await PageObjects.discover.waitUntilSearchingHasFinished();
+        await find.byCssSelector(`.echChart[data-ech-render-count="${++renderCounter}"]`);
         await visualTesting.snapshot({
           show: ['discoverChart'],
         });
@@ -101,6 +108,7 @@ export default function ({ getService, getPageObjects }) {
         await PageObjects.header.awaitGlobalLoadingIndicatorHidden();
         await PageObjects.discover.waitUntilSearchingHasFinished();
         await PageObjects.discover.setChartInterval('Monthly');
+        await find.byCssSelector(`.echChart[data-ech-render-count="${++renderCounter}"]`);
         await visualTesting.snapshot({
           show: ['discoverChart'],
         });
@@ -110,6 +118,7 @@ export default function ({ getService, getPageObjects }) {
         await PageObjects.header.awaitGlobalLoadingIndicatorHidden();
         await PageObjects.discover.waitUntilSearchingHasFinished();
         await PageObjects.discover.setChartInterval('Yearly');
+        await find.byCssSelector(`.echChart[data-ech-render-count="${++renderCounter}"]`);
         await visualTesting.snapshot({
           show: ['discoverChart'],
         });
@@ -119,6 +128,7 @@ export default function ({ getService, getPageObjects }) {
         await PageObjects.header.awaitGlobalLoadingIndicatorHidden();
         await PageObjects.discover.waitUntilSearchingHasFinished();
         await PageObjects.discover.setChartInterval('Auto');
+        await find.byCssSelector(`.echChart[data-ech-render-count="${++renderCounter}"]`);
         await visualTesting.snapshot({
           show: ['discoverChart'],
         });