maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Maps] update map name in breadcrumb when changed (#34287)

Browse source
This commit is contained in:
Nathan Reese 2019-04-02 10:07:52 -06:00 committed by GitHub
parent d13af852ed
commit dee7b9a5f8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
x-pack/plugins/maps/public/angular/map_controller.js vendored
View file

@ -51,7 +51,7 @@ const app = uiModules.get('app/maps', []);
app.controller('GisMapController', ($scope, $route, config, kbnUrl, localStorage, AppState, globalState, Private) => {
const savedMap = $scope.map = $route.current.locals.map;
const savedMap = $route.current.locals.map;
let unsubscribe;
const store = createMapStore();
@ -203,13 +203,18 @@ app.controller('GisMapController', ($scope, $route, config, kbnUrl, localStorage
}
});
// TODO subscribe to store change and change when store updates title
chrome.breadcrumbs.set([
{ text: i18n.translate('xpack.maps.mapController.mapsBreadcrumbLabel', {
defaultMessage: 'Maps'
}), href: '#' },
{ text: $scope.map.title }
]);
const updateBreadcrumbs = () => {
chrome.breadcrumbs.set([
{
text: i18n.translate('xpack.maps.mapController.mapsBreadcrumbLabel', {
defaultMessage: 'Maps'
}),
href: '#'
},
{ text: savedMap.title }
]);
};
updateBreadcrumbs();
addHelpMenuToAppChrome(chrome);
@ -243,6 +248,8 @@ app.controller('GisMapController', ($scope, $route, config, kbnUrl, localStorage
'data-test-subj': 'saveMapSuccess',
});
updateBreadcrumbs();
if (savedMap.id !== $route.current.params.id) {
$scope.$evalAsync(() => {
kbnUrl.change(`map/{{id}}`, { id: savedMap.id });