From df431c1287dd2af785e266baf52a61f54065fb0e Mon Sep 17 00:00:00 2001 From: Bill McConaghy Date: Tue, 24 Jul 2018 14:13:20 -0400 Subject: [PATCH] fixing flaky management settings test (#21123) (#21155) * fixing flaky management settings test * fix for the fix (awaiting results of find) --- test/functional/page_objects/settings_page.js | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/test/functional/page_objects/settings_page.js b/test/functional/page_objects/settings_page.js index 163d3e089aa3..ce42b6e4dff3 100644 --- a/test/functional/page_objects/settings_page.js +++ b/test/functional/page_objects/settings_page.js @@ -75,8 +75,13 @@ export function SettingsPageProvider({ getService, getPageObjects }) { } async setAdvancedSettingsSelect(propertyName, propertyValue) { - await remote.setFindTimeout(defaultFindTimeout) - .findByCssSelector(`[data-test-subj="advancedSetting-editField-${propertyName}"] option[value="${propertyValue}"]`).click(); + let option; + await retry.try(async () => { + option = await remote.findByCssSelector( + `[data-test-subj="advancedSetting-editField-${propertyName}"] option[value="${propertyValue}"]` + ); + }); + await option.click(); await PageObjects.header.waitUntilLoadingHasFinished(); await testSubjects.click(`advancedSetting-saveEditField-${propertyName}`); await PageObjects.header.waitUntilLoadingHasFinished();