maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Disabling es lint for 3 of the canvas files (#24902)

Browse source 
disabling eslint for Canvas because we are adding in jsx-a11y rules to eslint and adding a missing copyright header
This commit is contained in:
Bhavya RM 2018-10-31 15:23:38 -04:00 committed by GitHub
parent 21bec215dd
commit dfd4917b3d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 24 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
x-pack/plugins/canvas/__tests__/fixtures/function_specs.js
View file

@ -1,3 +1,9 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License;
* you may not use this file except in compliance with the Elastic License.
*/
import { Fn } from '../../common/lib/fn';
import { functions as browserFns } from '../../canvas_plugin_src/functions/browser';
import { functions as commonFns } from '../../canvas_plugin_src/functions/common';

9
x-pack/plugins/canvas/public/components/autocomplete/autocomplete.js
View file

@ -4,6 +4,15 @@
* you may not use this file except in compliance with the Elastic License.
*/
/*disabling eslint because of these jsx-a11y errors(https://www.npmjs.com/package/eslint-plugin-jsx-a11y):
181:7 error Elements with the 'combobox' interactive role must be focusable jsx-a11y/interactive-supports-focus
187:9 error Elements with the ARIA role "combobox" must have the following attributes defined: aria-controls,aria-expanded jsx-a11y/role-has-required-aria-props
209:23 error Elements with the 'option' interactive role must be focusable jsx-a11y/interactive-supports-focus
218:25 error Elements with the ARIA role "option" must have the following attributes defined: aria-selected jsx-a11y/role-has-required-aria-props
*/
/* eslint-disable jsx-a11y/interactive-supports-focus */
/* eslint-disable jsx-a11y/role-has-required-aria-props */
import React from 'react';
import PropTypes from 'prop-types';
import { EuiFlexGroup, EuiFlexItem, EuiPanel, keyCodes } from '@elastic/eui';

4
x-pack/plugins/canvas/public/components/element_content/invalid_element_type.js
View file

@ -3,6 +3,10 @@
* or more contributor license agreements. Licensed under the Elastic License;
* you may not use this file except in compliance with the Elastic License.
*/
/* Disabling eslint because of this jsx-a11y error(https://www.npmjs.com/package/eslint-plugin-jsx-a11y):
11:3 error Non-interactive elements should not be assigned mouse or keyboard event listeners jsx-a11y/no-noninteractive-element-interactions
*/
/* eslint-disable jsx-a11y/no-noninteractive-element-interactions */
import React from 'react';
import PropTypes from 'prop-types';

5
x-pack/plugins/canvas/public/components/element_content/invalid_expression.js
View file

@ -4,6 +4,11 @@
* you may not use this file except in compliance with the Elastic License.
*/
/* Disabling eslint because of this jsx-a11y error(https://www.npmjs.com/package/eslint-plugin-jsx-a11y):
11:3 error Non-interactive elements should not be assigned mouse or keyboard event listeners jsx-a11y/no-noninteractive-element-interactions
*/
/* eslint-disable jsx-a11y/no-noninteractive-element-interactions */
import React from 'react';
import PropTypes from 'prop-types';