From e14a2e6ae8fe52df3cb50afdac3f4067e9ab23db Mon Sep 17 00:00:00 2001 From: Oliver Gupte Date: Fri, 18 Jan 2019 08:24:46 -0800 Subject: [PATCH] [APM] fix object path for request url in sample transaction (#28901) (#28966) * fixes #28899 by using the correct object path to the url `transaction.context.request.url.full` * [APM] fixed IStickeyProperty.val to be stricter to prevent this bug from happening again --- .../Transaction/StickyTransactionProperties.tsx | 2 +- .../apm/public/components/shared/StickyProperties/index.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/x-pack/plugins/apm/public/components/app/TransactionDetails/Transaction/StickyTransactionProperties.tsx b/x-pack/plugins/apm/public/components/app/TransactionDetails/Transaction/StickyTransactionProperties.tsx index 889d81ec6247..2d6554288bd7 100644 --- a/x-pack/plugins/apm/public/components/app/TransactionDetails/Transaction/StickyTransactionProperties.tsx +++ b/x-pack/plugins/apm/public/components/app/TransactionDetails/Transaction/StickyTransactionProperties.tsx @@ -33,7 +33,7 @@ export function StickyTransactionProperties({ const url = idx(transaction, _ => _.context.page.url) || - idx(transaction, _ => _.context.request.url) || + idx(transaction, _ => _.context.request.url.full) || 'N/A'; const duration = transaction.transaction.duration.us; const stickyProperties: IStickyProperty[] = [ diff --git a/x-pack/plugins/apm/public/components/shared/StickyProperties/index.tsx b/x-pack/plugins/apm/public/components/shared/StickyProperties/index.tsx index 257dc61abefe..4c72bd7ac85d 100644 --- a/x-pack/plugins/apm/public/components/shared/StickyProperties/index.tsx +++ b/x-pack/plugins/apm/public/components/shared/StickyProperties/index.tsx @@ -21,7 +21,7 @@ import { } from '../../../style/variables'; export interface IStickyProperty { - val: React.ReactNode | Date; + val: JSX.Element | string | Date; label: string; fieldName?: string; width?: 0 | string;