maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[ML] Only update forecasting progress bar if value increases (#34614)

Browse source
This commit is contained in:
Pete Harverson 2019-04-05 17:01:16 +01:00 committed by GitHub
parent bbfe50f39b
commit e222fa64e0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
x-pack/plugins/ml/public/timeseriesexplorer/components/forecasting_modal/forecasting_modal.js
View file

@ -223,7 +223,14 @@ export const ForecastingModal = injectI18n(class ForecastingModal extends Compon
const progress = _.get(resp, ['stats', 'forecast_progress'], previousProgress);
const status = _.get(resp, ['stats', 'forecast_status']);
this.setState({ forecastProgress: Math.round(100 * progress) });
// The requests for forecast stats can get routed to different shards,
// and if these operate at different speeds there is a chance that a
// previous request could arrive later.
// The progress reported by the back-end should never go down, so
// to be on the safe side, only update state if progress has increased.
if (progress > previousProgress) {
this.setState({ forecastProgress: Math.round(100 * progress) });
}
// Display any messages returned in the request stats.
let messages = _.get(resp, ['stats', 'forecast_messages'], []);
@ -286,7 +293,12 @@ export const ForecastingModal = injectI18n(class ForecastingModal extends Compon
}
} else {
previousProgress = progress;
if (progress > previousProgress) {
previousProgress = progress;
}
// Reset the 'no progress' check value.
noProgressMs = 0;
}
}