maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix tsvb chart test (#44657)

Browse source 
* enable switch index patterns test

* run ciGroup6 20x times

* [page_objects/visual_builder_page] retry selecting index pattern

* Revert "run ciGroup6 20x times"

This reverts commit 2151ea9905.

* [services/combo_box] clear input in seperate function

* run ciGroup12 30x times

* update logging message

* Revert "run ciGroup12 30x times"

This reverts commit 08fac11139.
This commit is contained in:
Dmitry Lemeshko 2019-09-27 23:44:24 +03:00 committed by GitHub
parent fd2bfe9742
commit e352f516d7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 18 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
test/functional/apps/visualize/_tsvb_chart.ts
View file

@ -94,8 +94,7 @@ export default function({ getService, getPageObjects }: FtrProviderContext) {
});
});
// FLAKY: https://github.com/elastic/kibana/issues/44132
describe.skip('switch index patterns', () => {
describe('switch index patterns', () => {
beforeEach(async () => {
log.debug('Load kibana_sample_data_flights data');
await esArchiver.loadIfNeeded('kibana_sample_data_flights');

7
test/functional/page_objects/visual_builder_page.ts
View file

@ -49,6 +49,8 @@ export function VisualBuilderPageProvider({ getService, getPageObjects }: FtrPro
await PageObjects.common.navigateToUrl('visualize', 'create?type=metrics');
log.debug('Set absolute time range from "' + fromTime + '" to "' + toTime + '"');
await PageObjects.timePicker.setAbsoluteRange(fromTime, toTime);
// 2 sec sleep until https://github.com/elastic/kibana/issues/46353 is fixed
await PageObjects.common.sleep(2000);
}
public async checkTabIsLoaded(testSubj: string, name: string) {
@ -413,7 +415,10 @@ export function VisualBuilderPageProvider({ getService, getPageObjects }: FtrPro
}
public async selectIndexPatternTimeField(timeField: string) {
await comboBox.set('metricsIndexPatternFieldsSelect', timeField);
await retry.try(async () => {
await comboBox.clearInputField('metricsIndexPatternFieldsSelect');
await comboBox.set('metricsIndexPatternFieldsSelect', timeField);
});
}
/**

11
test/functional/services/combo_box.ts
View file

@ -281,6 +281,17 @@ export function ComboBoxProvider({ getService, getPageObjects }: FtrProviderCont
.map(option => $(option).text());
return selectedOptions.length === 1 && selectedOptions[0] === value;
}
/**
* Clears input field
* @param comboBoxSelector data-test-subj selector
*/
public async clearInputField(comboBoxSelector: string): Promise<void> {
log.debug(`comboBox.clearInputField, comboBoxSelector:${comboBoxSelector}`);
const comboBoxElement = await testSubjects.find(comboBoxSelector);
const input = await comboBoxElement.findByTagName('input');
await input.clearValueWithKeyboard();
}
}
return new ComboBox();