maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Telemetry] Banner fix (#38769)

Browse source 
* remove always false flag

* telemetry banner flag
This commit is contained in:
Ahmad Bamieh 2019-06-12 17:00:25 +03:00 committed by GitHub
parent f5ab2a1701
commit e5b2239dfb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
x-pack/plugins/telemetry/index.ts
View file

@ -32,6 +32,7 @@ export const telemetry = (kibana: any) => {
enabled: Joi.boolean().default(true),
// `config` is used internally and not intended to be set
config: Joi.string().default(Joi.ref('$defaultConfigPath')),
banner: Joi.boolean().default(true),
url: Joi.when('$dev', {
is: true,
then: Joi.string().default(
@ -66,6 +67,7 @@ export const telemetry = (kibana: any) => {
telemetryEnabled: getXpackConfigWithDeprecated(config, 'telemetry.enabled'),
telemetryUrl: getXpackConfigWithDeprecated(config, 'telemetry.url'),
spacesEnabled: config.get('xpack.spaces.enabled'),
telemetryBanner: config.get('xpack.telemetry.banner'),
telemetryOptedIn: null,
activeSpace: null,
};

2
x-pack/test/functional/config.js
View file

@ -191,6 +191,7 @@ export default async function ({ readConfigFile }) {
'--status.allowAnonymous=true',
'--server.uuid=5b2de169-2785-441b-ae8c-186a1936b17d',
'--xpack.maps.showMapsInspectorAdapter=true',
'--xpack.telemetry.banner=false',
'--xpack.reporting.queue.pollInterval=3000', // make it explicitly the default
'--xpack.reporting.csv.maxSizeBytes=2850', // small-ish limit for cutting off a 1999 byte report
'--stats.maximumWaitTimeForAllCollectorsInS=0',
@ -202,7 +203,6 @@ export default async function ({ readConfigFile }) {
uiSettings: {
defaults: {
'accessibility:disableAnimations': true,
'xPackMonitoring:showBanner': false,
},
},
// the apps section defines the urls that