maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Discover] Unskip functional test of saved queries (#94705) (#95450)

Browse source
This commit is contained in:
Matthias Wilhelm 2021-03-25 21:51:23 +01:00 committed by GitHub
parent 7e196a0353
commit e5c58751d5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
test/functional/apps/discover/_saved_queries.ts
View file

@ -26,8 +26,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const savedQueryManagementComponent = getService('savedQueryManagementComponent');
const testSubjects = getService('testSubjects');
// FLAKY: https://github.com/elastic/kibana/issues/89477
describe.skip('saved queries saved objects', function describeIndexTests() {
describe('saved queries saved objects', function describeIndexTests() {
before(async function () {
log.debug('load kibana index with default index pattern');
await esArchiver.load('discover');
@ -120,6 +119,17 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
it('does not allow saving a query with a non-unique name', async () => {
// this check allows this test to run stand alone, also should fix occacional flakiness
const savedQueryExists = await savedQueryManagementComponent.savedQueryExist('OkResponse');
if (!savedQueryExists) {
await savedQueryManagementComponent.saveNewQuery(
'OkResponse',
'200 responses for .jpg over 24 hours',
true,
true
);
await savedQueryManagementComponent.clearCurrentlyLoadedQuery();
}
await savedQueryManagementComponent.saveNewQueryWithNameError('OkResponse');
});

7
test/functional/services/saved_query_management_component.ts
View file

@ -139,6 +139,13 @@ export function SavedQueryManagementComponentProvider({
await testSubjects.click('savedQueryFormSaveButton');
}
async savedQueryExist(title: string) {
await this.openSavedQueryManagementComponent();
const exists = testSubjects.exists(`~load-saved-query-${title}-button`);
await this.closeSavedQueryManagementComponent();
return exists;
}
async savedQueryExistOrFail(title: string) {
await this.openSavedQueryManagementComponent();
await testSubjects.existOrFail(`~load-saved-query-${title}-button`);