maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[QA] fix dashboard lens by value test (#100196)

Browse source 
* [functional test] remove redundant navigation, wait for lens to be loaded

* fix navigation to new viz

* update test title

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Dzmitry Lemechko 2021-05-17 17:18:20 +02:00 committed by GitHub
parent 532a33b051
commit e63c319032
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
test/functional/apps/visualize/_visualize_listing.ts
View file

@ -45,7 +45,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
describe('search', function () { describe('search', function () {
before(async function () { before(async function () {
// create one new viz // create one new viz
await PageObjects.visualize.gotoVisualizationLandingPage();
await PageObjects.visualize.navigateToNewVisualization(); await PageObjects.visualize.navigateToNewVisualization();
await PageObjects.visualize.clickMarkdownWidget(); await PageObjects.visualize.clickMarkdownWidget();
await PageObjects.visEditor.setMarkdownTxt('HELLO'); await PageObjects.visEditor.setMarkdownTxt('HELLO');

4
test/functional/page_objects/visualize_page.ts
View file

@ -129,14 +129,14 @@ export function VisualizePageProvider({ getService, getPageObjects }: FtrProvide
} }
public async navigateToNewVisualization() { public async navigateToNewVisualization() {
await common.navigateToApp('visualize'); await this.gotoVisualizationLandingPage();
await header.waitUntilLoadingHasFinished(); await header.waitUntilLoadingHasFinished();
await this.clickNewVisualization(); await this.clickNewVisualization();
await this.waitForGroupsSelectPage(); await this.waitForGroupsSelectPage();
} }
public async navigateToNewAggBasedVisualization() { public async navigateToNewAggBasedVisualization() {
await common.navigateToApp('visualize'); await this.gotoVisualizationLandingPage();
await header.waitUntilLoadingHasFinished(); await header.waitUntilLoadingHasFinished();
await this.clickNewVisualization(); await this.clickNewVisualization();
await this.clickAggBasedVisualizations(); await this.clickAggBasedVisualizations();

9
x-pack/test/functional/apps/dashboard/dashboard_lens_by_value.ts
View file

@ -9,7 +9,7 @@ import expect from '@kbn/expect';
import { FtrProviderContext } from '../../ftr_provider_context'; import { FtrProviderContext } from '../../ftr_provider_context';
export default function ({ getPageObjects, getService }: FtrProviderContext) { export default function ({ getPageObjects, getService }: FtrProviderContext) {
const PageObjects = getPageObjects(['common', 'dashboard', 'visualize', 'lens', 'header']); const PageObjects = getPageObjects(['common', 'dashboard', 'visualize', 'lens', 'timePicker']);
const find = getService('find'); const find = getService('find');
const esArchiver = getService('esArchiver'); const esArchiver = getService('esArchiver');
@ -69,11 +69,10 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
expect(titles.indexOf(newTitle)).to.not.be(-1); expect(titles.indexOf(newTitle)).to.not.be(-1);
}); });
it('is no longer linked to a dashboard after visiting the visuali1ze listing page', async () => { it('is no longer linked to a dashboard after visiting the visualize listing page', async () => {
await PageObjects.visualize.gotoVisualizationLandingPage();
await PageObjects.visualize.navigateToNewVisualization(); await PageObjects.visualize.navigateToNewVisualization();
await PageObjects.visualize.clickLensWidget(); await PageObjects.visualize.clickLensWidget();
await PageObjects.header.waitUntilLoadingHasFinished(); await PageObjects.timePicker.ensureHiddenNoDataPopover();
await PageObjects.lens.configureDimension({ await PageObjects.lens.configureDimension({
dimension: 'lnsXY_xDimensionPanel > lns-empty-dimension', dimension: 'lnsXY_xDimensionPanel > lns-empty-dimension',
operation: 'date_histogram', operation: 'date_histogram',
@ -84,8 +83,8 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
operation: 'average', operation: 'average',
field: 'bytes', field: 'bytes',
}); });
await PageObjects.lens.waitForVisualization();
await PageObjects.lens.notLinkedToOriginatingApp(); await PageObjects.lens.notLinkedToOriginatingApp();
await PageObjects.header.waitUntilLoadingHasFinished();
// return to origin should not be present in save modal // return to origin should not be present in save modal
await testSubjects.click('lnsApp_saveButton'); await testSubjects.click('lnsApp_saveButton');