maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[APM] Uses doc link service instead of ElasticDocsLink for linking custom links (#111149) (#111334)

Browse source
This commit is contained in:
István Zoltán Szabó 2021-09-07 13:28:42 +02:00 committed by GitHub
parent cd622af391
commit e7aef42036
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
docs/development/core/public/kibana-plugin-core-public.doclinksstart.links.md
View file

@ -12,6 +12,7 @@ readonly links: {
readonly apm: {
readonly kibanaSettings: string;
readonly supportedServiceMaps: string;
readonly customLinks: string;
readonly droppedTransactionSpans: string;
readonly upgrading: string;
readonly metaData: string;

1
docs/development/core/public/kibana-plugin-core-public.doclinksstart.md
View file

File diff suppressed because one or more lines are too long

2
src/core/public/doc_links/doc_links_service.ts
View file

@ -34,6 +34,7 @@ export class DocLinksService {
apm: {
kibanaSettings: `${KIBANA_DOCS}apm-settings-in-kibana.html`,
supportedServiceMaps: `${KIBANA_DOCS}service-maps.html#service-maps-supported`,
customLinks: `${KIBANA_DOCS}custom-links.html`,
droppedTransactionSpans: `${APM_DOCS}get-started/${DOC_LINK_VERSION}/transaction-spans.html#dropped-spans`,
upgrading: `${APM_DOCS}server/${DOC_LINK_VERSION}/upgrading.html`,
metaData: `${APM_DOCS}get-started/${DOC_LINK_VERSION}/metadata.html`,
@ -464,6 +465,7 @@ export interface DocLinksStart {
readonly apm: {
readonly kibanaSettings: string;
readonly supportedServiceMaps: string;
readonly customLinks: string;
readonly droppedTransactionSpans: string;
readonly upgrading: string;
readonly metaData: string;

1
src/core/public/public.api.md
View file

@ -477,6 +477,7 @@ export interface DocLinksStart {
readonly apm: {
readonly kibanaSettings: string;
readonly supportedServiceMaps: string;
readonly customLinks: string;
readonly droppedTransactionSpans: string;
readonly upgrading: string;
readonly metaData: string;

15
x-pack/plugins/apm/public/components/app/Settings/customize_ui/custom_link/create_edit_custom_link_flyout/Documentation.tsx
View file

@ -6,19 +6,14 @@
*/
import React from 'react';
import { ElasticDocsLink } from '../../../../../shared/Links/ElasticDocsLink';
import { EuiLink } from '@elastic/eui';
import { useApmPluginContext } from '../../../../../../context/apm_plugin/use_apm_plugin_context';
interface Props {
label: string;
}
export function Documentation({ label }: Props) {
return (
<ElasticDocsLink
section="/kibana"
path="/custom-links.html"
target="_blank"
>
{label}
</ElasticDocsLink>
);
const { docLinks } = useApmPluginContext().core;
return <EuiLink href={docLinks.links.apm.customLinks}>{label}</EuiLink>;
}