maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

remove duplicate tab states (#79501)

Browse source 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Alison Goryachev 2020-10-06 09:24:29 -04:00 committed by GitHub
parent 8ec5ce6861
commit e7ed40b0a2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/test_pipeline/documents_dropdown/documents_dropdown.tsx
View file

@ -27,7 +27,7 @@ const i18nTexts = {
defaultMessage: 'Documents:',
}
),
addDocumentsButtonLabel: i18n.translate(
editDocumentsButtonLabel: i18n.translate(
'xpack.ingestPipelines.pipelineEditor.testPipeline.documentsDropdown.editDocumentsButtonLabel',
{
defaultMessage: 'Edit documents',
@ -124,7 +124,7 @@ export const DocumentsDropdown: FunctionComponent<Props> = ({
}}
data-test-subj="editDocumentsButton"
>
{i18nTexts.addDocumentsButtonLabel}
{i18nTexts.editDocumentsButtonLabel}
</EuiButton>
</EuiPopoverFooter>
</EuiPopover>

1
x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/test_pipeline/test_pipeline_actions.tsx
View file

@ -88,6 +88,7 @@ export const TestPipelineActions: FunctionComponent = () => {
{openTestPipelineFlyout && (
<TestPipelineFlyout
activeTab={activeFlyoutTab}
setActiveTab={setActiveFlyoutTab}
processors={{
processors: processors.state.processors,
onFailure: processors.state.onFailure,

10
x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/test_pipeline/test_pipeline_flyout.container.tsx
View file

@ -19,6 +19,7 @@ import { TestPipelineFlyoutTab } from './test_pipeline_tabs';
export interface Props {
activeTab: TestPipelineFlyoutTab;
setActiveTab: (tab: TestPipelineFlyoutTab) => void;
onClose: () => void;
processors: DeserializeResult;
}
@ -35,6 +36,7 @@ export interface TestPipelineFlyoutForm {
export const TestPipelineFlyout: React.FunctionComponent<Props> = ({
onClose,
activeTab,
setActiveTab,
processors,
}) => {
const { services } = useKibana();
@ -56,8 +58,6 @@ export const TestPipelineFlyout: React.FunctionComponent<Props> = ({
},
});
const [selectedTab, setSelectedTab] = useState<TestPipelineFlyoutTab>(activeTab);
const [isRunningTest, setIsRunningTest] = useState<boolean>(false);
const [testingError, setTestingError] = useState<any>(null);
const [testOutput, setTestOutput] = useState<any>(undefined);
@ -155,7 +155,7 @@ export const TestPipelineFlyout: React.FunctionComponent<Props> = ({
});
if (isSuccessful) {
setSelectedTab('output');
setActiveTab('output');
}
};
@ -184,8 +184,8 @@ export const TestPipelineFlyout: React.FunctionComponent<Props> = ({
testOutput={testOutput}
form={form}
validateAndTestPipeline={validateAndTestPipeline}
selectedTab={selectedTab}
setSelectedTab={setSelectedTab}
selectedTab={activeTab}
setSelectedTab={setActiveTab}
testingError={testingError}
onClose={onClose}
/>