maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Core UI] Add missing alt attributes to add data tutorial logos (#62393)

Browse source 
* add empty title prop for data tutorial page icons

* switch alt attribute to title prop

* update snapshots

* enabling skipped a11y tests
This commit is contained in:
Michael Marcialis 2020-04-06 12:15:13 -04:00 committed by GitHub
parent 70ae8aa6f1
commit e86cb42080
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 15 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/plugins/home/public/application/components/__snapshots__/synopsis.test.js.snap generated
View file

@ -9,8 +9,8 @@ exports[`props iconType 1`] = `
href="link_to_item"
icon={
<EuiIcon
alt=""
size="l"
title=""
type="logoApache"
/>
}

4
src/plugins/home/public/application/components/synopsis.js
View file

@ -35,9 +35,9 @@ export function Synopsis({
}) {
let optionalImg;
if (iconUrl) {
optionalImg = <img className="synopsisIcon" src={iconUrl} alt="" />;
optionalImg = <img alt="" className="synopsisIcon" src={iconUrl} />;
} else if (iconType) {
optionalImg = <EuiIcon type={iconType} alt="" size="l" />;
optionalImg = <EuiIcon size="l" title="" type={iconType} />;
}
const classes = classNames('homSynopsis__card', {

7
src/plugins/home/public/application/components/tutorial/__snapshots__/introduction.test.js.snap generated
View file

@ -15,7 +15,6 @@ exports[`props exportedFieldsUrl 1`] = `
>
<h1>
Great tutorial
 
</h1>
</EuiTitle>
</EuiFlexItem>
@ -56,6 +55,7 @@ exports[`props iconType 1`] = `
>
<EuiIcon
size="xl"
title=""
type="logoElastic"
/>
</EuiFlexItem>
@ -67,7 +67,6 @@ exports[`props iconType 1`] = `
>
<h1>
Great tutorial
 
</h1>
</EuiTitle>
</EuiFlexItem>
@ -97,7 +96,7 @@ exports[`props isBeta 1`] = `
>
<h1>
Great tutorial
 
 
<EuiBetaBadge
label="Beta"
/>
@ -130,7 +129,6 @@ exports[`props previewUrl 1`] = `
>
<h1>
Great tutorial
 
</h1>
</EuiTitle>
</EuiFlexItem>
@ -169,7 +167,6 @@ exports[`render 1`] = `
>
<h1>
Great tutorial
 
</h1>
</EuiTitle>
</EuiFlexItem>

11
src/plugins/home/public/application/components/tutorial/introduction.js
View file

@ -76,7 +76,7 @@ function IntroductionUI({
if (iconType) {
icon = (
<EuiFlexItem grow={false}>
<EuiIcon type={iconType} size="xl" />
<EuiIcon size="xl" title="" type={iconType} />
</EuiFlexItem>
);
}
@ -99,8 +99,13 @@ function IntroductionUI({
<EuiFlexItem grow={false}>
<EuiTitle size="l">
<h1>
{title} &nbsp;
{betaBadge}
{title}
{betaBadge && (
<>
&nbsp;
{betaBadge}
</>
)}
</h1>
</EuiTitle>
</EuiFlexItem>

6
x-pack/test/accessibility/apps/home.ts
View file

@ -52,14 +52,12 @@ export default function({ getService, getPageObjects }: FtrProviderContext) {
await a11y.testAppSnapshot();
});
// issue - logo images are missing alt -text https://github.com/elastic/kibana/issues/62239
it.skip('click on ActiveMQ logs panel to open tutorial meets a11y requirements', async () => {
it('click on ActiveMQ logs panel to open tutorial meets a11y requirements', async () => {
await PageObjects.home.clickOnLogsTutorial();
await a11y.testAppSnapshot();
});
// https://github.com/elastic/kibana/issues/62239
it.skip('click on cloud tutorial meets a11y requirements', async () => {
it('click on cloud tutorial meets a11y requirements', async () => {
await PageObjects.home.clickOnCloudTutorial();
await a11y.testAppSnapshot();
});