maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[APM] Service Inventory Updated the EuiBadge to use the behind_text vars instead of the base colors for the health status badges (#77844)

Browse source 
* Use behind_text colors in health status

* Separated badge color usage from getSeverityColor
This commit is contained in:
Ashik Meerankutty 2020-10-02 07:34:22 +05:30 committed by GitHub
parent 6c015cfbef
commit e92a4ab4bf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 19 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
x-pack/plugins/apm/common/service_health_status.ts
View file

@ -54,6 +54,22 @@ export function getServiceHealthStatusColor(
}
}
export function getServiceHealthStatusBadgeColor(
theme: EuiTheme,
status: ServiceHealthStatus
) {
switch (status) {
case ServiceHealthStatus.healthy:
return theme.eui.euiColorVis0_behindText;
case ServiceHealthStatus.warning:
return theme.eui.euiColorVis5_behindText;
case ServiceHealthStatus.critical:
return theme.eui.euiColorVis9_behindText;
case ServiceHealthStatus.unknown:
return theme.eui.euiColorMediumShade;
}
}
export function getServiceHealthStatusLabel(status: ServiceHealthStatus) {
switch (status) {
case ServiceHealthStatus.critical:

4
x-pack/plugins/apm/public/components/app/ServiceOverview/ServiceList/HealthBadge.tsx
View file

@ -6,7 +6,7 @@
import React from 'react';
import { EuiBadge } from '@elastic/eui';
import {
getServiceHealthStatusColor,
getServiceHealthStatusBadgeColor,
getServiceHealthStatusLabel,
ServiceHealthStatus,
} from '../../../../../common/service_health_status';
@ -20,7 +20,7 @@ export function HealthBadge({
const theme = useTheme();
return (
<EuiBadge color={getServiceHealthStatusColor(theme, healthStatus)}>
<EuiBadge color={getServiceHealthStatusBadgeColor(theme, healthStatus)}>
{getServiceHealthStatusLabel(healthStatus)}
</EuiBadge>
);

2
x-pack/plugins/apm/public/components/app/ServiceOverview/__test__/__snapshots__/ServiceOverview.test.tsx.snap generated
View file

@ -153,7 +153,7 @@ NodeList [
>
<span
class="euiBadge euiBadge--iconLeft"
style="background-color: rgb(214, 191, 87); color: rgb(0, 0, 0);"
style="background-color: rgb(241, 216, 111); color: rgb(0, 0, 0);"
title="Warning"
>
<span