maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Time to Visualize] Adds functional tests for editing by value visualize embeddables (#90241) (#91207)

Browse source 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Catherine Liu 2021-02-12 08:57:55 -08:00 committed by GitHub
parent 6ad67fdedd
commit f503aa3eed
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 67 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

67
test/functional/apps/dashboard/edit_visualizations.js
View file

@ -108,5 +108,72 @@ export default function ({ getService, getPageObjects }) {
await PageObjects.common.clickConfirmOnModal();
expect(await testSubjects.exists('visualizationLandingPage')).to.be(true);
});
describe('by value', () => {
it('save and return button returns to dashboard after editing visualization with changes saved', async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.clickNewDashboard();
await createMarkdownVis();
const originalPanelCount = PageObjects.dashboard.getPanelCount();
await editMarkdownVis();
await PageObjects.visualize.saveVisualizationAndReturn();
const markdownText = await testSubjects.find('markdownBody');
expect(await markdownText.getVisibleText()).to.eql(modifiedMarkdownText);
const newPanelCount = PageObjects.dashboard.getPanelCount();
expect(newPanelCount).to.eql(originalPanelCount);
});
it('cancel button returns to dashboard after editing visualization without saving', async () => {
await PageObjects.dashboard.gotoDashboardLandingPage();
await PageObjects.dashboard.clickNewDashboard();
await createMarkdownVis();
await editMarkdownVis();
await PageObjects.visualize.cancelAndReturn(true);
const markdownText = await testSubjects.find('markdownBody');
expect(await markdownText.getVisibleText()).to.eql(originalMarkdownText);
});
it('save to library button returns to dashboard after editing visualization with changes saved', async () => {
await PageObjects.dashboard.gotoDashboardLandingPage();
await PageObjects.dashboard.clickNewDashboard();
await createMarkdownVis();
const originalPanelCount = PageObjects.dashboard.getPanelCount();
await editMarkdownVis();
await PageObjects.visualize.saveVisualization('test save to library', {
redirectToOrigin: true,
});
const markdownText = await testSubjects.find('markdownBody');
expect(await markdownText.getVisibleText()).to.eql(modifiedMarkdownText);
const newPanelCount = PageObjects.dashboard.getPanelCount();
expect(newPanelCount).to.eql(originalPanelCount);
});
it('should lose its connection to the dashboard when creating new visualization', async () => {
await PageObjects.visualize.gotoVisualizationLandingPage();
await PageObjects.visualize.clickNewVisualization();
await PageObjects.visualize.clickMarkdownWidget();
await PageObjects.visualize.notLinkedToOriginatingApp();
// return to origin should not be present in save modal
await testSubjects.click('visualizeSaveButton');
const redirectToOriginCheckboxExists = await testSubjects.exists(
'returnToOriginModeSwitch'
);
expect(redirectToOriginCheckboxExists).to.be(false);
});
});
});
}