FTR: move basic services under common folder (#66563)
* [CODEOWNERS] set kibana-qa to own test/functional/services * [functional/services] move low-level services to common folder * update codeowners * update imports Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This commit is contained in:
parent
62e8214f90
commit
f575913850
3
.github/CODEOWNERS
vendored
3
.github/CODEOWNERS
vendored
|
@ -130,6 +130,9 @@
|
||||||
|
|
||||||
# Quality Assurance
|
# Quality Assurance
|
||||||
/src/dev/code_coverage @elastic/kibana-qa
|
/src/dev/code_coverage @elastic/kibana-qa
|
||||||
|
/test/functional/services/common @elastic/kibana-qa
|
||||||
|
/test/functional/services/lib @elastic/kibana-qa
|
||||||
|
/test/functional/services/remote @elastic/kibana-qa
|
||||||
|
|
||||||
# Platform
|
# Platform
|
||||||
/src/core/ @elastic/kibana-platform
|
/src/core/ @elastic/kibana-platform
|
||||||
|
|
|
@ -19,8 +19,8 @@
|
||||||
import { Role } from './role';
|
import { Role } from './role';
|
||||||
import { User } from './user';
|
import { User } from './user';
|
||||||
import { FtrProviderContext } from '../../ftr_provider_context';
|
import { FtrProviderContext } from '../../ftr_provider_context';
|
||||||
import { Browser } from '../../../functional/services/browser';
|
import { Browser } from '../../../functional/services/common';
|
||||||
import { TestSubjects } from '../../../functional/services/test_subjects';
|
import { TestSubjects } from '../../../functional/services/common';
|
||||||
|
|
||||||
export async function createTestUserService(
|
export async function createTestUserService(
|
||||||
role: Role,
|
role: Role,
|
||||||
|
|
|
@ -24,10 +24,10 @@ import { LegacyActionSequence } from 'selenium-webdriver/lib/actions';
|
||||||
import { ProvidedType } from '@kbn/test/types/ftr';
|
import { ProvidedType } from '@kbn/test/types/ftr';
|
||||||
|
|
||||||
import Jimp from 'jimp';
|
import Jimp from 'jimp';
|
||||||
import { modifyUrl } from '../../../src/core/utils';
|
import { modifyUrl } from '../../../../src/core/utils';
|
||||||
import { WebElementWrapper } from './lib/web_element_wrapper';
|
import { WebElementWrapper } from '../lib/web_element_wrapper';
|
||||||
import { FtrProviderContext } from '../ftr_provider_context';
|
import { FtrProviderContext } from '../../ftr_provider_context';
|
||||||
import { Browsers } from './remote/browsers';
|
import { Browsers } from '../remote/browsers';
|
||||||
|
|
||||||
export type Browser = ProvidedType<typeof BrowserProvider>;
|
export type Browser = ProvidedType<typeof BrowserProvider>;
|
||||||
export async function BrowserProvider({ getService }: FtrProviderContext) {
|
export async function BrowserProvider({ getService }: FtrProviderContext) {
|
|
@ -22,7 +22,7 @@ import { writeFile, mkdir } from 'fs';
|
||||||
import { promisify } from 'util';
|
import { promisify } from 'util';
|
||||||
|
|
||||||
import del from 'del';
|
import del from 'del';
|
||||||
import { FtrProviderContext } from '../ftr_provider_context';
|
import { FtrProviderContext } from '../../ftr_provider_context';
|
||||||
|
|
||||||
interface Test {
|
interface Test {
|
||||||
fullTitle(): string;
|
fullTitle(): string;
|
|
@ -18,8 +18,8 @@
|
||||||
*/
|
*/
|
||||||
|
|
||||||
import { WebDriver, WebElement, By, until } from 'selenium-webdriver';
|
import { WebDriver, WebElement, By, until } from 'selenium-webdriver';
|
||||||
import { FtrProviderContext } from '../ftr_provider_context';
|
import { FtrProviderContext } from '../../ftr_provider_context';
|
||||||
import { WebElementWrapper } from './lib/web_element_wrapper';
|
import { WebElementWrapper } from '../lib/web_element_wrapper';
|
||||||
|
|
||||||
export async function FindProvider({ getService }: FtrProviderContext) {
|
export async function FindProvider({ getService }: FtrProviderContext) {
|
||||||
const log = getService('log');
|
const log = getService('log');
|
25
test/functional/services/common/index.ts
Normal file
25
test/functional/services/common/index.ts
Normal file
|
@ -0,0 +1,25 @@
|
||||||
|
/*
|
||||||
|
* Licensed to Elasticsearch B.V. under one or more contributor
|
||||||
|
* license agreements. See the NOTICE file distributed with
|
||||||
|
* this work for additional information regarding copyright
|
||||||
|
* ownership. Elasticsearch B.V. licenses this file to you under
|
||||||
|
* the Apache License, Version 2.0 (the "License"); you may
|
||||||
|
* not use this file except in compliance with the License.
|
||||||
|
* You may obtain a copy of the License at
|
||||||
|
*
|
||||||
|
* http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
*
|
||||||
|
* Unless required by applicable law or agreed to in writing,
|
||||||
|
* software distributed under the License is distributed on an
|
||||||
|
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
||||||
|
* KIND, either express or implied. See the License for the
|
||||||
|
* specific language governing permissions and limitations
|
||||||
|
* under the License.
|
||||||
|
*/
|
||||||
|
|
||||||
|
export { BrowserProvider, Browser } from './browser';
|
||||||
|
export { FailureDebuggingProvider } from './failure_debugging';
|
||||||
|
export { FindProvider } from './find';
|
||||||
|
export { ScreenshotsProvider } from './screenshots';
|
||||||
|
export { SnapshotsProvider } from './snapshots';
|
||||||
|
export { TestSubjectsProvider, TestSubjects } from './test_subjects';
|
|
@ -23,9 +23,9 @@ import { promisify } from 'util';
|
||||||
|
|
||||||
import del from 'del';
|
import del from 'del';
|
||||||
|
|
||||||
import { comparePngs } from './lib/compare_pngs';
|
import { comparePngs } from '../lib/compare_pngs';
|
||||||
import { FtrProviderContext } from '../ftr_provider_context';
|
import { FtrProviderContext } from '../../ftr_provider_context';
|
||||||
import { WebElementWrapper } from './lib/web_element_wrapper';
|
import { WebElementWrapper } from '../lib/web_element_wrapper';
|
||||||
|
|
||||||
const mkdirAsync = promisify(mkdir);
|
const mkdirAsync = promisify(mkdir);
|
||||||
const writeFileAsync = promisify(writeFile);
|
const writeFileAsync = promisify(writeFile);
|
|
@ -23,7 +23,7 @@ import { promisify } from 'util';
|
||||||
|
|
||||||
import expect from '@kbn/expect';
|
import expect from '@kbn/expect';
|
||||||
import del from 'del';
|
import del from 'del';
|
||||||
import { FtrProviderContext } from '../ftr_provider_context';
|
import { FtrProviderContext } from '../../ftr_provider_context';
|
||||||
|
|
||||||
const mkdirAsync = promisify(mkdir);
|
const mkdirAsync = promisify(mkdir);
|
||||||
const writeFileAsync = promisify(writeFile);
|
const writeFileAsync = promisify(writeFile);
|
|
@ -20,8 +20,8 @@
|
||||||
import testSubjSelector from '@kbn/test-subj-selector';
|
import testSubjSelector from '@kbn/test-subj-selector';
|
||||||
import { map as mapAsync } from 'bluebird';
|
import { map as mapAsync } from 'bluebird';
|
||||||
import { ProvidedType } from '@kbn/test/types/ftr';
|
import { ProvidedType } from '@kbn/test/types/ftr';
|
||||||
import { WebElementWrapper } from './lib/web_element_wrapper';
|
import { WebElementWrapper } from '../lib/web_element_wrapper';
|
||||||
import { FtrProviderContext } from '../ftr_provider_context';
|
import { FtrProviderContext } from '../../ftr_provider_context';
|
||||||
|
|
||||||
interface ExistsOptions {
|
interface ExistsOptions {
|
||||||
timeout?: number;
|
timeout?: number;
|
|
@ -20,7 +20,14 @@
|
||||||
import { services as commonServiceProviders } from '../../common/services';
|
import { services as commonServiceProviders } from '../../common/services';
|
||||||
|
|
||||||
import { AppsMenuProvider } from './apps_menu';
|
import { AppsMenuProvider } from './apps_menu';
|
||||||
import { BrowserProvider } from './browser';
|
import {
|
||||||
|
BrowserProvider,
|
||||||
|
FailureDebuggingProvider,
|
||||||
|
FindProvider,
|
||||||
|
ScreenshotsProvider,
|
||||||
|
SnapshotsProvider,
|
||||||
|
TestSubjectsProvider,
|
||||||
|
} from './common';
|
||||||
import { ComboBoxProvider } from './combo_box';
|
import { ComboBoxProvider } from './combo_box';
|
||||||
import {
|
import {
|
||||||
DashboardAddPanelProvider,
|
DashboardAddPanelProvider,
|
||||||
|
@ -33,19 +40,14 @@ import {
|
||||||
import { DocTableProvider } from './doc_table';
|
import { DocTableProvider } from './doc_table';
|
||||||
import { ElasticChartProvider } from './elastic_chart';
|
import { ElasticChartProvider } from './elastic_chart';
|
||||||
import { EmbeddingProvider } from './embedding';
|
import { EmbeddingProvider } from './embedding';
|
||||||
import { FailureDebuggingProvider } from './failure_debugging';
|
|
||||||
import { FilterBarProvider } from './filter_bar';
|
import { FilterBarProvider } from './filter_bar';
|
||||||
import { FindProvider } from './find';
|
|
||||||
import { FlyoutProvider } from './flyout';
|
import { FlyoutProvider } from './flyout';
|
||||||
import { GlobalNavProvider } from './global_nav';
|
import { GlobalNavProvider } from './global_nav';
|
||||||
import { InspectorProvider } from './inspector';
|
import { InspectorProvider } from './inspector';
|
||||||
import { QueryBarProvider } from './query_bar';
|
import { QueryBarProvider } from './query_bar';
|
||||||
import { RemoteProvider } from './remote';
|
import { RemoteProvider } from './remote';
|
||||||
import { RenderableProvider } from './renderable';
|
import { RenderableProvider } from './renderable';
|
||||||
import { ScreenshotsProvider } from './screenshots';
|
|
||||||
import { SnapshotsProvider } from './snapshots';
|
|
||||||
import { TableProvider } from './table';
|
import { TableProvider } from './table';
|
||||||
import { TestSubjectsProvider } from './test_subjects';
|
|
||||||
import { ToastsProvider } from './toasts';
|
import { ToastsProvider } from './toasts';
|
||||||
// @ts-ignore not TS yet
|
// @ts-ignore not TS yet
|
||||||
import { PieChartProvider } from './visualizations';
|
import { PieChartProvider } from './visualizations';
|
||||||
|
|
Loading…
Reference in a new issue