maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix flaky lab mode test (#17622)

Browse source
This commit is contained in:
Tim Roes 2018-04-11 09:00:53 +02:00 committed by GitHub
parent 7b827e87a5
commit f5b28c18fb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/core_plugins/kibana/public/discover/partials/load_search.html
View file

@ -1,4 +1,4 @@
<form role="form" ng-submit="fetch()">
<form role="form" ng-submit="fetch()" data-test-subj="loadSearchForm">
<h2 class="kuiLocalDropdownTitle">
Open Search
</h2>

2
test/functional/apps/visualize/_lab_mode.js
View file

@ -9,6 +9,7 @@ export default function ({ getService, getPageObjects }) {
it('disabling does not break loading saved searches', async () => {
await PageObjects.common.navigateToUrl('discover', '');
await PageObjects.discover.saveSearch('visualize_lab_mode_test');
await PageObjects.discover.openSavedSearch();
const hasSaved = await PageObjects.discover.hasSavedSearch('visualize_lab_mode_test');
expect(hasSaved).to.be(true);
@ -21,6 +22,7 @@ export default function ({ getService, getPageObjects }) {
// Expect the discover still to list that saved visualization in the open list
await PageObjects.header.clickDiscover();
await PageObjects.discover.openSavedSearch();
const stillHasSaved = await PageObjects.discover.hasSavedSearch('visualize_lab_mode_test');
expect(stillHasSaved).to.be(true);
log.info('found saved search after toggling enableLabs mode');

7
test/functional/page_objects/discover_page.js
View file

@ -53,9 +53,12 @@ export function DiscoverPageProvider({ getService, getPageObjects }) {
return await Promise.all(headerElements.map(el => el.getVisibleText()));
}
async hasSavedSearch(searchName) {
async openSavedSearch() {
await this.clickLoadSavedSearchButton();
await PageObjects.header.waitUntilLoadingHasFinished();
await testSubjects.exists('loadSearchForm');
}
async hasSavedSearch(searchName) {
const searchLink = await find.byPartialLinkText(searchName);
return searchLink.isDisplayed();
}