From faa48d591d30c19fd1c057129769ac5498f18709 Mon Sep 17 00:00:00 2001
From: sainthkh <sainthkh@naver.com>
Date: Thu, 31 Oct 2019 19:40:53 +0900
Subject: [PATCH] eslint no-restricted-path false positive: bug caused by dir
 names that start with "index". (#46544)

* index* to index.{ts,tsx}

* Added test.

* Added invalid test.

* Added js.
---
 .eslintrc.js                                  |  4 +-
 .../server/index_patterns/index.js            |  1 +
 .../rules/__tests__/no_restricted_paths.js    | 50 +++++++++++++++++++
 3 files changed, 53 insertions(+), 2 deletions(-)
 create mode 100644 packages/kbn-eslint-plugin-eslint/rules/__tests__/files/no_restricted_paths/server/index_patterns/index.js

diff --git a/.eslintrc.js b/.eslintrc.js
index 8ed89d47d43e..310ee47819e3 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -362,10 +362,10 @@ module.exports = {
                   '!src/core/server/*.test.mocks.ts',
 
                   'src/plugins/**/public/**/*',
-                  '!src/plugins/**/public/index*',
+                  '!src/plugins/**/public/index.{js,ts,tsx}',
 
                   'src/plugins/**/server/**/*',
-                  '!src/plugins/**/server/index*',
+                  '!src/plugins/**/server/index.{js,ts,tsx}',
                 ],
                 allowSameFolder: true,
               },
diff --git a/packages/kbn-eslint-plugin-eslint/rules/__tests__/files/no_restricted_paths/server/index_patterns/index.js b/packages/kbn-eslint-plugin-eslint/rules/__tests__/files/no_restricted_paths/server/index_patterns/index.js
new file mode 100644
index 000000000000..d15de7d98a9e
--- /dev/null
+++ b/packages/kbn-eslint-plugin-eslint/rules/__tests__/files/no_restricted_paths/server/index_patterns/index.js
@@ -0,0 +1 @@
+/* eslint-disable */
diff --git a/packages/kbn-eslint-plugin-eslint/rules/__tests__/no_restricted_paths.js b/packages/kbn-eslint-plugin-eslint/rules/__tests__/no_restricted_paths.js
index f393a867d95e..577be820ccc7 100644
--- a/packages/kbn-eslint-plugin-eslint/rules/__tests__/no_restricted_paths.js
+++ b/packages/kbn-eslint-plugin-eslint/rules/__tests__/no_restricted_paths.js
@@ -172,6 +172,27 @@ ruleTester.run('@kbn/eslint/no-restricted-paths', rule, {
         },
       ],
     },
+
+    {
+      // Check if dirs that start with 'index' work correctly.
+      code: 'import { X } from "./index_patterns"',
+      filename: path.join(__dirname, './files/no_restricted_paths/server/b.js'),
+      options: [
+        {
+          basePath: __dirname,
+          zones: [
+            {
+              target: ['files/no_restricted_paths/(public|server)/**/*'],
+              from: [
+                'files/no_restricted_paths/server/**/*',
+                '!files/no_restricted_paths/server/index.{ts,tsx}',
+              ],
+              allowSameFolder: true,
+            },
+          ],
+        },
+      ],
+    },
   ],
 
   invalid: [
@@ -369,5 +390,34 @@ ruleTester.run('@kbn/eslint/no-restricted-paths', rule, {
         },
       ],
     },
+
+    {
+      // Don't use index*.
+      // It won't work with dirs that start with 'index'.
+      code: 'import { X } from "./index_patterns"',
+      filename: path.join(__dirname, './files/no_restricted_paths/server/b.js'),
+      options: [
+        {
+          basePath: __dirname,
+          zones: [
+            {
+              target: ['files/no_restricted_paths/(public|server)/**/*'],
+              from: [
+                'files/no_restricted_paths/server/**/*',
+                '!files/no_restricted_paths/server/index*',
+              ],
+              allowSameFolder: true,
+            },
+          ],
+        },
+      ],
+      errors: [
+        {
+          message: 'Unexpected path "./index_patterns" imported in restricted zone.',
+          line: 1,
+          column: 19,
+        },
+      ],
+    },
   ],
 });