maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[buildkite] Fix off-by-one problem for test failure annotations (#113852)

Browse source
This commit is contained in:
Brian Seeders 2021-10-04 19:29:43 -04:00 committed by GitHub
parent 55bd942a1f
commit fc89528c40
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
packages/kbn-test/src/failed_tests_reporter/report_failures_to_file.ts
View file

@ -76,6 +76,12 @@ export function reportFailuresToFile(log: ToolingLog, failures: TestFailure[]) {
.flat()
.join('\n');
// Buildkite steps that use `parallelism` need a numerical suffix added to identify them
// We should also increment the number by one, since it's 0-based
const jobNumberSuffix = process.env.BUILDKITE_PARALLEL_JOB
? ` #${parseInt(process.env.BUILDKITE_PARALLEL_JOB, 10) + 1}`
: '';
const failureJSON = JSON.stringify(
{
...failure,
@ -84,9 +90,7 @@ export function reportFailuresToFile(log: ToolingLog, failures: TestFailure[]) {
jobId: process.env.BUILDKITE_JOB_ID || '',
url: process.env.BUILDKITE_BUILD_URL || '',
jobName: process.env.BUILDKITE_LABEL
? `${process.env.BUILDKITE_LABEL}${
process.env.BUILDKITE_PARALLEL_JOB ? ` #${process.env.BUILDKITE_PARALLEL_JOB}` : ''
}`
? `${process.env.BUILDKITE_LABEL}${jobNumberSuffix}`
: '',
},
null,