maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Security Solution][Exceptions] Adds error catch to Exceptions toString method (#105928)

Browse source
This commit is contained in:
Davis Plumlee 2021-07-16 14:51:46 -06:00 committed by GitHub
parent dadeb78b44
commit fcd515f942
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
x-pack/plugins/security_solution/public/common/components/exceptions/helpers.test.tsx
View file

@ -26,8 +26,9 @@ import {
getProcessCodeSignature,
retrieveAlertOsTypes,
filterIndexPatterns,
getCodeSignatureValue,
} from './helpers';
import { AlertData } from './types';
import { AlertData, Flattened } from './types';
import {
ListOperatorTypeEnum as OperatorTypeEnum,
EntriesArray,
@ -41,6 +42,7 @@ import { getCommentsArrayMock } from '../../../../../lists/common/schemas/types/
import { fields } from '../../../../../../../src/plugins/data/common/index_patterns/fields/fields.mocks';
import { ENTRIES, OLD_DATE_RELATIVE_TO_DATE_NOW } from '../../../../../lists/common/constants.mock';
import { IFieldType, IIndexPattern } from 'src/plugins/data/common';
import { CodeSignature } from '../../../../common/ecs/file';
jest.mock('uuid', () => ({
v4: jest.fn().mockReturnValue('123'),
@ -340,6 +342,17 @@ describe('Exception helpers', () => {
});
});
describe('#getCodeSignatureValue', () => {
test('it should return empty string if code_signature nested value are undefined', () => {
// Using the unsafe casting because with our types this shouldn't be possible but there have been issues with old data having undefined values in these fields
const payload = ([{ trusted: undefined, subject_name: undefined }] as unknown) as Flattened<
CodeSignature[]
>;
const result = getCodeSignatureValue(payload);
expect(result).toEqual([{ trusted: '', subjectName: '' }]);
});
});
describe('#entryHasNonEcsType', () => {
const mockEcsIndexPattern = {
title: 'testIndex',

4
x-pack/plugins/security_solution/public/common/components/exceptions/helpers.tsx
View file

@ -325,8 +325,8 @@ export const getCodeSignatureValue = (
if (Array.isArray(codeSignature) && codeSignature.length > 0) {
return codeSignature.map((signature) => {
return {
subjectName: signature.subject_name ?? '',
trusted: signature.trusted.toString() ?? '',
subjectName: signature?.subject_name ?? '',
trusted: signature?.trusted?.toString() ?? '',
};
});
} else {