maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Alerting] Fixed search results are not updated when search term is removed on Rules and Connectors page (#103663) (#103849)

Browse source
This commit is contained in:
Yuliia Naumenko 2021-06-30 14:17:57 +03:00 committed by GitHub
parent 876d1f5f5f
commit fe30b1bec8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 43 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
x-pack/plugins/triggers_actions_ui/public/application/sections/alerts_list/components/alerts_list.tsx
View file

@ -539,7 +539,12 @@ export const AlertsList: React.FunctionComponent = () => {
fullWidth
isClearable
data-test-subj="alertSearchField"
onChange={(e) => setInputText(e.target.value)}
onChange={(e) => {
setInputText(e.target.value);
if (e.target.value === '') {
setSearchText(e.target.value);
}
}}
onKeyUp={(e) => {
if (e.keyCode === ENTER_KEY) {
setSearchText(inputText);

37
x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alerts_list.ts
View file

@ -109,6 +109,43 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
]);
});
it('should update alert list on the search clear button click', async () => {
await createAlert({ name: 'b' });
await createAlert({ name: 'c' });
await refreshAlertsList();
await pageObjects.triggersActionsUI.searchAlerts('b');
const searchResults = await pageObjects.triggersActionsUI.getAlertsList();
expect(searchResults).to.eql([
{
name: 'b',
tagsText: 'foo, bar',
alertType: 'Test: Noop',
interval: '1m',
},
]);
const searchClearButton = await find.byCssSelector('.euiFormControlLayoutClearButton');
await searchClearButton.click();
await find.byCssSelector(
'.euiBasicTable[data-test-subj="alertsList"]:not(.euiBasicTable-loading)'
);
const searchResultsAfterClear = await pageObjects.triggersActionsUI.getAlertsList();
expect(searchResultsAfterClear).to.eql([
{
name: 'b',
tagsText: 'foo, bar',
alertType: 'Test: Noop',
interval: '1m',
},
{
name: 'c',
tagsText: 'foo, bar',
alertType: 'Test: Noop',
interval: '1m',
},
]);
});
it('should search for tags', async () => {
const createdAlert = await createAlert();
await refreshAlertsList();