maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[ML] Anomaly Explorer: Fix view by selection when filter is active. (#55717)

Browse source 
Fixes the view-by selection when a KQL filter gets active and restores previous behavior:
- If the filter includes AND view-by switches to Job ID.
- Otherwise the view-by selection switches to the first available option present in the KQL filter
- Additionally, the view-by dropdown options get filtered down to the options present in the KQL filter
This commit is contained in:
Walter Rafelsberger 2020-01-24 11:25:55 +01:00 committed by GitHub
parent ef4b395873
commit fee22e8d94
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
x-pack/legacy/plugins/ml/public/application/explorer/reducers/explorer_reducer/set_influencer_filter_settings.ts
View file

@ -23,17 +23,20 @@ export function setInfluencerFilterSettings(
const { selectedCells, viewBySwimlaneOptions } = state;
let selectedViewByFieldName = state.viewBySwimlaneFieldName;
const filteredViewBySwimlaneOptions = viewBySwimlaneOptions.filter(d =>
filteredFields.includes(d)
);
// if it's an AND filter set view by swimlane to job ID as the others will have no results
if (isAndOperator && selectedCells === null) {
if (isAndOperator && selectedCells === undefined) {
selectedViewByFieldName = VIEW_BY_JOB_LABEL;
} else {
// Set View by dropdown to first relevant fieldName based on incoming filter if there's no cell selection already
// or if selected cell is from overall swimlane as this won't include an additional influencer filter
for (let i = 0; i < filteredFields.length; i++) {
if (
viewBySwimlaneOptions.includes(filteredFields[i]) &&
(selectedCells === null || (selectedCells && selectedCells.type === 'overall'))
filteredViewBySwimlaneOptions.includes(filteredFields[i]) &&
(selectedCells === undefined || (selectedCells && selectedCells.type === 'overall'))
) {
selectedViewByFieldName = filteredFields[i];
break;
@ -53,5 +56,6 @@ export function setInfluencerFilterSettings(
selectedViewByFieldName === VIEW_BY_JOB_LABEL ||
filteredFields.includes(selectedViewByFieldName) === false,
viewBySwimlaneFieldName: selectedViewByFieldName,
viewBySwimlaneOptions: filteredViewBySwimlaneOptions,
};
}