Commit graph

1656 commits

Author SHA1 Message Date
Devin W. Hurley
dadeb78b44
[RAC] [RBAC] add space ids array to each alert document (#105173)
* kind of working solution... need to fix types.. would be great if all of this could go in the authorization class but I don't think we have access to the spaceids when we generate the kibana security action strings?

* update mapping type as array:true for space_ids field, fixes types, updates jest tests, adds integration tests

* undo changes in alerting authz class

* update snapshot for apm api integration test for rules writing alerts

* fix apm integration tests

* omit version and sequence from expected outcome

* re-add space id after this code was moved in master

* add another default space id to test

* fixes bug to remove duplicate spaceids

* add space ids filter to elasticsearch query, updates detection role

* update snapshot

* update type docs for alerts client

* remove dead code

* fix type error

* renames space ids field on alert documents from kibana.rac.alert.space_ids to kibana.space_ids

* fixes kb-rule-data-utils package

* update snapshots

* remove references to kibana.rac.alert.space_ids and replace with kibana.space_ids in rule registry integration tests and apm integration tests

* fix apm functional test snapshots

* undo index name changes I made in apm integration test configs

* update typedocs references to upstream, not local repo
2021-07-16 16:05:46 -04:00
Michael Olorunnisola
9c5d5c1137
[Security Solution][RAC] Implement hover actions (#105500) 2021-07-16 12:53:41 -07:00
Dario Gieselaar
9fcfeba464
[UX] make route match optional in EnvironmentFilter (#105780)
Closes #105757.
2021-07-16 10:52:40 -04:00
Alison Goryachev
d3ccb982c7
Improve painless validation handling in monaco (#105799) 2021-07-16 08:36:59 -04:00
Dario Gieselaar
821aeb1ff4
[APM] Typed client-side routing (#104274)
* [APM] @kbn/typed-router-config

* [APM] typed route config

* Breadcrumbs, wildcards

* Migrate settings, home

* Migrate part of service detail page

* Migrate remaining routes, tests

* Set maxWorkers for precommit script to 4

* Add jest types to tsconfigs

* Make sure transaction distribution data is fetched

* Fix typescript errors

* Remove usage of react-router's useParams

* Add route() utility function

* Don't use ApmServiceContext for alert flyouts

* Don't add onClick handler for breadcrumb

* Clarify ts-ignore

* Remove unused things

* Update documentation

* Use useServiceName() in ServiceMap component
2021-07-15 11:30:59 +02:00
Yaroslav Kuznietsov
e999b33e54
[Canvas] Expression error (#103048)
* Basic setup of error plugin.

* Removed not used `function` files at `error` expression.

* Moved related components from canvas.

* Changed imports of components.

* Fixed renderer and storybook.

* Fixed types errors.

* Added limits.

* Removed useless translations and fixed .i18nrc.json

* added `done` handler call.

* Added more fixes fo i18nc.

* Added docs.

* More fixes of i18nrc.

* Fixed async functions.

Written current code, based on https://github.com/storybookjs/storybook/issues/7745

* Fixed one test with Expression input.

After changing the way of rendering in stories, all elements are mounting and componentDidMount is involved. The previous snapshot was without
mounted `monaco` editor.

* Fixed storybook error.

* More fixes.

* removed unused translations.

* Removed handlers and changed the way of handling `resize` and calling `done`.

* Fixed i18n error.

* Fixed storybook.

* Replaced Popover with EuiPopover.

* Moved `Popover` back to `canvas`

* Removed `Popover` export from presentation_utils components.

* Moved error_component and debug_component from presentation_util to expression_error.

* Fixed translations and imports.

* Moved `debug renderer` to `expression_error` plugin.

* Fixed error.

* Fixed lazy exports.

* Fixed imports

* Fixed storybook snapshot.

* Removed `.i18nrc.json`.

* Fixed color of `error`.

* Exported concrete elements from popover.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-15 12:19:55 +03:00
Tiago Costa
977039cb76
chore(NA): introduce preset for jest-integration tests on @kbn/test (#105144)
* chore(NA): introduce preset for jest-integration tests on @kbn/test

* chore(NA): fix lockfile

* chore(NA): fix ci

* fix tests (#14)

Co-authored-by: Mikhail Shustov <restrry@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-14 20:53:12 +01:00
Jonathan Budzenski
08ae9714c7
[packages/rule-data-utils] Remove legacy build and watchs cripts (#105630)
This package was migrated to bazel, but the legacy style script commands
still exist in `package.json`.  This removes these scripts to avoid
incorrectly building the package.
2021-07-14 14:20:53 -04:00
Frank Hassanabad
bdf1069e56
[Security Solutions][Detection Engine] Removes dead duplicated code and marks other duplicated code (#105374)
## Summary

* Removes dead duplicated code from `security_solution` and  `lists`
* Adds notes and TODO's where we still have duplicated logic
* Adds notes where I saw that the original deviated from the copy from modifications in one file but not the other.
* DOES NOT fix the bugs existing in one copy but not the other. That should be done when the copied chunks are collapsed into a package. Instead see this issue where I marked those areas: https://github.com/elastic/kibana/issues/105378

See these two files where things have deviated from our duplications as an example:
[security_solution/public/common/components/autocomplete/field.tsx](https://github.com/elastic/kibana/blob/master/x-pack/plugins/security_solution/public/common/components/autocomplete/field.tsx
)
[lists/public/exceptions/components/autocomplete/field.tsx](https://github.com/elastic/kibana/blob/master/x-pack/plugins/lists/public/exceptions/components/autocomplete/field.tsx)

Ref PR where fixes are applied to one of the files but not the other (could be other PR's in addition to this one):
https://github.com/elastic/kibana/pull/87004

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-07-13 16:23:58 -06:00
Yulia Čech
538dfba513
[Console] Autocomplete definitions (manual backport) (#105086)
* [Console] Removed x-pack console extensions folder and moved json files to src/plugins/console

* [Console] Generated console definitions with ES repo on master branch

* Added some overrides and doc links fixes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-13 10:31:50 +02:00
Spencer
e88910a1c6
[kbn/optimizer] rewrite bazel-out paths to source paths (#105154)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-07-12 15:11:49 -07:00
Spencer
f3228a38f4
[kbn/client/ui-settings] support using uiSettings in a specific space (#105116)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-07-09 16:26:26 -04:00
Greg Thompson
fa03028688
Enable CSS-in-JS styling with emotion (#98157)
* emotion deps

* kbn-babel

* kbn-test

* examples

* babel-plugin-styled-components config

* css prop type fixes

* type context

* declaration location

* some emotion types resolved

* clean up

* emotion v10 accomodations

* types

* kbn-crypto

* kbn-telemetry-tools

* bazel

* eslint rule; shared file regex array

* update paths

* Update packages/kbn-eslint-plugin-eslint/rules/module_migration.js

Co-authored-by: Spencer <email@spalger.com>

* remove placeholder styles

* doc api changes

* snapshot updates

* storybook comments

* use constant

* bump new deps

* condense versions

Co-authored-by: Spencer <email@spalger.com>
2021-07-09 13:42:50 -05:00
Jonathan Budzenski
fcb0de47f1
[paths] Add default lookup for kibana.yml at /etc/kibana (#103934)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-08 20:55:18 -04:00
Devin W. Hurley
c77c7fbedb
[RAC] [RBAC] MVP RBAC for alerts as data (#100705)
An MVP of the RBAC work required for the "alerts as data" effort. An example of the existing implementation for alerts would be that of the security solution. The security solution stores its alerts generated from rules in a single data index - .siem-signals. In order to gain or restrict access to alerts, users do so by following the Elasticsearch privilege architecture. A user would need to go into the Kibana role access UI and give explicit read/write/manage permissions for the index itself.

Kibana as a whole is moving away from this model and instead having all user interactions run through the Kibana privilege model. When solutions use saved objects, this authentication layer is abstracted away for them. Because we have chosen to use data indices for alerts, we cannot rely on this abstracted out layer that saved objects provide - we need to provide our own RBAC! Instead of giving users explicit permission to an alerts index, users are instead given access to features. They don't need to know anything about indices, that work we do under the covers now.

Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
Co-authored-by: Yara Tercero <yara.tercero@elastic.co>
2021-07-08 15:24:17 -04:00
Tim Roes
b5e22c9327
Lower Kibana app bundle limits (#104688) 2021-07-08 10:39:54 +02:00
Jonathan Budzenski
0b7eb3f85f
[plugin-helpers] Fix dependency resolution (#104556)
This builds on the changes introduced in #104512, fixing dependency
resolution for the plugin-helpers CLI.  Instead of building a plugin in
isolation, this performs plugin discovery and filters the optimizer
lisst down to the requested plugin.

Testing
1) `cd examples/bfetch_explorer`
1) `node ../../scripts/plugin_helpers build --kibana-version=8.0.0-SNAPSHOT`
2021-07-07 12:40:58 -05:00
Spencer
99b9a2bc5e
[apm-config-loader] refactor config loading (#104197)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-07-06 18:00:20 -04:00
Spencer
1d993b6f26
[kbn/optimizer] maintain bundle ref support when using --filter (#104512)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-07-06 13:45:55 -07:00
Domenico Andreoli
5b49380787
CCS Cypress integration (#103941)
* Add CCS Cypress test runner

* Split flow for CCS Cypress tests

* Make esArchiver load data onto the remote cluster

* Add CCS specific rules with customizable remote name

* Allow overriding @kbn/dev-utils's CA_CERT_PATH

* Add CCS related docs

Co-authored-by: Gloria Hornero <snootchie.boochies@gmail.com>
2021-07-06 09:20:54 -07:00
Aleh Zasypkin
2d48f7fb11
Add userSetup plugin skeleton. (#101610) 2021-07-06 14:41:24 +02:00
Christiane (Tina) Heiligers
9e60da5b46
[Localization] Adds guidelines about markdown and long paragraphs (#104171) 2021-07-01 15:28:48 -04:00
Yaroslav Kuznietsov
b352976b3b
[Canvas] Expression reveal image. (#101987)
* expression_reveal_image skeleton.

* expression_functions added.

* expression_renderers added.

* Backup of daily work.

* Fixed errors.

* Added legacy support. Added button for legacy.

* Added storybook.

* Removed revealImage from canvas.

* setState while rendering error fixed.

* tsconfig.json added.

* jest.config.js added.

* Demo doc added.

* Types fixed.

* added limits.

* Removed not used imports.

* i18n namespaces fixed.

* Fixed test suite error.

* Some errors fixed.

* Fixed eslint error.

* Removed more unused translations.

* Moved UI and elements, related to expressionRevealImage from canvas.

* Fixed unused translations errors.

* Moved type of element to types.

* Fixed types and added service for representing elements, ui and supported renderers to canvas.

* Added expression registration to canvas.

* Fixed

* Fixed mutiple call of the function.

* Removed support of a legacy lib for revealImage chart.

* Removed legacy presentation_utils plugin import.

* Doc error fixed.

* Removed useless translations and tried to fix error.

* One more fix.

* Small imports fix.

* Fixed translations.

* Made fixes based on nits.

* Removed useless params.

* fix.

* Fixed errors, related to jest and __mocks__.

* Removed useless type definition.

* Replaced RendererHandlers with IInterpreterRendererHandlers.

* fixed supported_shareable.

* Moved elements back to canvas.

* Moved views to canvas, removed expression service and imported renderer to canvas.

* Fixed translations.

* Types fix.

* Moved libs to presentation utils.

* Fixed one mistake.

* removed dataurl lib.

* Fixed jest files.

* elasticLogo removed.

* Removed elastic_outline.

* removed httpurl.

* Removed missing_asset.

* removed url.

* replaced mostly all tests.

* Fixed types.

* Fixed types and removed function_wrapper.ts

* Fixed types of test helpers.

* Changed limits of presentationUtil plugin.

* Fixed imports.

* One more fix.

* Fixed huge size of bundle.

* Reduced allow limit for presentationUtil

* Updated limits for presentationUtil.

* Fixed public API.

* fixed type errors.

* Moved css to component.

* Fixed spaces at element.

* Changed order of requiredPlugins.

* Updated limits.

* Removed unused plugin.

* Added rule for allowing import from __stories__ directory.

* removed useless comment.

* Changed readme.md

* Fixed docs error.

* A possible of smoke test.

* onResize changed to useResizeObserver.

* Remove useless events and `useEffect` block.

* Changed from passing handlers to separate functions.

* `function` moved to `server`.

* Fixed eslint error.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-01 13:30:00 +03:00
Tiago Costa
5f35d23416
chore(NA): moving @kbn/es-archiver into bazel (#103770) 2021-06-29 23:33:02 -04:00
Clint Andrew Hall
b7ad0c9004
[storybook] Ignore TS-related HMR warnings (#103605)
* [storybook] Ignore TS-related HMR warnings

* Fix casing

* Remove warnings filter

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-29 22:34:50 -04:00
Jonathan Budzenski
bed5b6d8f2
[packages] Migrate @kbn/test to Bazel (#103122)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-29 21:16:00 -04:00
Tiago Costa
682d969190
chore(NA): remove unused transient dep declaration from @kbn/ui-shared-deps build file (#103666) 2021-06-29 21:22:45 +01:00
Tiago Costa
75fa47cdcf
chore(NA): moving @kbn/test-subj-selector into bazel (#103562)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-29 14:59:38 +01:00
Spencer
407b96e021
[eslint/module-migration] add support for re-export defs and test rule (#102840)
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-28 14:28:10 -07:00
Dario Gieselaar
b51af01adc
[APM] Support records in strict_keys_rt (#103391)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-28 20:03:30 +02:00
Spencer
99d3f8b768
[kbn/optimizer] fix optimizerCache creation (#103190)
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-28 13:10:36 -04:00
Luke Elmers
d2690d8ac8
[migrations v2] Integration test for multi-node cluster. (#100957) 2021-06-28 12:49:38 -04:00
Tiago Costa
22d5c90855
chore(NA): moving @kbn/spec-to-console into bazel (#103470)
* chore(NA): moving @kbn/spec-to-console into bazel

* chore(NA): fix licenses
2021-06-28 15:58:41 +01:00
Spencer
23c8d18198
[ui-shared-deps] reuse react-beautiful-dnd from eui (#102834)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-06-24 13:59:49 -04:00
Anton Dosov
be1c5bbd72
Don't import react-intl directly to reduce bundle sizes (#102497) 2021-06-24 16:52:55 +02:00
Peter Pisljar
9a1f5a4a7a
switching to peggy (#103169) 2021-06-24 12:23:41 +02:00
Tiago Costa
17adfacb1b
chore(NA): moving @kbn/cli-dev-mode into bazel (#103067)
* chore(NA): moving @kbn/cli-dev-mode into bazel

* chore(NA): merge and solve conflicts with master
2021-06-23 23:50:49 -04:00
Tiago Costa
59423927cb
chore(NA): moving @kbn/plugin-helpers into bazel (#103181)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-23 23:49:04 -04:00
Wylie Conlon
4d514c6db6
[Lens] Escape field names in formula (#102588)
* [Lens] Escape field names in formula

* Fix handling of partially typed fields with invalid chars

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-23 14:20:50 -04:00
Josh Dover
524401973f
Add timeouts and setup enforcement for custom plugins statuses (#77965) 2021-06-23 13:58:10 -04:00
David Sánchez
eb9726987c
[Security Solution][Endpoint] Hide endpoint event filters list in detections tab (#102644)
* Add event filters filter on exception list to hide it in UI

* Fixes unit test and added more tests for showEventFilters

* fixes test adding showEventFilters test cases

* Pass params as js object instead of individual variables

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-23 16:04:23 +02:00
Tiago Costa
e1ec8b05b6
chore(NA): moving @kbn/optimizer into bazel (#102965)
* chore(NA): moving @kbn/optimizer into bazel

* chore(NA): fix source import from kbn optimizer

* chore(NA): update snapshots
2021-06-23 11:11:13 +01:00
Xavier Mouligneau
4fa3dc46cb
[RAC] T-Grid is moving to a new home (#100265)
* wip

* First pass at standalone and embedded redux stores and usage

* wip

* First pass at standalone and embedded redux stores and usage

* wip

* clean up

* wip

* refact(NA): remove extra pkg_npm target and add specific target folders on @kbn/i18n

* cleanup

* - fixes type errors in tests

* WIP remove use_manage_timeline

* wip add query + selector

* finishing integrating timeline manage context from redux

* integrating t-grid in security solution

* fix RowRender type

* WIP begin to move components from package to plugin

* integration of t-grid inside of security solution

* wip to make redux work

* little trick to make  it render

* - fixes a few type errors

* better integration betwen tgrid and security solutions

* bringing back tsconfig on timeline

* wip integration t-grid in observability

* fix types

* fix type in security solutions

* add type to import + trie dto get the bundle size as small as possible

* fix type in integration test

* fix type in integration test

* - fix tests

* clean up to use technical fields

* - fixes unit tests

* - mocks the `useDateFormat` function of the `useKibana` service to fix unit tests

* fix t-grid settings vs create timeline + fix inspect button

* fix last suites test

* Update unit tests, snapshots and lint

* Fix bad merge

* fix plugin export

* Fix some failing tests

* fix unit tets in timelines plugins

* fix latest test

* fix i18n

* free obs from t-grid

* Fix timeline functional plugin types

* fix store provider

* Update failing defaultHeader test

* Fix i18n usage in security solution

* Fix remaining i18n errors in timelines plugin

* Dedupe common shared types

* move drag and drop utils in package to avoid duplication

* More shared type cleanup

* add feature flag

* review I

* fix merge  with master

* fix i18n translation

* More type deduping

* Use @kbn/common-utils, fix remaining types

* fix types

* fix tests

* missing type

* fix cypress tests

Co-authored-by: Kevin Qualters <kevin.qualters@elastic.co>
Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
Co-authored-by: Andrew Goldstein <andrew.goldstein@elastic.co>
2021-06-22 18:56:33 -04:00
Tiago Costa
3da2ac8927
chore(NA): moving @kbn/ui-framework into bazel (#102908) 2021-06-22 13:11:24 -04:00
Jean-Louis Leysens
6cc3b84d6f
[Fleet] Add assets tab (#102517)
* very wip

* added new assets screen
* added routes to new assets view on the package details view

* Finished styling the assets page layout, need to work on adding
links

* rather use EuiHorizontalRule

* only show the assets tab if installed

* Added hacky version of linking to assets.

* added comment about deprecation of current linking functionality

* added an initial version of the success toast with a link to the agent flyout

* First iteration of end-to-end UX working. Need to add a lot of tests!

* fixed navigation bug and added a comment

* added a lot more padding to bottom of form

* restructured code for clarity, updated deprecation comments and moved relevant code closer together

* added a longer form comment about the origin policyId

* added logic for handling load error

* refactor assets accordions out of assets page component

* slightly larger text in badge

* added some basic jest test for view data step in enrollment flyout

* adjusted sizing of numbers in badges again, EuiText does not know about size="l"

* updated size limits for fleet

* updated styling and layout of assets accordion based on original
designs

* remove unused EuiTitle

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-22 17:10:37 +02:00
Jonathan Budzenski
11e68fda87
[packages] Move @kbn/interpreter to Bazel (#101089)
Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-22 09:59:20 -05:00
Dominique Clarke
34490a355e
[Uptime] [Synthetics Integration] transition to monaco code editor (#102642)
* update synthetics integration code editor

* add basic support for xml and javascript

* fix types

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-22 10:14:56 -04:00
Spencer
3084de6782
[kbn/test/es] remove unnecessary es user management logic (#102584)
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-21 18:36:43 -04:00
Davis Plumlee
c52f5edfcc
[Security Solution][Exceptions] Fixes empty exceptions filter bug (#102583) 2021-06-21 18:34:11 -04:00
Tiago Costa
5ac9a38102
chore(NA): remove webpack build changes for kbn/ui-shared-deps (#102780) 2021-06-21 20:31:37 +01:00