Commit graph

618 commits

Author SHA1 Message Date
Alexey Antonov
e2c6a039f6
lens should register expression functions in setup contract (#110639)
* lens should register expression functions in setup contract

Closes: #106510

* fix CI

* build optimization

* build optimizations - step 3

* fix CI

* try to optimize bundle

* Update x-pack/plugins/lens/common/expressions/time_scale/types.ts

Co-authored-by: Marta Bondyra <marta.bondyra@gmail.com>

* Update types.ts

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Marta Bondyra <marta.bondyra@gmail.com>
2021-09-07 10:32:30 +03:00
Marco Liberati
1a88d34ea2
[Lens] Reverse colors should not reverse palette picker previews (#110455)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-09-06 14:27:53 +02:00
Michael Dokolin
df43d253c8
[Expressions] Align renderMode with the embeddable viewMode (#110199)
* Add preview view mode to the embeddable
* Rename display render mode to view
* Extract no interactivity render mode to a separate flag
2021-09-03 19:10:29 +02:00
Marta Bondyra
d4c03eb9b4
[Lens] Switch to SavedObjectClient.resolve (#110059)
* Step 2: Update client code to use resolve() method instead of get()

Following sharing Saved Objects developer guide: Step 2
This step demonstrates the changes to update client code to use the new
SavedObjectsClient `resolve()` method instead of `get()`.

* Step 3 Lens
2021-09-03 16:44:12 +02:00
Marco Liberati
21b4752dba
[Lens] Fix transition to custom palette inconsistency when in number mode (#110852)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-09-03 15:57:57 +02:00
Spencer
fecdba7eba
[eslint] add rule to prevent export* in plugin index files (#109357)
* [eslint] add rule to prevent export* in plugin index files

* deduplicate export names for types/instances with the same name

* attempt to auto-fix duplicate exports too

* capture exported enums too

* enforce no_export_all for core too

* disable rule by default, allow opting-in for help fixing

* update tests

* reduce yarn.lock duplication

* add rule but no fixes

* disable all existing violations

* update api docs with new line numbers

* revert unnecessary changes to yarn.lock which only had drawbacks

* remove unnecessary eslint-disable

* rework codegen to split type exports and use babel to generate valid code

* check for "export types" deeply

* improve test by using fixtures

* add comments to some helper functions

* disable fix for namespace exports including types

* label all eslint-disable comments with related team-specific issue

* ensure that child exports of `export type` are always tracked as types

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-09-01 18:05:45 -07:00
Tim Roes
c510288c05
Split KibanaApp into VisEditors and DataDiscovery (#110588)
* Split KibanaApp into VisEditors and DataDiscovery

* Add discover functional tests to codeowners

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-31 15:57:23 +02:00
Marco Liberati
3b81205a23
[Lens] Show validation feedback on top values out of bounds number of values (#110222)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-31 15:23:18 +02:00
Marta Bondyra
03469515cf
[Lens] Fix filters reappearing in the saved object when saving (#110460)
* bugs fixed

* test for loading

* fix workspace panel

* Update x-pack/plugins/lens/public/xy_visualization/visualization.tsx

* revert useEffect for external embeddables
2021-08-31 11:51:54 +02:00
Alexey Antonov
6d874caef5
[Lens] should register "suffix" field formatter in setup lifecycle (#110218)
Closes: #106838

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-30 15:17:09 +03:00
Diana Derevyankina
b74c79ad32
[Lens] Remove deprecated IFieldType (#109825)
* [Lens] Remove deprecated `IFieldType`

* Fix types for terms.test

* Replace IndexPatternField with FieldSpec, revert terms.test and update other tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-30 13:39:17 +03:00
Alexey Antonov
3cc7da8435
[Lens] Inspect flyout should be available in editor mode. (#109656)
* [Lens] Inspect flyout should be available in editor mode.

* fix typo

* add test

* add functional tests for inspector

* toMatchInlineSnapshot -> toMatchSnapshot

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-26 10:18:09 -04:00
Liza Katz
268a279930
[Data][Es Query] Use ES types in Filters (#108378)
* es-query types

* jest and lint

* cc

* options

* type

* types for kuery FUNCTIONS

* doc

* types for filters

* sec fixes

* filtersss

* typey type

* typey type

* comparator options

* test typescript

* test

* fixes

* test types

* test

* cr

* cleanup a bit more

* Jest fix + types

* Remove geo bounding box and geo polygon filters

* delete geo filters

* geo

* geo

* Fix tests \_0_/

* doc

* types and fixes

* jests

* ts

* Remove geo bounding box and geo polygon filters

* delete geo filters

* delete geo filters

* geo

* remove geo docs

* ts

* plg ts

* types

* cast

* Update types.ts

* Update create_threat_signal.ts

* Update packages/kbn-es-query/src/es_query/migrate_filter.ts

Co-authored-by: Lukas Olson <olson.lukas@gmail.com>

* Code review

* revert change

* docs

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Lukas Olson <olson.lukas@gmail.com>
2021-08-24 11:28:22 +02:00
Marco Vettorello
958a3ba28a
fix(heatmap): remove duplicate legend items (#109338) 2021-08-20 17:09:22 +02:00
Tiago Costa
9c24e8f70f
chore(NA): moving @kbn/interpreter to babel transpiler (#108512)
* chore(NA): moving @kbn/interpreter to babel transpiler

* chore(NA): fix imports

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-20 11:50:40 +01:00
renovate[bot]
f21115f821
Update dependency @elastic/charts to v34 (master) (#108766)
* Update dependency @elastic/charts to v34
* tentative fix for heatmap legend items, to be fixed in patch before `7.15`

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com>
Co-authored-by: nickofthyme <nick.ryan.partridge@gmail.com>
2021-08-17 21:05:23 -05:00
Patryk Kopyciński
754b79f08a
[Cases] Add Lens markdown plugin (#96703) 2021-08-17 15:49:44 -07:00
Stratoula Kalafateli
8939ee6c24
[Lens] Supports long legend values (#107894)
* [Lens] Supports multilines legend

* Add a truncate legends switch

* Add more unit tests

* Add tooltip condition

* Adress PR comments

* Apply PR comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-17 16:10:18 +03:00
Alexey Antonov
87ac80ec90
[Lens] Make lens_time_scale function to pick timezone from the context (#108366)
Part of: #97134

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-17 15:53:25 +03:00
Alexey Antonov
8d5c3c835c
[Lens] Fix when clicking "Save and Return" on a Lens visualization the visualization's description gets erased (#108669)
Closes: #107841
2021-08-17 09:38:11 +03:00
Marta Bondyra
e33daccca3
[Lens] Disable the global timepicker for index pattern without primary timefield and visualizations without timefield (#108052) 2021-08-13 18:24:00 +02:00
Devon Thomson
33f3933118
[Dashboard] [Embeddable] Add Ability to Defer Embeddable Loaded State (#107227)
Added defer embeddable loading flag to embeddable for embeddables which aren't finished loading after their constructor is finished
2021-08-12 17:43:57 -04:00
Marco Liberati
dc2a1e1cea
[Lens] Introduce new layer types (#107791) 2021-08-12 08:29:31 +02:00
Tim Sullivan
6563fad7be
[Reporting] implement content changes per feedback (#108068) 2021-08-11 13:13:40 -07:00
Alexey Antonov
82bec98cd7
[Lens] Register all expression functions to the server (#107836)
Part of:  #97134

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-11 13:59:49 +03:00
Alexey Antonov
ee10819ef0
[Lens] fix do not submit invalid query in filtered metric (#107542)
* [Lens] Do not submit invalid query in filtered metric

Closes: #95611

* fix CI

* fix PR comments

* fix PR comments

* fix PR comment

* move closePopover to useCallback

* add filter validation to utils/isColumnInvalid

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-11 10:56:44 +03:00
Spencer
c0395c9ef6
[build_ts_refs] improve caches, allow building a subset of projects (#107981)
* [build_ts_refs] improve caches, allow building a subset of projects

* cleanup project def script and update refs in type check script

* rename browser_bazel config to avoid kebab-case

* remove execInProjects() helper

* list references for tsconfig.types.json for api-extractor workload

* disable composite features of tsconfig.types.json for api-extractor

* set declaration: true to avoid weird debug error

* fix jest tests

Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-08-10 22:12:45 -07:00
Marta Bondyra
c5499c6592
[Lens] Redux selectors optimization (#107559) 2021-08-10 21:06:35 +02:00
Liza Katz
204efae5bf
[Data cleanup] unify serializable state (#107745)
* Use Serializable from package

* Rename to align with core

* fix

* more replacements

* docssss

* fix

* Move it to @kbn/utility-types and remove core export

* buildy build

* tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-10 13:03:48 +02:00
Marco Liberati
778a1160f5
[Lens][Accessibility] Take into account background color for non opaque colors (#107877)
* 🐛 Take into account also background color if opaque

*  Add tests for opaque colors
2021-08-10 10:48:03 +02:00
Alexey Antonov
6008b5ae55
[Lens] chore: remove dead code (#107882)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-10 10:19:40 +03:00
Mikhail Shustov
5480c4d0f4
[Execution context] Add nested context support (#107523)
* Add nested context support

* remove execution context service on the client side

ExecutionContextContaier is not compatible with SerializableState, so I had to fall back to passing context as POJO. With this change, using a service looks like overhead.

* update docs

* fix test

* address comments from Josh

* put export back

* update docs

* remove outdated export

* use input.title for unsaved vis

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-10 08:53:40 +02:00
Anton Dosov
af3a976e17
[FieldFormats] Break from data plugin (#107173) 2021-08-05 16:25:22 +02:00
Alexey Antonov
f62a0a1f76
[Lens] Synchronize cursor position for X-axis across all Lens visualizations in a dashboard (#106845)
* [Lens] Synchronize cursor position for X-axis across all Lens visualizations in a dashboard

Closes: #77530

* add mocks for active_cursor service

* fix jest tests

* fix jest tests

* apply PR comments

* fix cursor style

* update heatmap, jest

* add tests

* fix wrong import

* replace cursor for timelion

* update tsvb_dashboard baseline

* fix CI

* update baseline

* Update active_cursor_utils.ts

* add debounce

* remove cursor from heatmap and pie

* add tests for debounce

* return theme order back

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-04 22:20:03 +03:00
Marta Bondyra
bcb16c1b86
[Lens] moving store loading to middleware (#106872) 2021-08-03 18:37:15 +02:00
Stratoula Kalafateli
f27c94c118
[Lens] Updates UI terminology (#106983)
* [Lens] Update UI terminology

* Change the translation key

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-02 14:32:24 +03:00
Anton Dosov
1b315bb01d
[Lens] Fix suffix field format leaks to index pattern management (#107139) 2021-08-02 06:59:56 -04:00
Matthew Kime
a33039fc04
use IndexPattern instead of IIndexPattern (#107225)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-02 05:12:24 -05:00
Stratoula Kalafateli
2a9d17c317
[Lens] Formats correctly the falsy values on the x axis (#107134)
* [Lens] Formats correctly the falsy values on the x axis

* Address PR comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-30 16:22:20 +03:00
Marta Bondyra
6ef6574823
[Lens] make the datatable content selectable 2021-07-30 11:39:17 +02:00
Michael Marcialis
4317dcb43d
[Lens] Focus Fixes for v8 Theme (#106634)
* set correct focus ring for each theme

* fix field and dimension button span faux focus

* fix dimension button focus

* add mixin to remove euiFocusRing

* clean up the mess

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-30 09:27:58 +02:00
Marta Bondyra
6da99f33e8
mocking canvas (#107147) 2021-07-30 09:25:56 +02:00
Marco Liberati
d3e4dcf367
[Lens] Cleanup bar value labels configuration (#106231)
* 🐛 Rework value labels config

* 📷 Update snapshots
2021-07-29 10:22:23 +02:00
Michael Dokolin
b140cb5cb1
[Aggregations] Create expression functions for object types used in agg params (#103494) 2021-07-29 07:00:35 +02:00
Anton Dosov
deefe1ac83
[FieldFormats] fix register on start contract (#106828) 2021-07-28 14:05:17 +02:00
Stratoula Kalafateli
c656608d85
[Lens] Allows the users to change the axis orientation (#106369)
* [Lens] Allows the users to change the axis orientation

* Disable orientation if ticklabels are off

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-27 16:14:03 +03:00
Marco Liberati
3c6b85469b
[Lens] Move Lens functions to common (#105455)
* 🚚 First move batch to common

* 🚚 Second batch of move

* 🏷️ Import types only

* 🚚 Third batch

* 🚚 Fourth batch move

* 🚚 Another module moved

* 🚚 More function moved

* 🚚 Last bit of move

*  Reduce page load bundle size

* 🐛 Fix import issue

* 🐛 More import fix

*  Registered functions on the server

* 🐛 Expose datatable_column as well

*  Add server side expression test

* 🚚 Moved back render functions to public

*  Add a timezone arg to time_scale

* 🔥 Remove timezone arg

* 🔥 Remove server side code for now

* 👌 Integrated feedback

* 🚚 Move back datatable render function

* 🏷️ Fix imports

* 🏷️ Fix missing export

* 🚚 Move render functions back!

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-26 15:26:29 +02:00
Marta Bondyra
91aa2bb8ec
[Lens] Truncate field dropdown in the middle (#106285)
* [Lens] Truncate field dropdown in the middle

* implementation

* aligning width of the elements, calculating width in canvas, serving edgecases like selected element, tests update

* revert selectedField as it doesn't solve all cases

* code review

* cr

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-26 11:32:00 +02:00
Wylie Conlon
9616a55f81
[Lens] Add render complete tags to empty states (#106163)
* [Lens] Add render complete tags to empty states

* Fix typo

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-22 10:50:44 -04:00
Marco Liberati
33bf0fe633
🐛 Improve network error message (#106246) 2021-07-21 19:17:12 +02:00