Commit graph

1328 commits

Author SHA1 Message Date
Tyler Smalley 9b62100428
Removes Grunt abstraction from CI tasks (#85210)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2020-12-09 08:51:32 -08:00
Josh Dover e116fce08e
Add server.publicBaseUrl config (#85075) 2020-12-08 17:02:39 -07:00
Poff Poffenberger 8467b89202
[Time to Visualize] Add visualizations to dashboard from save modal (#83140)
Co-authored-by: Ryan Keairns <contactryank@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
2020-12-08 15:39:24 -06:00
Stacey Gammon de15f164d9
Convert a README to mdx to get it slurped up by the new docs system (#84834)
* Convert readme to mdx so it can get slurped into the new docs system

* Adjust plugin list doc generation so it accounts for mdx readmes

* fix eslint of discover_plugin file

* Fix link to readme in plugin list

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-08 15:12:07 -05:00
Alison Goryachev 7b362458e7
Enhancements to painless autocomplete in monaco (#85055) 2020-12-08 12:16:06 -05:00
Alison Goryachev f8edc51ece
Implement error reporting in monaco for painless language (#84695) 2020-12-08 10:07:07 -05:00
Spencer a7c5b49343
[esArchiver] support kibana and es ssl from cli (#85073)
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-07 13:20:15 -07:00
Alison Goryachev 079a7e82ba
Integrate painless autocomplete in runtime fields editor (#84943) 2020-12-07 12:55:53 -05:00
Spencer fd1328f6f8
[cli/dev] remove cluster module, modernize, test (#84726)
Co-authored-by: Alejandro Fernández Haro <afharo@gmail.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-04 14:28:06 -07:00
Tiago Costa 6be3cf4f9f
chore(NA): check git version on pre-commit hook install (#84811)
* chore(NA): checks installed git version when installing pre-commit hook

* chore(NA): throw an error instead of log a warning

* chore(NA): use createFailError instead

* fix(NA): apply feedback from pr review for isCorrectGitVersionInstalled

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-04 19:10:33 +00:00
Ahmad Bamieh aa9a353205
[Telemetry] Introduce UI Counters (#84224)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-04 17:47:04 +02:00
Tyler Smalley 74ef540e42
[CI] Enables APM collection (#81731)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2020-12-03 09:25:40 -08:00
Thomas Watson 3ae73653ff
Improve logging pipeline in @kbn/legacy-logging (#84629) 2020-12-03 09:34:45 +01:00
Thomas Watson 770a00530d
Catch @hapi/podium errors (#84575) 2020-12-03 09:33:48 +01:00
Mikhail Shustov 78123a109d
Rename server.xsrf.whitelist to server.xsrf.allowlist (#84791)
* rename xsrd.whitelist to xsrf.allowlist

* update docs

* update telemetry schema

* update kbn-config tests
2020-12-03 07:19:36 +01:00
Thomas Watson fb48e903d5
Upgrade Node.js to version 14 (#83425) 2020-12-02 23:40:06 +01:00
Tyler Smalley b593781009
Jest multi-project configuration (#77894)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2020-12-02 11:42:23 -08:00
Mikhail Shustov 68decb8352
declare kbn/monaco dependency on kbn/i18n explicitly (#84660) 2020-12-01 10:24:54 -07:00
Thomas Watson 920e4fa280
Update code-comments describing babel plugins (#84622) 2020-12-01 15:55:54 +01:00
Mikhail Shustov 1ec2f1d078
Cleanup tsconfig files (#84396)
* remove unused "paths" from tsconfig

* remove unused test utils, import get-url from kbn/test

* dont pollute globals with jest when importing getUrl

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-30 19:12:00 +01:00
Alison Goryachev 7691184184
Support for painless language autocomplete within monaco (#80577) 2020-11-30 10:14:33 -05:00
Pierre Gayvallet b99abe301a
increase stdout max listeners for legacy logging (#84497)
* increase stdout max listeners for legacy logging

* add missing packages to CODEOWNERS
2020-11-30 15:32:59 +01:00
Spencer ea8ea4e4e0
[dev/cli] detect worker type using env, not cluster module (#83977)
* [dev/cli] detect worker type using env, not cluster module

* remove unused property

* assume that if process.send is undefined we are not a child

* update comment

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-25 08:03:47 -07:00
Thomas Watson 115916956d
Use correct version of Podium (#84270) 2020-11-24 22:15:35 +01:00
Tyler Smalley e8a4b7e7dd
[@kbn/utils] Clean target before build (#84253)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2020-11-24 11:33:34 -08:00
Dmitry 2634009a5b
[code coverage] collect for oss integration tests (#83907)
* [code coverage] collect for oss integration tests

* do not run snapshot test modified with coverage

* skip failures

* remove debug msg

* update file names

* Update packages/kbn-optimizer/src/integration_tests/basic_optimization.test.ts

Co-authored-by: Spencer <email@spalger.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Spencer <email@spalger.com>
2020-11-24 20:32:35 +01:00
Mikhail Shustov 5ec6fe315f
[DX] Bump TS version to v4.1 (#83397)
* bump version to 4.1.1-rc

* fix code to run kbn bootstrap

* fix errors

* DO NOT MERGE. mute errors and ping teams to fix them

* Address EuiSelectableProps configuration in discover sidebar

* use explicit type for EuiSelectable

* update to ts v4.1.2

* fix ts error in EuiSelectable

* update docs

* update prettier with ts version support

* Revert "update prettier with ts version support"

This reverts commit 3de48db3ec.

* address another new problem

Co-authored-by: Chandler Prall <chandler.prall@gmail.com>
2020-11-24 16:04:33 +01:00
Mikhail Shustov b3d97764a0
Move streams to kbn/utils (#84033)
* move streams to kbn/std

* import streams from kbn/std

* fix styles

* remove unused shareWeakReplay

* move from kbn/std to kbn/utils

* import from subfolder since test mocks FS module and not compatible with kbn/utils

* remove new line at the end of json file
2020-11-24 15:19:18 +01:00
Spencer 8ea529d559
[src/cli/dev] remove broken and unused --open flag (#83966)
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-23 11:13:37 -07:00
Tiago Costa b2e01c50c9
chore(NA): remove yarn lock from kbn legacy logging (#84096)
* Revert "[Search] Search batching using bfetch (#83418)"

This reverts commit 5708c5d004.

* chore(NA): remove yarn.lock from kbn-legacy-logging
2020-11-23 17:13:40 +00:00
Mikhail Shustov 95861a0fb0
[DX] Prettier v2.2 (#83899)
* update prettier with ts version support

* mute type-error

* run prettier on codebase

* fix examples

* fix errors after master merged
2020-11-23 13:17:05 +01:00
Pierre Gayvallet e176def756
create kbn-legacy-logging package (#77678)
* create kbn-legacy-logging package and start to move things

* fix rotator tests

* fix logging system test mocks

* move logging format to the package

* move logging setup to package

* adapt legacy logging server

* remove usage of legacy config in the legacy logging server

* move legacy logging server to package

* remove `??` syntax from package

* update generated doc

* fix a few things due to month old merge

* remove typings from project

* move reconfigureLogging to package

* add basic README file

* update generated doc

* remove old typings

* add typing for legacy logging events

* remove `??` from packages

* fix / improve event types usages

* remove suffix from tsconfig
2020-11-22 20:46:38 +01:00
Dmitry 312438ff9b
[code coverage] Update jest config to collect more data (#83804)
* collect code coverage for more files in src/

* update config

* update config according review

* move collectCoverageFrom to preset

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-20 22:30:13 +01:00
Brian Seeders 314e40fba3
[CI] Initial TeamCity implementation (#81043) 2020-11-20 14:32:53 -05:00
spalger fcb83dad86 [kbn/optimizer/node] tweak cache dir to invalidate exiting caches 2020-11-20 09:56:42 -07:00
Spencer 0db0d95142
[kbn/optimizer/node] properly separate lmdb databases, log better (#83849)
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-20 09:51:38 -07:00
Mikhail Shustov ec983ef610
do not export types from 3rd party modules as 'type' (#83803)
to avoid inlining. see 9 https://www.techatbloomberg.com/blog/10-insights-adopting-typescript-at-scale/
2020-11-20 15:27:37 +01:00
Thomas Watson 131a1ba91a
Bump jest (and related packages) to v26.6.3 (#83724)
Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co>
2020-11-20 07:08:04 +01:00
Spencer 45d3861219
Revert lmdb-store upgrade (#83830)
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-19 13:10:58 -07:00
Dario Gieselaar 5d05eeaab9
Improve snapshot error messages (#83785) 2020-11-19 15:58:15 +01:00
Nicolas Chaulet 1b6cfe819d
[Fleet] Rename ingestManager plugin ID fleet (#83200) 2020-11-19 08:43:14 -05:00
Dario Gieselaar 3a8ea2993f
Make expectSnapshot available in all functional test runs (#82932)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-11-19 08:38:51 +01:00
Robert Oskamp f2ad337fef
Increase bulk request timeout during esArchiver load (#83657)
This PR fixes some timeouts during esArchive load by increasing the request timeout.
2020-11-19 07:05:10 +01:00
Tiago Costa f2d97a9fe2
chore(NA): update lmdb store to v0.8.15 (#83726)
* chore(NA): upgrade lmdb-store to v0.8.15

* chore(NA): remove unused ts-error statements
2020-11-19 00:08:50 +00:00
Mikhail Shustov 4917df30b9
Update typescript eslint to v4.8 (#83520)
* update deps

* update rules

use type-aware @typescript-eslint/no-shadow instead of no-shadow. do not use no-undef, rely on TypeScript instead

* fix or mute all lint errors

* react-hooks eslint plugin fails on ? syntax

* fix wrong typings in viz

* remove React as a global type

* fix eslint errors

* update version to 4.8.1

* fix a new error
2020-11-18 18:23:08 +01:00
Sébastien Loix e3c2dccf00
[Runtime fields] Editor phase 1 (#81472)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-11-18 09:10:00 +01:00
Spencer 859ba3efa3
[kbn/plugin-helpers/build] copy the public assets of a plugin (#83458)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-11-16 15:07:57 -07:00
Spencer 422dd2b6d5
upgrade to lmdb-store 0.8 (#83479)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-11-16 15:04:34 -07:00
Alejandro Fernández Haro 90729c6e19
Remove dependency of tests on strict SyntaxKind values (#83440) 2020-11-16 17:37:49 +00:00
John Schulz 380fa5b3f6
[bundle optimization] Update to semver 7.x to get tree-shaking (#83020)
## What's changed in this PR
### Update to latest available `semver`: `7.3.2`
 * `semver` 5.x pulls in the entire library in one large file (~38k uncompressed / ~9k gz), when we might only use 1-2K.
 * `semver` 7.0+ supports tree-shaking: https://github.com/npm/node-semver/blob/master/CHANGELOG.md#700

### Update paths to only import individual function(s) used instead of the entire library
  * Getting the smaller bundle requires a different import style [as shown in the docs](https://github.com/npm/node-semver#usage)
  * Only changed code in `public` & `common` folders; not `server`. We could also update `server` as well for consistency, but I skipped because the new import style is more verbose and the filesize didn't seem as important on the server

### Results
The build stats show a 10K+ improvement for initial page bundles https://github.com/elastic/kibana/pull/83020#issuecomment-724724432

| id | [before](c6afc47f32) | [after](213bb52a8c) | diff |
| --- | --- | --- | --- |
| `ingestManager` | 386.2KB | 373.9KB | -12.3KB |
| `telemetry` | 63.5KB | 50.1KB | -13.5KB |
| `upgradeAssistant` | 74.5KB | 60.5KB | -14.0KB |
| total |  |  | -39.7KB |

### The import paths look odd. Are they required?
I agree and, no, they're not strictly required. If you'd like me to revert to the prior style just drop a comment and I'll undo them.

The caveat is that the current style (in `master` & this PR) pulls in the entire `semver` library. In 7.x that added ~15K to the initial size. Some more details in the comments: https://github.com/elastic/kibana/pull/83020#issuecomment-724859130

### Possible issues
Moving 2 major versions. We're currently on 5.7 and the latest available is 7.3. 
  * changelog says 5.x (our current) to 6.0 should be safe: https://github.com/npm/node-semver/blob/master/CHANGELOG.md#60
  * There 6.x & 7.x changes all appear to be new features or bugfixes around the `includePrerelease` flag added in 5.6, but I'm not sure if those "fixes" will break existing code
    * https://github.com/npm/node-semver/blob/master/CHANGELOG.md#613
    * https://github.com/npm/node-semver/blob/master/CHANGELOG.md#722

### Stats / screenshots
generated with `node scripts/build_kibana_platform_plugins.js --profile --focus=ingestManager`
<details><summary><b>Ingest Manager in `master`</b>: imports entire `semver` lib, totals 40k+, only 1 large file (orange arc below)</summary>

<img width="972" alt="Screen Shot 2020-11-09 at 6 50 23 PM" src="https://user-images.githubusercontent.com/57655/98666188-a50ac380-231a-11eb-9b8a-6ca784752714.png">
</details>

<details><summary><b>Ingest Manager in PR after upgrade to 7</b>: still imports entire lib. file size *increased* to ~60k, but now individual files are imported (orange arcs below)</summary>
<img width="825" alt="Screen Shot 2020-11-09 at 5 46 30 PM" src="https://user-images.githubusercontent.com/57655/98666355-e602d800-231a-11eb-803f-bc04beb4eaf1.png">
<img width="963" alt="Screen Shot 2020-11-09 at 5 47 06 PM" src="https://user-images.githubusercontent.com/57655/98666357-e69b6e80-231a-11eb-92d3-c66904f92c30.png">
</details>

<details><summary><b>Ingest Manager in PR after changing `import`s:</b> total imported size down to ~20k. Can see individual imported files</summary>
<img width="926" alt="Screen Shot 2020-11-10 at 6 10 23 AM" src="https://user-images.githubusercontent.com/57655/98667058-e64fa300-231b-11eb-9690-5e36ed6475e0.png">
<img width="895" alt="Screen Shot 2020-11-10 at 6 10 53 AM" src="https://user-images.githubusercontent.com/57655/98667059-e780d000-231b-11eb-8abf-98d8bdbcf061.png">
</details>

### Checklist

- [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2020-11-14 07:32:02 -05:00
Tyler Smalley aba2068291
Consolidates Jest configuration files and scripts (#82671)
Jest tests are currently organized into main configuration files (src/dev/jest/config.js and x-pack/dev-tools/jest/create_jest_config.js). Both of these are similar, but very slightly due to  previously being in separate repositories. This change consolidates the scripts referenced in those configs and moves them to the `@kbn/test` project.

OSS contained an alias for `test_utils`. Those aliases have been removed in favor of importing these utilities from `@kbn/test/jest`

Blocker to #72569

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2020-11-12 16:19:56 -08:00
Thomas Watson 4c49d5d1be
Upgrade Node.js to version 12 (#61587) 2020-11-12 22:00:57 +01:00
Gidi Meir Morris ab72206da3
[Alerting] Moves the Index & Geo Threshold UIs into the Stack Alerts Public Plugin (#82951)
This PR includes the following refactors:
1. Moves the Index Pattern Api from _Stack Alerts_ to the _Server_ plugin of _Trigger Actions UI_. This fixes a potential bug where a user could disable the _Stack Alerts_ plugin and inadvertently break the UI of the _ES Index _ action type.
2. Extracts the UI components for _Index Threshold_ and _Geo Threshold_ from the _Trigger Actions UI_ plugin and moves them into _Stack Alerts_.
2020-11-12 16:39:40 +00:00
Spencer 5e06f43adf
[kbnClient] retry updating config if necessary (#83205)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-11-11 14:51:10 -07:00
Tiago Costa 8e4643dcdd
chore(NA): update kbn plugin helpers readme file (#83083)
* chore(NA): update kbn plugin helpers readme file

* chore(NA): update packages/kbn-plugin-helpers/README.md

Co-authored-by: Spencer <email@spalger.com>

* chore(NA): update packages/kbn-plugin-helpers/README.md

Co-authored-by: Spencer <email@spalger.com>

Co-authored-by: Spencer <email@spalger.com>
2020-11-10 20:27:48 +00:00
Larry Gregory 6b60599cba
Remove yeoman & yo (#82825) 2020-11-06 11:49:53 -05:00
Stratoula Kalafateli 5710f6763b
[Visualize] New visualization wizard (#79627)
* [Visualizations] New vis wizard

* Update functional tests

* Create oss plugins for maps and lens and unregister alias function

* Add new plugins to .i18nrc.json

* Add readme and codeowners to the new plugins

* update docs

* fix tests

* fix types

* fixes

* Update development docs

* fix oss functional tests

* Fix jest and x-pack functional tests

* Fix functional test

* changes on the layout

* Cleanup and responsiveness

* cleanup unecessary code

* add common folder to the new OSS plugins

* remove unecessary translations

* Update limits.yml file

* Fix basic label

* Add experimental badge on controls vis

* Nice improvements

* fixes

* Improving styles

* Making modal go full height on smaller screens

* Fixing sass lint warning

* fix lint error

* fix internationalization error

* PR fixes

* PR changes

* Use useCallback where possible

* Remove translations that need to be translated again

* Lazy Load wizard modal

* Remove legacyMapVisualizationWarning

* Import the OSS plugins constants from the plugins

* Export constant from lensOss

* Change the new oss plugins from OSS to Oss

* Add a new line to the kibana.json files of the new plugins

* New nit fix

* Fix spaces

* Change the texts for the first step of the modal

* Fix test

* Fixes some of the PR comments

* Add onClick funtionality to the entire aggregation based card

* Cards description changes, introduce a copyFromRoot method to solve the problem of when disabling the x-pack plugic, to also disable the oss

* Create new FTR for testing the functionality of the wizard when both maps and lens apps are disabled

* fix eslint error

* Change groupTitles and descriptions

* Change input vis description

* Remove the copyFromRoot from the signature of the ConfigDeprecationFactory and export it from the main entrypoint

* Make the disabled cards badge clickable

* Changes from code review

* Fix functional tests failures

* Rename groupTitle to titleInWizard to be more specific

* Change vega vis note

* minor design changes

* fix problem with plugins list docs

* Retrieve maps and lens landing page from docs service and add tracking url param

* Fix funtional test for the new dashboard flow

* Fix logic in alias registry for removing the discardOnRegister alias

* no need to remove the alias entry from the discardOnRegister array

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: miukimiu <elizabet.oliveira@elastic.co>
2020-11-06 18:03:44 +02:00
spalger 61a54078d8 remove entire suite as partial skips aren't doing the trick
(cherry picked from commit 4ce3e1ce03)
2020-11-04 09:09:12 -07:00
Spencer 0fec6cbc00
[ci] run server integration tests (#81698)
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-03 15:50:01 -07:00
Clint Andrew Hall c974f56e1c
Team:Presentation Code Owners and automation changes (#82343)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-03 10:32:47 -06:00
Alexey Antonov ffc4ba2514
[Step 2] Use Observables on server search API (#80709)
* [Step 2] Use Observables on server search API

* apply some suggestions

* use concatMap instead of expand

* update docs

* cleanup

* fix PR comments

* remove AsyncOptions

* remove $config from eql_search_strategy

* remove $config from es_search_strategy

* remove DoSearchFnArgs, SearchMethod

* some work

* fix docs

* remove waitForCompletion param

* cleanup

* some work

* fix circular imports

* Update src/plugins/data/server/search/es_search/es_search_rxjs_utils.ts

Co-authored-by: Lukas Olson <olson.lukas@gmail.com>

* Update src/plugins/data/common/search/es_search/es_search_rxjs_utils.ts

Co-authored-by: Lukas Olson <olson.lukas@gmail.com>

* Update src/plugins/data/common/search/es_search/es_search_rxjs_utils.ts

Co-authored-by: Lukas Olson <olson.lukas@gmail.com>

* Update x-pack/plugins/data_enhanced/common/search/es_search/es_search_rxjs_utils.ts

Co-authored-by: Lukas Olson <olson.lukas@gmail.com>

* fix PR comments

* update docs

* apply suggestions

Co-authored-by: Lukas Olson <olson.lukas@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-03 12:43:32 +03:00
Pierre Gayvallet d4b2a5145a
SavedObjects tagging MVP (#79096)
* create xpack plugin skeleton, start to implement management section

* add tag creation modal

* first implementation of the tags table

* use InMemoryTable

* add edit modal and delete action

* update plugin list

* add tag list, fix types

* add capabilities check on client-side

* add tag combo box component

* add missing i18n keys

* fix privilege FTR tests

* add base structure for FTR tests

* fix feature ftr test

* use string literals for i18n

* create savedObjectsTaggingOss plugin, move API types to oss plugin, start to wire to SO management page.

* update plugin list

* fix types

* allow to use `_find` with multiple references

* add FTR test for _find API on references fields

* add _find integration tests

* update generated doc

* start to implement tag filtering on SO management section

* update generated docs

* wire tagging API to dashboard listing page

* fix i18n namespace

* fix type & tests

* update dashboard listing snapshots

* adapt FTR listingTable service to search for parsable queries

* wite tagging API to visualize listing

* update tagging plugin limits

* add server-side and client-side validation for tag create/edit

* rename title field to name

* fix types

* fix types bis

* add removeReferencesTo API to SOR/SOC

* update generated doc

* add server-side unit test for `savedObjectsTagging` plugin

* move tagging API types to its own file

* add savedObjectsTaggingOss mock

* add tags_cache tests

* add tests for client-side tag client

* extract uiApi to distinct files

* various API improvements

* add more tests

* add link between tag and so management sections + add connection counts

* add base functional test suite for tagging

* add more FTR tests

* improve feature control func test

* update codeowners

* update generated doc

* fix access to proxy modal

* adapt SO save modal to allow to add tag field

* add SO decorator registry and tag implementation

* add unit tests for SO tag decorator

* add functional tests for visualize integration

* add tag SO read permission for vis/dash feature

* add RBAC api integ tests

* add API integration tests

* add test for getTagConnectionsUrl

* add SOM test suite

* add dashboard integration suite

* remove test line

* add missing unit tests

* improve API types doc

* fix create modal save button label

* remove console.log

* improve doc

* self review

* add refresh interval for tag cache

* improve page object doc

* minor cleanup

* address review comments

* small layout fixes

* add initial focus

* use lazy accessor for tag request handler context

* adapt SOM export and export route to handle references

* remove icon from feature config due to master changes

* fix SO table tests

* update generated docs

* sort tags by name in filter dropdown and listing component

* wire SO tagging to dashboard save modal

* fix types

* - add 'create tag' action in tag selector
- add notifications on update/create/delete from management
- delete modal wording

* add description max length validation

* remove real-time validation

* fix i18n bundle id

* update expected size of savedObjectsTagging plugin

* use own useIfMounted

* update limit again, contract components cannot be lazy loaded atm.

* math is hard

* remove single usage of lodash for bundle size

* add async imports for create/edit modal

* add FTR test for 'create tag' action from tag selector

* allow 'create new' option to prepopulate name field

* extract savedObjectToTag

* add advancedSettings read user for security api_integ suite

* add audit login for security client wrapper

* use import type when possible

* wire SO tagging to lens visualization

* fix lens jest test

* Fix `create tag` option being selected when closing the selector dropdown

* add sorting to tag column from getTableColumnDef

* address some of restrry comments

* rename tag selector's setSelected option to onTagsSelected

* fix audit logging even type for saved_object_remove_references

* update plugin size limit to current size

* adapt maxlength validation wording

* remove selection column until we have batch action menu

* remove connections link when user lack read privilege to savedObjectManagement

* forbid registering multiple SO decorators with the same priority

* add so decorator test

* extract getTagFindReferences and create API mock

* update audit-logging ascidoc

* doc nit

* throw conflict error if update returns any failure

* use refresh=true as default

* wording nits

* export: rename `references` to `hasReference`

* update generated doc

* set description max length to 100

* do not initialize tag cache on anonymous pages

* split fetchObjectsToExport into two distinct functions

* change tag client `delete` call order

* tsdoc nits

* more nits

* add README for oss plugin

* add oss plugin start tests

* SavedObject.find: rename `references` to `hasReference`

* change section description label

* remove url prefix constants

* last nits and comments

* update generated doc
2020-11-03 10:33:18 +01:00
Tiago Costa 0eeaafa722
chore(NA): move into single pkg json (#80015)
* chore(NA): update gitignore to include first changes from moving into a single package.json

* chore(NA): update gitignore

* chore(NA): move all the dependencies into the single package.json and apply changes to bootstrap

* chore(NA): fix types problems after the single package json

* chore(NA): include code to find the dependencies used across the code

* chore(NA): introduce pure lockfile for install dependencies on build

* chore(NA): update clean task to not delete anything from xpack node_modules

* chore(NA): update gitignore to remove development temporary rules

* chore(NA): update notice file

* chore(NA): update jest snapshots

* chore(NA): fix whitelisted licenses to include a new specify form of an already included one

* chore(NA): remove check lockfile symlinks from child projects

* chore(NA): fix eslint and add missing declared deps on single pkg json

* chore(NA): correctly update notice

* chore(NA): fix failing jest test for storyshots.test.tsx

* chore(NA): fix cypress multi reporter path

* chore(NA): fix Project tests check

* chore(NA): fix problem with logic to detect used dependes on oss build

* chore(NA): include correct x-pack plugins dep discovery

* chore(NA): discover entries under dynamic requires on vis_type_timelion

* chore(NA): remove canvas

* test(NA): fix jest unit tests

* chore(NA): remove double react declaration from storyshot test file

* chore(NA): try removing isOSS check

* chore(NA): support for plugin development

* chore(NA): update logic to fix unit tests and typechecking

* chore(NA): support to run npm scripts in child kbn projects across all envs

* chore(NA): support github checks reporter on x-pack and remove cpy types as the package correctly provides them

* chore(NA): update cpy version

* chore(NA): include last kbn pm changes

* chore(NA): update style on build_production_projects.ts

* chore(NA): remove any cast fom telemetry opt in stats

* chore(NA): remove del and re-use rm -rf again

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-02 21:18:52 +00:00
Greg Thompson 6fdc7eb1fa
Upgrade EUI to v30.1.1 (#81499)
* eui to v30.0.0

* removed unused RecentLinks component

* update compressed -> display prop

* euiformrow compressed -> display

* euipopover remove withtitle

* euibuttongroup prop updates

* remove euibuttontoggle

* src snapshot updates

* tutorial euibuttongroup update

* x-pack snapshot updates

* euibuttongroup test updates

* TODO

* misc. js file updates

* remove euinavdrawer scss references

* translation removals

* more x-pack snapshot updates

* update data-test-subj lookup

* icons logoAMP -> logoObservability

* cypress selector updates

* update euibuttontoggle onchange, test interaction

* Fix auto-update toggle in Visualize

* some more change -> click test updates

* idtoselectedmap change

* Fix feature table button group

* Remove empty SASS file

* Fix feature table button group II

* Using `compressed` to also dictate dual range row

* Fix a few security labels

* An ML fix

* Apply suggestions from code review

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* remove unused translation

* update view_type_toggle snapshot

* more snapshot updates

* eui to 30.1.0

* undo temp ts-ignore

* more x-pack snapshot updates

* eui to 30.1.1

* update feature privilege text

* Update x-pack/plugins/security/public/management/roles/edit_role/privileges/kibana/feature_table/sub_feature_form.tsx

Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>

* reuse i18n token

* Adapt log entry action button to new `minWidth` prop

* clean up label

* Combine auto apply strings into one

* ternary fix

* cases status useCallback

Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
Co-authored-by: Felix Stürmer <stuermer@weltenwort.de>
2020-10-30 16:18:27 -06:00
igoristic c1294f0177
[Monitoring] Thread pool rejections alert (#79433)
* Thread pool rejections first draft

* Split search and write rejections to seperate alerts

* Code review feedback

* Optimized page loading and bundle size

* Increased monitoring bundle limit

* Removed server app import into the frontend

* Fixed tests and bundle size

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-30 10:50:34 -04:00
Ahmad Bamieh 4f717708b4
[Telemetry] [Schema] remove number type and support all es number types (#81774) 2020-10-30 04:34:20 +02:00
Joe Reuter afd5fe3b8a
Date column utilities (#81007) 2020-10-29 16:47:34 +01:00
Tyler Smalley 3af1099ba8
[browserlist] Excludes browsers not supporting es6-class (#81431)
* Updates browserlist to exclude those not supporting es6-class

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2020-10-28 16:38:59 -07:00
Mikhail Shustov 2782204cc1
Get rid of global types (#81739)
* move global typings to packages/kbn-utility-types

* update all imports

* add tests

* mute error

* update docs

* ok

* rename kbn-utility-types/test --> kbn-utility-types/jest
2020-10-28 11:03:04 +01:00
Spencer 72ff6b8741
[kbn/optimizer] ignore missing metrics when updating limits with --focus (#81696)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-10-26 18:38:36 -07:00
Tyler Smalley aaa4795b83
[CI] Preparation for APM tracking on CI (#80399)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2020-10-26 15:42:38 -07:00
Liza Katz 046c840b7c
[Search] Error Alignment 2 (#80965)
* Improve the display of ES errors and Http errors

* fixes

* Improve text

* fix ts

* update limit

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-26 14:36:20 +02:00
Ahmad Bamieh 82ba41c30d
[Plugin generator] Update readme (#81131) 2020-10-25 14:35:28 +02:00
renovate[bot] 67f46ae223
Update dependency @elastic/charts to v24 (#80982)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-22 18:21:13 +02:00
Alison Goryachev 6ec817b8d0
Move painless lang support to @kbn/monaco (#81010) 2020-10-22 08:28:03 -04:00
Tiago Costa 23142afa9b
chore(NA): add spec-to-console and plugin-helpers as devOnly dependencies (#81357) 2020-10-22 00:02:36 +01:00
Nathan L Smith 99e90aa120
Use Storybook Controls instead of Knobs (#80705)
* Change an example in embeddable to use controls instead of knobs
* Add controls to SyncBadge APM story
* Convert both to [CSF](https://storybook.js.org/docs/react/api/csf)
* Remove the Knobs addon from the default Storybook configuration

Do not remove the Knobs addon package, since Canvas is still using it and this does not change anything in Canvas.
2020-10-21 15:43:57 -05:00
Spencer 3db19d60b4
[junit] make sure that report paths are unique (#81255)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-10-21 12:46:45 -07:00
Mikhail Shustov 93473e4f58
bump elastic/elasticsearch-js version to 7.10.0-rc1 (#81288) 2020-10-21 21:36:19 +02:00
Robert Austin a74cea30c5
[Security Solution] reduce optimizer limits (#80997) 2020-10-19 18:04:21 -04:00
Chandler Prall 42a1744af6
Upgrade EUI to v29.5.0 (#80753)
* Upgraded eui to v29.5.0; snapshot updates

* Cleaned up some types

* addresses feedback on types change

* Update EuiIcon snapshots in jest integration tests

* Updated snapshot from rebasing on master
2020-10-19 14:48:33 -06:00
Mikhail Shustov ef2be2c725
server logs config paths to use for runner (#52980)
* server logs config paths to use for runner

* fix eslint issue

* do not log config path for default config

* update snapshots

* fix other tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-10-17 09:48:58 +02:00
Mikhail Shustov 2e37bd0703
Add script to identify plugin dependencies for TS project references migration (#80463)
* move kbn-dev-utils plugin helpers under a dedicated folder

* use getPluginSearchPaths in kbn-config & kbn-optimizer

* add a script to find plugin dependencies not migrated to TS project refs

* update docs

* add a script reporting all circular deps between plugins

based on kibana.json declaration, so it doesn't provide all the cases

* fix optimizer scan logic. removed by mistake

* revert changes. fails on CI

* remove prod depenedency on kbn/dev-utils

* remove last export

* only run plugin discovery once to speed up circular dep detection

* address comments

* address comments

* update fixtures

Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-10-16 11:55:46 +02:00
Nathan L Smith 5f3e2c05e8
Add Storybook a11y addon (#80069) 2020-10-15 17:25:34 -05:00
Spencer ff32bb1716
[kbn/optimizer] tweak split chunks options (#80444)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-10-15 14:24:29 -07:00
Spencer 07c1284e9d
[kbn/bootstrap] validate that certain deps don't ship in production (#80549)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-10-15 09:56:10 -07:00
Spencer 8940091cf9
[ci-stats] record async chunk count (#80606)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-10-15 08:07:17 -07:00
Spencer bc4093a0cb
[kbn/optimizer] add support for --focus option (#80436)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-10-14 08:16:27 -07:00
Spencer 869ca46ef0
[kbn/std] update rxjs helpers to use simple operators (#80416)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-10-14 07:11:10 -07:00
Uladzislau Lasitsa ba8e9a52b6
Timelion y-axis label not displayed (#80007)
* Moved flot in ui-shared-deps and leavt only one version.

* Removed unneeded import

* use commonJS so we can execute code between loading specific modules

* prefix i18n keys with flot.

* Fix Internationalization

* remove duplicate pie plugin

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-14 16:58:35 +03:00
Spencer b5c5bf706d
[kbn/optimizer/node/cache] support up to 500 readers (#80354)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-10-13 09:24:36 -07:00
Tyler Smalley 8da824e100
[CI] Correctly resolve repository root for JUnit reports (#80226)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2020-10-12 16:57:16 -07:00
Tyler Smalley 92bb8e7cfc
Migrate Jest JUnit reporter to TS (#79919)
* Converts Jest JUnit reporter to TS

Also moves reporter to @kbn/test package

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2020-10-11 21:03:20 -07:00
Mikhail Shustov 5d71db0427
store sorted bundleRefExportIds (#80011)
* store sorted bundleRefExportIds

* sort consistently
2020-10-09 09:52:41 +02:00
Spencer f5fc765576
[kbn/std] add observable helpers to aid with rxjs 7 upgrade (#79752)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-10-08 17:45:51 -07:00
Spencer 769bd75c1a
[kbn/optimizer] bump low or add missing limits when updating automatically (#80013)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-10-08 11:22:51 -07:00
Ahmad Bamieh 70549c2ffa
[Telemetry] Telemetry tools check all makeUsageCollector calls (#79840) 2020-10-08 14:42:23 +03:00
Spencer fd066f7b63
[kbn/optimizer] report limits with ci metrics (#78205)
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-07 15:43:14 -07:00
Spencer 3c7529147e
[release notes] extract "dev docs" comment too (#79351)
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-07 15:20:31 -07:00
Spencer 8f41c59be0
share tslib across bundles (#79915)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-10-07 14:47:21 -07:00