* Show add agent link instead of 0 agents
* Add popover
* open and close popover
* fill button
* add popover to agent cell
* PR feedback
* only add offset to props if it's provided
* make code clearer
* Update x-pack/plugins/fleet/public/components/add_agent_help_popover.tsx
Co-authored-by: Dave Snider <dave.snider@gmail.com>
* remove unused import
* whitespace
Co-authored-by: Dave Snider <dave.snider@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Use the new data stream (if exists) to write action request to
and then the fleet index. Else do as usual.
fixes elastic/security-team/issues/1704
* fix legacy tests
* add relevant additional tests
* remove duplicate test
* update tests
* cleanup
review changes
refs elastic/security-team/issues/1704
* fix lint
* Use correct mapping keys when writing to index
* write record on new index when action request fails to write to `.fleet-actions`
review comments
* better error message
review comment
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [APM] Removes the apm_oss plugin and deprecates related configs (#108160)
* removes commented lines
* fixes typescript errors
* performs start up migration on the saved objects mapping for apm-indices
* removes all references to the deprecated apm_oss.* config paths in APM
* fixes missing bundle error
* fixes type error
* fixes eslint error with disabled rules
* fixes saved object mappings for es_archvices for tests
* fixes eslint error
* Updates default index values to include the more general apm-*. Fixes broken tests.
* removing unused configs from the config path migration: apm_oss.indexPattern and apm_oss.fleetMode
* - replaces full index configuration paths with references in the `xpack.apm.indices` namespace
- removes mergeConfig function and test
* fixes proxy mock object in unit test
* fixes linting issues
* PR feedback and failed test
* changes the configs at `xpack.apm.indices.*` from plural to singular to match `processor.event` values
* Fix unsaved changes prompt showing up between tabs
We already added a reducer for this but forgot to implement this. Because we have shared state between the tabs, we need to overrule the unsaved changes prompt when simply navigating between tabs.
* Fix some timezone issues
After wiring up the backend and converting to UTC, some changes to mocks and time formats had to be made.
* Refactor to remove blockedWindows reducer
This commit refactors to make use of the already-in-state schedule object. Previously, while wiring up the static views, I used a blockedWindows array directly on the state tree. This simplifies things so that equality checks can be done with one object.
* Wire up ability to remove blocked window
* Fix key and remove fallback
It was hard to test removing an item from an array that doesn’t exist so I changed the code to expect the array to be present (! operator), since the other path is not possible.
Also updated the server value from deletion to delete to match the API
* Wire up blocked windows form to change values and update state
* Pass formatted blocked_windows to server
(test was covered in previous commit)
* Update link text, hrefs, and replace temp copy
One of the links was removed intentionally
* Fix typo
* Fix edge case where unsaved changes shown when removing last item
The API omits the key when there are no items so we need to have the item removed as well in the UI state. Otherwise, removing the last item will cause the UI to say there are unsaved changes when there are not.
I tried setting it as:
schedule.blockedWindows = undefined
but the selector did not see those as equal but deleting the key does.
* More typo fixes
Syncronization -> Synchronization (+h)
* Fix link address
* Refactor for simplicity
Was unable to figure out the TypeScript but did some more digging
* Upgraded the version of EUI to 38.2.0 from 38.0.1
* Updated the i18n mappings required for EUI v.38.2.0
* Update i18n snapshots and resolve linting error
* Removed html_id_generator mocks.
Current mock was failing due to missing useGeneratedHtmlId export. This is safe to remove because EUI contains a .testenv that contains an mock for html_id_generator. More info at https://github.com/elastic/eui/blob/master/src/services/accessibility/html_id_generator.testenv.ts
* Resolve linting error in i18n mapping file
* Removed html_id_generator mocks.
Current mock was failing due to missing useGeneratedHtmlId export. This is safe to remove because EUI contains a .testenv that contains a mock for html_id_generator. More info at https://github.com/elastic/eui/blob/master/src/services/accessibility/html_id_generator.testenv.ts
* Update plugin snapshots
* Resolve merge conflict in license_checker config.ts file
* Upgrade EUI to version 39.0.0 from the original target (38.2.0) to handle an issue found with a functional test during the original upgrade
* Updated the i18n mapping for EUI v.39.0.0
* Update various snapshots to account for the an i18n translation token addition in EUI v. 39.0.0
* Updated test cases marked as obsolete by CI
* Update src/dev/license_checker/config.ts
Removing TODO comments from src/dev/license_checker/config.ts as they are no longer needed.
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* Move copy function to `isCopyable` on EuiCodeBlock
* Using EuiMarkdownFormat for Content
* Using KibanaPageTemplate for not found page
* Using KibanaPageTemplate for tutorial page and splitting into more panels
* Better spacing inside instruction_set
* Rendering Introduction as a EuiPageHeader
* Changed module notice “NOTE” to icon
* Moving tabs to the first set of content in an instructions set; Using EuiSplitPanel
* Changed fields button to a simple link
* Changed button group to wide, text colored, left-aligned set
* moving interval help text as a tooltip on the datepicker
* [Metrics UI] Refactor Snapshot data for use in FilterBar
Co-authored-by: Chris Cowan <chris@chriscowan.us>
* Refactor to use correct kea way of doing reset
The listener is not needed as the actions can set the state themselves
* Wire up reset button for Frequency section
* Extract shareble updateServerSettings method
We use a PATCH call to the server to update the state. We can extract this to a shared actions.updateServerSettings method that can be used in the main toggle on the Synchronization landing page, the Frequency section and the Object and assets section.
As a part of this commit, I refactored `updateSyncEnabled` to use this method as well. In doing so, to simplify things, I removed the granular enabled/disabled message in favor of the generic “"Source synchronization settings updated.” message that the other sections use. The state of the toggle is a good enough indication of the state the server is in.
I also renamed the updateSyncSettings method to updateObjectsAndAssetsSettings, as it was incorrectly named.
* Add schema for schedules
* Use mutable schedule in component
Originally used the immutable version directly on the content source for initial read view. We now use a mutable one found in SynchronizationLogic
* Set local copies of schedule after persisting to server
* Wire up form change handlers
We pass the ‘type’ to the component to inform the logic file which section is being changed. We then update the mutable `schedule` reducer with the correct value
* Wire up save button and persist changes
* Add type and make server prop optional
If there are no blciked windows, we send undefined, so the type has been updated.
* Add unsaved changes propmpt
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* refactor common fields
* add ignore_https_errors and journey filters options
* adjust formatters and normalizers
* adjust content and hide fields when zip url is not defined
* adjust content again
* update tests
* adjust tests
* adjust tests
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* added outcome to backend routes
* adds so resolved property alias_target_id to response
* adds UI portion
* working URL redirect on aliasMatch - todo -> update rule details page refresh button to use SO resolve.
* cleanup
* fix integration tests
* fix jest tests
* cleanup types
* fix eslint.. I think vs code formatted this
* WIP - undo me, working index.test.ts function
* WIP - also undo me, probably
* working test for aliasMatch, need to add test for outcome = conflict
* add conflict callout when SO resolve yields conflict outcome
* code cleanup
* fix type issues
* small cleanup, fix jest test after undoing changes for getFailingRuleStatus
* cleanup tests
* add alias_target_id to response validation too
* unit test changes
* update tests again
* add all dependencies to useEffect and prefer useMemo
* add type cast
* adds integration tests for different outcomes after mocking a migrated rule leading to an aliasMatch and a migrated rule + accidental inserted rule to lead to a conflict. Also removes the outcome property if it is an exactMatch
* remove unused import
* fix test
* functional WIP
* cleanup
* cleanup
* finishing touches to address PR review comments
* remove console.error
* fix bug where spaces was not typed correctly in the plugin start method here https://github.com/elastic/kibana/pull/113983
* 🐛 Fix metric rescale
* 📸 Restored old snapshots
* 🐛 Extend the fix to all scenarios
* 📸 Refresh snapshots for new fix
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>