## Summary
Fixes flake tests of:
https://github.com/elastic/kibana/issues/115918https://github.com/elastic/kibana/issues/103273https://github.com/elastic/kibana/issues/108640https://github.com/elastic/kibana/issues/109447https://github.com/elastic/kibana/issues/100630https://github.com/elastic/kibana/issues/94535https://github.com/elastic/kibana/issues/104260
Security solution has been using `bsearch` and has encountered flake in various forms. Different developers have been fixing the flake in a few odd ways (myself included) which aren't 100%. This PR introduces a once-in-for-all REST API retry service called `bsearch` which will query `bsearch` and if `bsearch` is not completed because of async occurring due to slower CI runtimes it will continuously call into the `bsearch` with the correct API to ensure it gets a complete response before returning.
## Usage
Anyone can use this service like so:
```ts
const bsearch = getService('bsearch');
const response = await bsearch.send<MyType>({
supertest,
options: {
defaultIndex: ['large_volume_dns_data'],
}
strategy: 'securitySolutionSearchStrategy',
});
```
If you're using a custom auth then you can set that beforehand like so:
```ts
const bsearch = getService('bsearch');
const supertestWithoutAuth = getService('supertestWithoutAuth');
const supertest supertestWithoutAuth.auth(username, password);
const response = await bsearch.send<MyType>({
supertest,
options: {
defaultIndex: ['large_volume_dns_data'],
}
strategy: 'securitySolutionSearchStrategy',
});
```
## Misconceptions in the tests leading to flake
* Can you just call the bsearch REST API and it will always return data first time? Not always true, as when CI slows down or data increases `bsearch` will give you back an async reference and then your test will blow up.
* Can we wrap the REST API in `retry` to fix the flake? Not always but mostly true, as when CI slows down or data increases `bsearch` could return the async version continuously which could then fail your test. It's also tedious to tell everyone in code reviews to wrap everything in `retry` instead of just fixing it with a service as well as inform new people why we are constantly wrapping these tests in `retry`.
* Can we manually parse the `bsearch` if it has `async` for each test? This is true but is error prone and I did this for one test and it's ugly and I had issues as I have to wrap 2 things in `retry` and test several conditions. Also it's harder for people to read the tests rather than just reading there is a service call. Also people in code reviews missed where I had bugs with it. Also lots of boiler plate.
* Can we just increase the timeout with `wait_for_completion_timeout` and the tests will pass for sure then? Not true today but maybe true later, as this hasn't been added as plumbing yet. See this [open ticket](https://github.com/elastic/kibana/issues/107241). Even if it is and we increase the timeout to a very large number bsearch might return with an `async` or you might want to test the `async` path. Either way, if/when we add the ability we can increase it within 1 spot which is this service for everyone rather than going to each individual test to add it. If/when it's added if people don't use the bsearch service we can remove it later if we find this is deterministic enough and no one wants to test bsearch features with their strategies down the road.
## Manual test of bsearch service
If you want to manually watch the bsearch operate as if the CI system is running slow or to cause an `async` manually you manually modify this setting here:
https://github.com/elastic/kibana/blob/master/src/plugins/data/server/search/strategies/ese_search/request_utils.ts#L61
To be of a lower number such as `1ms` and then you will see it enter the `async` code within `bsearch` consistently
## Reference PRs
We cannot set the wait_for_complete just yet
https://github.com/elastic/kibana/issues/107241 so we decided this was the best way to reduce flake for testing for now.
### Checklist
- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
This commit introduces the multi-layer time axis in Discover, Lens, Visualize, TSVB.
It adds visualization:useLegacyTimeAxis advanced settings under charts plugin to toggle legacy time axis.
The new multi-layer time axis is introduced in @elastic/charts https://elastic.github.io/elastic-charts/?path=/story/area-chart--timeslip and was demoed as part of the Kibana Demo Days.
It is the outcome of the research done in elastic/elastic-charts#1310 related to improving the time axis solving the following problems:
- sparse time labels that can be far apart
- unclear where time point is on the label (the middle)
- difficult / tedious to read due to redundant information and small fonts
- resolution is not explicit (is it hours of days or days themselves)
* bump to a pre-8.0 version
* export KibanaClient from /lib sub-folder
* workaround the problem of the absence of estypes
* update es client usage in pacakges
* export estypes from another path
* import errors from root
* import errors from root 2
* update transport import
* update import path for /api/types
* update import path for /api/types
* import errors from top export
* use TransportResult instead if ApiResponse
* fix errors in client_config
* fix src/core/server/saved_objects/migrationsv2/actions/integration_tests/actions.test.ts
* use KibanaClient in mock. we dont export the original Client
* fix client mocks
* fix errors on SO
* fix remaining core errors
* update estype import path
* fix errors in data plugin
* fix data_views
* fix es_ui_shared
* fix errors in interactive_setup
* fix errors in ./test folder
* add @elastic/transport to the runtime deps
* fix errors in packages
* fix erros in src/core
* fix errors in test/
* fix an error in actions plugin
* woraround and fix errors in APM plugin
* fix errors in canvas
* fix errors in event_log
* fix errors in fleet
* fix errors in ILM
* fix errors in infra
* fix errors in ingest_pipeline
* fix errors in lens
* fix errors in license_management
* fix errors in licensing
* fix errors in logstash
* fix errors in ml
* fix errors in monitoring
* fix errors in observability
* fix errors in rule_registry
* fix errors in reporting
* fix errors in rule_registry
* fix errors in security
* fix errors in security_solution
* fix errors in snapshot_restore
* fix errors in transform
* fix errors in UA
* fix errors in uptime
* fix errors in x-pack/test
* fix eslint errors
* fix new errors
* use default HTTP Connection. Undici does not support agent config options keepAlive and maxSockets
* create does not accept require_alias option
* update deps
* use transport types exported from ES client package
* fix ErrorCause | string errors
* do not use enum
* fix errors in data plugin
* update x-pack code
* fix transport
* fix apm search request
* do not crash on reporting
* fix kbn-test build
* mute reporting error to start
* fix ftr build
* another attempt
* update import path
* address or mute new errors
* REMOVE me. pin transport version temporarily.
* remove deep imports from transport package
* fix jest crash
* fix product check tests
* remove unnecessary ts-expect-error
* fix a few failed unit tests
* bump to canary 24
* remove unnecessary ts-expect-error
* remove dependency on transport
* fix types in tests
* mute errors in xpack tests
* product check doesn;t spam in logs anymore
* filterPath --> filter_path
* ignoreUnavailable --> ignore_unavailable
* ignoreUnavailable --> ignore_unavailable
* trackScores --> track_scores
* trackTotalHits --> track_total_hits
* fix es-arcives
* fix data plugin crashes
* fix watcher test utils
* rollback unnecessary changes
* fix another problem in es-archiver
* fix scroll. for whatever reason scroll fails when request scroll_id in body
* add meta: true in kbn-securitysolution-es-utils
* bump client to canary 25
* fix errors in accordance with the es client spec
* update securityscolution-es-utils
* unify scroll api in reporting and fix tests
* fix unit tests in watcher
* refactor APM to abort request with AbortController API
* fix missing es client calls in tests
* fix missing meta in detection engine FTR tests
* fix another bunch of errors in js tests
* fix wrong coercion
* remove test-grep pattern
* fix apm unit test
* rename terminateAfter to terminate_after in infra plugin
* rename terminateAfter to terminate_after in uptime plugin
* rename terminateAfter to terminate_after in apm plugin
* fix security roles FTR tests
* fix reference
* fix post_privilidges test
* fix post_privilidges
* bump client to 26
* add meta for index_management test helpers
* remove ts-expect-error caused by bad type in reason
* bump client to 27
* REMOVE me. workaround until fixed in the es client
* fix incorrect type casting
* swtich from camelCase params
* use `HttpConnection` for FTR-related clients
* bump client to 29
* Revert "REMOVE me. workaround until fixed in the es client"
This reverts commit c038850c09.
* fix new util
* revert repository changes
* do not crash if cannot store event_loop data
* fix new estypes imports
* fix more types
* fix security test types and add ts-ignore for custom ES client
* fix more estypes imports
* yet more ts violations
* line by line fixing is hard
* adapt `evaluateAlert` from infra as it's also used from FTR tests
* use convertToKibanaClient in FTR test instead of meta:true in plugin code
* migrate from deprecated API in fleet
* fix intergration tests
* fix fleet tests
* fix another fleet test
* fix more tests
* let's call it a day
* Removes custom header check on 404 responses, includes es client ProductNotSupportedError in EsUnavailableError conditional (#116029)
* Removes custom header check on 404 responses, includes es client ProductNotSupportedError in EsUnavailableError conditional
* Updates proxy response integration test
* disable APM until compatible with client v8
* skip async_search FTR test
* use kbnClient in integration tests
* bump version to 29
* bump to 30
* have configureClient return a KibanaClient instead of Client, remove resolved violations.
* bump to 31
* bump to 31
* Revert "bump to 31"
This reverts commit 5ac713e640.
* trigger stop to unusubscribe
* update generated docs
* remove obsolete test
* put "as" back
* cleanup
* skip test
* remove new type errors in apm package
* remove ErrorCause casting
* update a comment
* bump version to 32
* remove unnecessary ts-expect-error in apm code
* update comments
* update to client v33
* remove outdated type definition
* bump to 34 without params mutation
* unskip the test that should not fail anymore
* remove unnecessary ts-expect-error comments
* update to v35. body can be string
* move `sort` to body and use body friendly syntax
* fix a failing test. maps register the same SO that has been already registered by home
Co-authored-by: pgayvallet <pierre.gayvallet@gmail.com>
Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>
* Make Dashboard SO multiple-isolated
* Fix integration tests
* Fix Saved Objects API Integration Tests
* Fix more tests
* Fix even more tests
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [ML] Initial embed
* [ML] Initial embed props
* [ML] Add top nav link to data viz
* Add visible fields
* Add add data service to register links
* Renames, refactor, use constants
* Renames, refactor, use constants
* Update tests and mocks
* Embeddable
* Update hook to update upon time udpate
* Add filter support to query
* Refactor filter utilities
* Add filter support for embeddable
* Fix saved search data undefined
* Prototype aggregated view/document view switcher
* Prototype flyout
* Prototype save document view option in storage
* Fix filter and query conflict with saved search
* Minor styling edits
* [ML] Initial embed
* [ML] Initial embed props
* Add embeddable 1
* Add visible fields
* Embeddable 2
* Add filter support to query
* Refactor filter utilities
* Add filter support for embeddable
* Fix saved search data undefined
* Prototype aggregated view/document view switcher
* Prototype flyout
* Prototype save document view option in storage
* Fix filter and query conflict with saved search
* Minor styling edits
* Fix missing code after conflicts
* Remove dv locator and flyout
* Make types happy
* Fix types
* Rename toggle option
* Resolve conflicts
* [ML] Reduce size of chart
* [ML] Unbold name, switch icons of show distributions
* [ML] Make size consistent
* [ML] Make page size 25
* [ML] Switch to arrow right and down
* [ML] Make legend font smaller
* [ML] Add user setting
* [ML] Add show preview by default setting
* [ML] Match icon
* Add panels around the subcontent
* Add preference for aggregated vs doc
* Fix types
* Fix types, add constants for adv settings
* Change to data view type
* Temp fix for Kibana/EUI table overflow issue
* Modify line height so text is not cut off, modify widths for varying screen sizes
* Different width padders for different screens
* Fix CI
* Merge latest, move button to the right
* Fix width for bar charts previews
* Fix toggle buttons, fix maps
* Delete unused file
* Fix boolean styling
* Change to enum, discover mode
* Hide field stats
* Hide field stats
* Persist show mini preview/distribution settings
* Remove window size, use size observer instead
* Default to document view
* Remove bold, switch icon
* Set fixed width for top values, reduce font size in table
* Fix custom url tests
* Update width styling for panels
* Fix missing flag for Discover sidebar, jest tests
* Fix max width
* Workaround for sorting
* Fix import
* Fix styling
* Make height uniform, center alignment, fix map and keyword map not same size
Move styling
* Revert "Make height uniform, center alignment, fix map and keyword map not same size"
This reverts commit 8fc42e2f
* Revert "Make height uniform, center alignment, fix map and keyword map not same size"
This reverts commit 8fc42e2f
* Uniform height, left aligned, flex grid
* Switch top values to have labels
* Center content
* Replace fixed widths with percentage
* Fix table missing field types
* Add dashboard embeddable and filter support
* Fix file data viz styling and tests, lean up imports, remove hard coded pixels
* Add search panel/kql filter bar
* Temporarily fix scrolling
* New kql filters for data visualizer
* Set map height so it will fit the sampler shard size text
* Use eui progress labels
* Fix spacer
* Add beta badge
* Temporarily fix scrolling
* Fix grow for Top Values for
* [ML] Update functional tests to reflect new arrow icons
* [ML] Add filter buttons and KQL bars
* [ML] Update filter bar onChange behavior
* [ML] Update top values filter onChange behavior
* [ML] Update search filters when opening saved search
* [ML] Clean up
* [ML] Remove fit content for height
* [ML] Fix boolean legend
* [ML] Fix header section when browser width is small to large and when index pattern title is too large
* [ML] Hide expander icon when dimension is xs or s & css fixes
* [ML] Delete embeddables because they are not use
* [ML] Rename view mode, refactor to separate hook, add error prompt if can't show, rename wrapper, clean up & fix tests
* [ML] Make doc count 0 for empty fields, update t/f test
* [ML] Add unit testing for search utils
* Fix missing unsubscribe for embeddable output
* Remove redundant onAddFilter for this PR, fix width
* Rename Field Stats to Field stats to match convention
* [ML] Fix expand all/collapse all behavior to override individual setting
* [ML] Fix functional tests should be 0/0%
* [ML] Fix docs content spacing, rename classnames, add filters to Discover, lens, and maps
* [ML] Fix doc count for fields that exists but have no stats
* [ML] Fix icon styling to match Discover but have text/keyword/histogram
* [ML] Fix doc count for fields that exists but have no stats
* [ML] Rename classnames to BEM style
* Resolve latest changes
* [ML] Add tests for data viz in Discover
* Update tests & dashboard behavior to reflect new advanced settings
* Update telemetry
* Remove workaround after eui bump fix
* Fix missing bool clause
* Add login
* Fix saved search attributes broken with latest changes
* Update tests
* Fix import
* Match the no results found
* Fix query util to return search source's results right away. Fix texts.
* Rename old test suits to farequoteDataViewTestData
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* added page to reporting example app that contains the capture tests
* first version of PNG capture for test A
* added types file to common
* added data-shared-item attr to image, also added capture menu items
* fix image CSS by providing a fixed width and height
* explicitly add layout for print, does not seem to do anything though?
* added magic numbers of image sizes
* added reporting examples test folder
* first version of capture test for generating and comparing PNGs
* added PNG service and PNG baseline fixture
* added pdf-to-img dev dependency
* refactor compare_pngs to accept a buffer
* added comment to interface
* png service -> compare images service
* export image compare service
* added test for pdf export
* clean up log
* minor fixes and added pdf print optimized test
* added pdf and pdf print fixtures
* refactor lib function name
* Update difference thresholds
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [Discover] Fix field filters test
* Change the fixture for the test
* Fix discover fixture
* Remove empty line
* Restore after
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Replacing EuiPopover with EuiComboBox
* The combobox will help alleviate issues when the list of options is very long
* Refactoring the Combobox to listen for change events
* Added an onChange handler
* Renamed the method to render the combobox
* Commented out additional blocks of code before final refactor
* Finished refactoring the Request Selector to use EUI Combobox
* Removed three helper methods for the EUIPopover.
* `togglePopover()`
* `closePopover()`
* `renderRequestDropdownItem()`
* Removed the local state object and interface (no longer needed)
* Renamed the const `options` to `selectedOptions` in `handleSelectd()`
method to better reflect where the options array was coming from.
* Updating tests and translations
* Fixed the inspector functional test to use comboBox service
* Removed two unused translations
* Updating Combobox options to pass data-test-sub string
* Updated two tests for Combobox single option
* Updated the test expectations to the default string
* Both tests were looking for a named string instead of a default
message
* Adding error handling to Inspector combobox
* Checking for the item status code
* Adding a " (failed)" message if the status code returns `2`
* Updating test to look for "Chart_data" instead of "Chartdata"
* Updating two tests to validate single combobox options
* Added helper method to check default text against combobox options
* Added helper method to get the selected combobox option
* Checking two inspector instances using helpers
* Adding a defensive check to helper method.
* Correct a type error in test return
* Adding back translated failLabel
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Nathan L Smith <smith@nlsmith.com>
* Persist hide chart to local storage
* [Discover] Persist hide chart option to local storage
* Fix state
* Fix dependency check
* Set chart state to undefined
* Update unit test
* Do not override saved search preferences
* Fix missing import
* Add a functional test
* Add a functional test
* Fix functional test
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>