Commit graph

869 commits

Author SHA1 Message Date
Larry Gregory 53f5f50b71
fix redirect after logging in (#25546) 2018-11-14 16:48:07 -05:00
Larry Gregory 1343ef1ec2
adds read_ccr and manage_ccr cluster privileges (#25605) 2018-11-14 16:32:50 -05:00
Larry Gregory d8f8a0c26d
Fix anonymous access to status page (#24706)
* fix status.allowAnonymous

* address PR feedback
2018-11-14 16:28:26 -05:00
Clint Andrew Hall a0e9a3b901
Revert "Feature/translate canvas plugin src elements (#23755)" (#25662)
This reverts commit f10deb1b8a.
2018-11-14 12:00:13 -06:00
Rashid Khan ab796859ab
Make gulp canvas:test work (#25492) 2018-11-14 10:02:06 -07:00
Joe Fleming 9971981361
Fix: IE11 compat (#25562)
* fix: switch to new CustomEvent

new Event is not supported in IE11

* fix: skip element.scrollTo when not available

that method doesn't exist on elements in IE11
2018-11-14 09:59:23 -07:00
Caroline Horn 2b3bff34b8
TSVB less to sass - and some UI work (#24250)
Fixes #16483, Fixes #20115, Fixes #17852, Fixes #16768, Fixes #14348, Fixes #17842, closes #15580, closes #14938
2018-11-14 11:10:08 -05:00
Nox911 8143d58ea4 Feature/translate monitoring license (#24826)
* Translate monitoring -> license

* Translate monitoring -> page_loading

* Translate monitoring -> no_data

* Fix issues

* Update unit tests

* Fix eslint
2018-11-14 17:17:49 +03:00
Brian Gaddis dc2953a8fb Combine common pdf png functions (#25152)
* Create common routines for PDF and PNG report processing

* REmove Blacklisted headers not needed

* Changes for issues with PDF and PNG testing

As per Joel Griffith suggestion I added removal of toast notifications after each click download report.  And removed setting of image density to 300.

* removed uneccesary image compare routine

* Moved server from property on job to passed in parameter.

* consolidated PDF and PNG testing

Moved test code from PDF and PNG index.test.js into a common index.test.js that now tests the common functions.

* Typescripted the common functions and broke out tests to individual test files

* Create a common create mock server function that all new tests call

* Removed unnecessary exception check and removed test include from index.ts
2018-11-14 08:28:07 -05:00
Nox911 aca3fe3a15 Feature/translate monitoring table (#24973)
* Translate monitoring -> summary_status, table, main.html in directives

* Fix issues

* Fix tests

* Add disable eslint for unused var  intl
2018-11-14 12:39:28 +03:00
Matthew Kime bb250560ec
Fixes index pattern wizard when there are remote clusters but no local indices (#24339)
* don't hide wizard if clusters exist

* catch errors

* add toast notifs if unable to load data
2018-11-13 14:00:27 -06:00
Aleh Zasypkin ca1d280818
Fix paths to the i18n enzyme helpers in monitoring tests. (#25593) 2018-11-13 20:24:14 +01:00
spalger 5366de4bf1 disable flaky test 2018-11-13 09:26:46 -08:00
Maryia Lapata 7a31758061
[i18n] Translations for Monitoring: Logstash (#24897)
* Translate Monitoring logstash

* Fix a typo

* Update unit tests
2018-11-13 17:56:02 +03:00
Jason Rhodes 6d79657b41
Adds UI notification for dropped spans (#25017)
* Adds icon and tooltip for dropped spans

* Adds callout and style in transaction flyout instead of timeline for dropped spans message

* Review tweaks and linting fixes
2018-11-13 08:14:24 -05:00
Ryan Keairns ffac06a2a4
[Canvas] Decrease size of tray toggle (#25470)
* decrease size of toggle bar

* change bg colors for toggle
2018-11-12 18:55:18 -06:00
Catherine Liu c2a24fb238
Fixes duplicate 'Value' options in math function select (#25556) 2018-11-12 17:05:56 -07:00
Spencer 59eff29786
[canvas] Improve plugin pre-build (#25267)
Fixes https://github.com/elastic/kibana/issues/23552

Extends the webpack config used to pre-build `x-pack/plugins/canvas/canvas_plugins_src` so that it does a couple things:
 - use the "browser" and "main" fields when defined by packages, this allows the already transpiled output of packages like `@elastic/eui` to be used rather than rebuilding from source
 - use the `@kbn/babel-preset/webpack_preset` for babel-loader
 - include all errors in the log output when an error occurs
2018-11-12 16:04:36 -08:00
Tiago Costa ee4a3d2558
fix(NA): recent unconforming licenses. (#25560) 2018-11-12 21:39:06 +00:00
Stacey Gammon 1eaca25472
[Flaky test fix] Turn back on data_shared_attributes test (#25156)
* Turn back on data_shared_attributes test and run 20x

* Add some clean up

* Be more determinism, less refactoring.

* Go back to a single test run
2018-11-12 14:47:24 -05:00
Josh Dover 77522a7bd2
[kbn-pm] Use yarn workspaces for dependencies (#24095) 2018-11-12 12:38:11 -06:00
Joe Fleming 50eb9e6ef4
Fix: Quote the index pattern in SQL input (#25488)
SQL requires that you quote the index name if you are using special characters (like *, with an index pattern). Our default value didn't work since `logstash*` was not quoted.

### Before

![screenshot 2018-11-09 13 03 21](https://user-images.githubusercontent.com/404731/48285446-db599380-e41f-11e8-85cc-320b03a004b0.png)

### After

![screenshot 2018-11-09 13 34 18](https://user-images.githubusercontent.com/404731/48286844-2c6b8680-e424-11e8-9329-435adbe9dc06.png)

...and if you select some valid fields so you don't get an array in the results:

![screenshot 2018-11-09 13 34 48](https://user-images.githubusercontent.com/404731/48286891-49a05500-e424-11e8-8d66-4c9ac208d358.png)
2018-11-09 16:12:23 -07:00
Tiago Costa dc956a0a79
Fix non-conforming licenses on devDependencies and add the ability to whitelisting devOnly licenses (#23859)
* chore(19834): upgraded yargs dependency to 4.8.1 in order to remove pkg-conf dependency license conflict.

* chore(19834): override xmldom to one of the allowed licenses (MIT).

* chore(19834): added some overrides and whitelistenig for Apache2.

* chore(19834): correct overides for some apache2 licenses.

* chore(NA): updated specific dependency needs.

* chore(19834): added some more info on updated licenses.

* chore(19834): small note on dependencies use versions.

* feat(NA): add the ability to white list licenses only valid for dev only dependencies.

* chore(NA): update yarn lock files to include integrity check.

* fix(NA): yarn lock file for kbn ui framework.

* docs(NA): fix uncompleted comment left on the code.
2018-11-09 02:11:17 +00:00
Joe Fleming 830c195b0d
fix: get correct plugins path (#25448)
we can't check the name of the outer path because it can change, instead, just make sure there's a plugins path there
2018-11-08 17:37:17 -07:00
Søren Louv-Jansen d181d4dc8e
[APM] Minor cleanup of constants (#25177)
* [APM] Minor cleanup of constants

* Simplify constants test
2018-11-09 00:20:00 +01:00
Søren Louv-Jansen 65ae04a5bd
[APM] Format as microseconds (#24974)
* [APM] Format as microseconds

* Split interface into `value` and `options`

* Update formatters.test.ts
2018-11-09 00:19:20 +01:00
CJ Cenizal e2079c6373
Wrap long field names in Rollup Job Wizard tables. (#25405) 2018-11-08 14:00:00 -08:00
Pete Harverson 000cac77a9
[ML] Fixes the layout of the cards in the Data Visualizer on IE (#25383) 2018-11-08 21:17:40 +00:00
Pete Harverson df0d62f6ed
[ML] Updates job type and APM module icon to new designs (#25380)
* [ML] Updates job type and APM module icon to new designs

* [ML] Use self closing tags for icons

* [ML] Removes unnecessary icon from jobs list
2018-11-08 21:13:59 +00:00
Søren Louv-Jansen 051c23915d
[APM] Fix gap in timeline and fallback when traceroot is missing (#25346)
* Fix gap in timeline

* Show fallback when traceroot is unavailable

* Fix test

* Fix rendering issues with styled-components

* Remove `parentTransactionSkew `

* Minor test fixes
2018-11-08 22:08:39 +01:00
Walter Rafelsberger f2a0b9600c
[ML] angularjs controller initialization tests. (#25382)
* [ML] Confirm Modal Controller Test.

* [ML] Message Bar Controller test.

* [ML] Data Visualizer Controller test.

* [ML] Detector Filter Modal Controller test.

* [ML] Detector Modal Controller test.

* [ML] Save Status Modal Controller test.

* [ML] Multi Metric Create Job Controller test.

* [ML] Population Create Job Controller test.

* [ML] Recognize Create Job Controller test.

* [ML] Single Metric Create Job Controller test.

* [ML] Index Or Search Controller test.

* [ML] Job Type Controller test.

* [ML] Angular Bootstrap Patch Dropdown Controller test.

* [ML] Settings Controller test.

* [ML] Calenders List Controller test.

* [ML] New Event Modal Controller test.

* [ML] New Event Modal Controller test.

* [ML] Create Calendar Controller test.

* [ML] Time Series Explorer Controller test.

* [ML] Fixes typo, clearer test name.

* [ML] Fixes tests by restoring stubs.
2018-11-08 21:21:34 +01:00
Søren Louv-Jansen d6ad6dfafe [APM] Fix Rison issues (#25377)
* [APM] Fix Rison issues

* Fix CI

* Removed abstractions (and broke tests)

* Slight rework and small bugfix for query param handling

* Removed typo used for visibility testing oops

* Removes unused dep because linting doesnt work apparently
2018-11-08 14:07:18 -05:00
Søren Louv-Jansen 94b2aa4e0d
[APM] Fix missing transaction message (#25353) 2018-11-08 19:25:26 +01:00
Brandon Kobel 37b921b8a2
Using the new ES Realm syntax for SAML (#25223) 2018-11-08 09:28:53 -08:00
Chandler Prall a62252ce40
Update EUI to v5.0.0 (#25316)
* update EUI to v5.0.0

* update snapshots

* revert snapshot change

* revert snapshot change (2)
2018-11-08 10:16:44 -07:00
Joe Fleming c79fac22fa
Fix: Asset preservation (#25359)
* fix: proptype error

* fix: correct proptype checking

* fix: add assets placeholder to initial state

* chore: add history formatting function

* fix: load workpad assets when ids change

this causes the correct assets to be used
2018-11-08 09:20:28 -07:00
Clint Andrew Hall 80073b4555
Fix File Upload fatal (#25361)
## Summary (fixes #25342)

There is a fatal when using the File Upload control in the image upload control.  While the fatal appears to originate within the File Upload control, it is actually [coming from](https://github.com/clintandrewhall/kibana/blob/file-upload/x-pack/plugins/canvas/public/components/loading/index.js#L15) `Loading`, which attempts to use `react-redux` to change the `backgroundColor` of the loading indicator based on the page.

I couldn't find an instance where we use this Loading indicator outside of a redux context, so I've opted to simply use the control directly.  @rashidkpc agreed this would be a good fix for the moment.

In addition, I fixed a props error coming from the data-url field that made it read-only, so I fixed that, too, as well as a formatting issue with the Set button.

## Test Plan

Added a `setTimeout` call to simulate load.  Toggled between data url and literal URL.

![screen shot 2018-11-07 at 6 47 32 pm](https://user-images.githubusercontent.com/297604/48171133-20ff4a80-e2c0-11e8-9b9f-71818801744a.png)

- Before
![screen shot 2018-11-07 at 7 11 48 pm](https://user-images.githubusercontent.com/297604/48171320-09749180-e2c1-11e8-8a2a-f87d564944c1.png)
- After
![screen shot 2018-11-07 at 6 57 17 pm](https://user-images.githubusercontent.com/297604/48171134-20ff4a80-e2c0-11e8-9bec-f129cfbfaa18.png)
- Fixed Warning
![screen shot 2018-11-07 at 7 11 57 pm](https://user-images.githubusercontent.com/297604/48171334-142f2680-e2c1-11e8-8ab6-ee06e6231e6b.png)

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)
- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~
~~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~
~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
2018-11-08 09:57:51 -06:00
Carlos Pérez-Aradros Herce c757990be1 Relax hosts validation in Beats central management (#25376)
Current regexp was disallowing schema part of the URL (https://), so
https hosts couldn't be configured.

I opted for fully relaxing the reg exp here, as Beat will check it
anyway, and report errors in case it's wrong.
2018-11-08 07:47:17 -05:00
Matt Apperson 03d1597903
[BeatsCM] Allow for config based override of default user role (#25364)
* Allow for config based override of default user role

* [beats-cm] convert xpack.beats.defaultUserRole to array of roles

* [beats-cm] keep this context in #checkLicense
2018-11-08 07:12:54 -05:00
Lukas Olson aa61b7a88f Fix Canvas autocomplete to suggest all functions (#25351)
* fix: getFunctionDefinitions to load after the registry has been populated

* fix: use getBrowserRegistries instead of registry itself
2018-11-07 19:01:49 -07:00
Spencer 43ee991b20
[canvas/gulp-scripts] replace script path in argv with gulp path (#25352) 2018-11-07 15:08:43 -08:00
Jen Huang 29d8a9de92
[Rollups] Fix day of month only showing ordinals (#25322)
* Fix day of month only showing ordinals
2018-11-07 13:47:02 -08:00
joe fleming bb5af6c4b2 fix: restore canvas error dialog 2018-11-07 14:38:32 -07:00
Matt Apperson f113682c26
[BeatsCM] text update (#25297)
* progress

* add missing text changes

* text tweak

* Update x-pack/plugins/beats_management/public/components/table/assignment_schema.ts
2018-11-07 16:33:56 -05:00
Spencer cfaa1783c3
[canvas] move yarn scripts to node scripts (#25258)
* [canvas] move yarn scripts to node scripts

* [canvas/eslint] allow scripts to access devDeps

* [canvas/eslint] remove packageDir override

* [x-pack] move babel-register to deps for canvas

* [canvas] rename scripts from : to _

* [canvas] update readme with correct script paths

* [canvas] remove yarn.lock file

* Remove redundant require
2018-11-07 10:53:06 -08:00
Joe Fleming ac625701f2
Fix: Canvas babel build (#25184)
Closes https://github.com/elastic/kibana/issues/25154

Canvas' threading code uses babel-register for the runtime, much like Kibana does, so we can execute code that uses newer syntax (mostly es modules at this point...). The default configuration of babel-register ignores `node_modules`, and since x-pack is built into `node_modules`, this worked fine in dev mode and not at all in the build.

There was also an issue where Kibana's build step removes all bablerc files, which meant Canvas' threaded runtime also wasn't getting any of the settings.

This PR pulls in the configuration from Kibana, which has an exception for transpiling x-pack code, and allows the runtime to operate correctly in the build.

Huge thanks to @jbudz for helping me sort out the issue!

@spalger ~~know more about babel than I do, if we can just use `@kbn/babel-preset/node_preset` directly instead, that seems less likely to break going forward. I meant to try it but ran out of time yesterday to make another build.~~ Works! PR updated.
2018-11-07 09:56:30 -07:00
Pete Harverson 60bb092aba
[ML] Fixes file data viz file size check and format as bytes (#25295)
* [ML] Fixes file data viz file size check and format as bytes

* [ML] Fix typo in file size error callout
2018-11-07 16:49:05 +00:00
Spencer 5f9337e35b [canvas] unify eslint config in .eslintrc.js (#25260)
Simply remove the remaining eslint config files from canvas and merge with other canvas related overrides in `.eslintrc.js`
2018-11-07 09:33:39 -07:00
Jen Huang f3cf074ffa
Move call to standard index pattern fields for wildcard from client to server (#25270) 2018-11-07 08:24:59 -08:00
Brandon Kobel 8431348bc0
Updating request to ^2.88 (#25236) 2018-11-07 08:12:26 -08:00