Commit graph

3028 commits

Author SHA1 Message Date
Greg Thompson c59875573e
Upgrade EUI to 12.1.0 (#39601)
* eui@12.1.0

* jest regenerator-runtime babel-polyfill

* TS Toast -> EuiGlobalToastListToast

* EuiBadge

* EuiCopy

* snapshot updates

* simplify toast interface usage

* misc review cleanup

* remove eui core-js resolution
2019-06-26 11:00:27 -05:00
Dmitry Lemeshko 3ded411527
Update functional tests to run faster and pass locally (#39557)
* [shakespeare] adjust verification to pass in both headless/head runs

* [services/visualizations/pie_chart] speedup tests with timeout decrease

* [services/dashboard/expectations] speedup tests with timeout decrease
2019-06-26 07:41:35 +03:00
Spencer ec26ffbdd1
[percy] define snapshot width to match current client width (#39631) 2019-06-25 21:37:14 -07:00
Stacey Gammon 1bcf7ceb8e
Dashboard embeddable container plugin (#38974)
* Dashboard embeddable plugin

* comment out duplicate scss styles

* review: conform closer to NP standards

* export/import from index file in folder
2019-06-25 08:43:28 -04:00
Daniil Suleiman d39c6b267d
[Vis: Default editor] Euificate schema editors (#39331)
* EUIficate schema editors

* Fix types

* Fix comments and functional tests

* Add percentage to a tooltip

* Remove extra ts-ignore
2019-06-25 12:12:02 +03:00
Nathan Reese e779ae71be
[Maps] do not allow save when map has unsaved layer changes (#39529)
* [Maps] do not allow save when map has unsaved layer changes

* fix jest test

* refactor add layer panel functional tests
2019-06-24 19:39:03 -06:00
liza-mae 16b8f3bef7
Add rendering of canvas images and update percy agent package (#39456)
* Add rendering of canvas images and update percy agent package

* Spencer's fix for eslint issues

* restore canvas elements after taking snapshot

* copy over all styles from canvas to image stand-in

* percy snapshots only run in chrome, so they can use modern js features

* only run visual regression suites

* add stub maps test

* fix arg order

* use more modern syntax that totally works in chrome

* typo

* fix ftr test timeout when using --inspect-brk

* Revert "add stub maps test"

This reverts commit 32dc965adb.
2019-06-24 08:34:59 -06:00
Daniil Suleiman 3d4a3ce673
[Vis: Default editor] Euificate vis-editor-agg-add (#38898)
* Euificate vis-editor-agg-add

* Rebuild UI and fix functional tests

* Make all labels sentence case

* Disable schema instead of filter

* Calculate disabled only in open state
2019-06-21 16:01:22 +03:00
Court Ewing 2d171c92f5 Fix path references into and out of x-pack/legacy 2019-06-20 13:34:48 -04:00
Vadim Dalecky 071a52d4d4
No common registry implementation (#39168)
* refactor: 💡 use new Map() in Embeddables

* refactor: 💡 remove IndexPatternCreationConfigRegistry

* refactor: 💡 make indexPatternTypes registry semantic

* fix: 🐛 fix TypeScript errors
2019-06-19 22:21:15 +02:00
Matthias Wilhelm 99c1597e93
Fix broken "View single document" link of Discover using Elasticsearch 8.x (#39178)
* Remove type from ES request at doc view
- in ES 7.0 types were deprecated
- in ES 8.0 types were removed
Using ES 8.0 'View single document' of Discover didn't work

* Remove type from 'View single document' link

* Add functional test
2019-06-19 21:14:52 +02:00
Stacey Gammon 184111d971
Migrate old style queries stored in filters array (#38945)
* Migrate old query filters

* Null check instead of undefined for more completeness

* remove unnecessary undefined check

* Use good defaults, not undefined, for brand new dashboards.

* fix: typescript errors

* be explicit instead of matchinline snapshot.

* default to Kuery when there is no query given
2019-06-19 11:09:25 -04:00
Tim Roes b550bfd810
Rename Visual Builder to TSVB (#39125)
* Rename Visual Builder to TSVB

* A, B, C, D, E, F, G ...
2019-06-18 13:30:11 +02:00
Rudolf Meijering 260d907f90
[Core] Move Saved objects files to core (#38771)
* Move src/legacy/server/saved_objects -> src/core/server/saved_objects

* Fix SavedObject import references after moving files to core

* First pass at SavedObjects api docs

* Expose and import all saved object types through core/server

* Don't expose SavedObjectsManagement from core and fix imports

* Improve typings for SavedObject error helpers

* Fix type errors after master merge

* Fix SavedObjectErrorHelpers tests
2019-06-18 13:10:23 +02:00
Dmitry Lemeshko 581755098a
[firefox] Run functional tests in dedicated CI groups (#38416)
* 2 jobs for Firefox tests

* review fixes

* make sh files executable

* add check reporter
2019-06-17 19:31:41 +03:00
Spencer 9c1bdb9298
[percy] only execute percy setup when necessary (#39043) 2019-06-16 07:23:36 -07:00
Greg Thompson c22b706b25
Upgrade EUI to 11.3.2 (#38262)
* eui 11.3.1

* EuiSuperSelect TS updates

* EuiColorPicker updates

* EuiBadge updates

* a11y updates

* i18n service updates

* remove unused translations

* move valueOfSelected logic to private method

* update EuiColorPicker class name

* Updated canvas storyshots

* i18n fixes; maps color selection position

* i18n snapshot updates

* update canvas storyshots

* snapshot updates

* 11.3.2

* maps colorpicker

* space avatar colorpicker
2019-06-14 15:45:35 -05:00
liza-mae 0003a32f56
[WIP] FTR Percy changes (#36897)
* [ftr/percy] integrate percy with functional test runner

* execute ftr within `percy exec`

* share PERCY_BIN and GRUNT_BIN vars in setup

* [license] whitelist `(Unlicense OR Apache-2.0)`

* [percy] include pr/parallel info in env

* echo the actual variable value

* destructure required modules

* [ci] calculate percy env in a script

* remove outdated eslint overrides

* oops, nonce should be the same for each build

* take snapshots in context tests

* add percy snapshots to some dashboard tests

* account for extra execution of PERCY_BIN

* remove usage of percy service

* rename service to `visualTesting`

* write a simple test

* switch left-over percy test to visualTesting

* set log level for percy agent

* trigger ci

* try using the system chrome install instead of downloading one

* fix export definition

* Don't skip chromium download

* Add Spencer's fix to point to chrome installation

* Attempting to split tests into own ci job and test files

* Renumber job

* Add tag to decorations file

* Try new files with existing CI job

* Try again to create a new CI job

* Fix eslint problem with space

* eslint updates

* fix console test

* make test names unique

* Update ci group names

* Try old name again

* save

* add separate visual_regression ci job

* add visual regression ci job

* add new job to jobs.yml

* update path to take_percy_snapshot script

* use fixed percy job total

* fix common services import

* move visual_create_and_add_embeddables to visual_regression project

* finish moving create_and_add_embeddables

* add x-pack visual regression job

* migrate dashboard_snapshots tests to visual_regression

* remove references to removed test files

* restore some unnecessary changes

* reimplement the login page tests

* yarn.lock update

* fix test

* remove old CI_GROUP 100 block

* update failed_tests trap

* reduce yarn.lock changes

* disable debug logging

* disable visual-regression tests for now, we can enable them in specific prs
2019-06-14 10:35:23 -06:00
Tim Roes 5f3f1966cb
Rename Visual Builder to Timeseries (#38777) 2019-06-13 14:44:53 +02:00
Vitali Haradkou a15b15aae3
[TSVB] [AT] time series formatter duration (#38256)
* Add new tests for the duration formatter
2019-06-13 15:31:26 +03:00
Maryia Lapata 386619e577
[Vis: Default editor] EUIficate Sub agg control (#37979)
* EUIficate metric agg control

* Fix translation errors

* Display agg error underneath the last bucket agg form control

* Update functional test

* Update error message

* Update parent_pipeline_agg_controller.js

* Fix validation when metricAgg is invalid

* Show error message when a filed is selected

* Delete _terms_helper.tsx

* Remove extra empty line

* Update parent_pipeline_agg_helper.js

* Update selector for test
2019-06-13 11:18:26 +03:00
Philipp B 722559129d
[Accessibility] A <label> for time bucket size selector on discover (#38396)
* Replace <span> with a <label for=''> used as a label for a dropdown <select>
* Change CSS selector for functional test
2019-06-12 21:46:10 +03:00
Vitali Haradkou a7abe1999d
[TSVB] [AT] new markdown tests (#38545)
* perform new markdown tests
2019-06-12 14:25:36 +03:00
Matthias Wilhelm a33201cf39
Support for date_nanos type timestamps in context view (#38023)
* Reenable context view for time_nanos based index patterns
2019-06-11 15:04:54 +02:00
Spencer 3bc5595ce3
[testFailureReporting] only run on master/version jobs (#38497) 2019-06-10 07:04:32 -07:00
Frank Hassanabad fdd4621601
[SIEM] Add build step to find cyclic deps in SIEM project (#38329)
## Summary

* Adds a build step to find cyclic deps and error out in the SIEM project when found as part of a build step.

* Fixes typescript files that have cycles with their constants and types.

You run this like so:

```
cd kibana/x-pack/plugins/siem
node scripts/check_circular_deps.js
```

And get this message:
<img width="846" alt="Screen Shot 2019-06-07 at 11 22 24 AM" src="https://user-images.githubusercontent.com/1151048/59121970-b629f680-8916-11e9-8683-326a881c4725.png">

Or you will get an error with a listing of deps that need to be updated which have cycles in them.

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~
~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~
- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
2019-06-07 14:40:06 -06:00
Stacey Gammon bd484391fc
Embeddable API V2 (#37510)
* Embeddable API plugin

* Expose new embeddableActions uiExport endpoint

* Add missing getInjectedUIAppVars to Server type

* Add jest tests

* Most basic skeleton of the sample plugin to see if it still kills ci

* strip even more out to see if it passes ci

* It passed, put back init fn

* add back in a uiExport to see if that is what is killing ci

* Passed again, add back embeddableActions uiExports and require kibana line

* Add everything back but the sass import

* Found two bugs with customize panel title action, added jest test coverage and fixes

* Functionally test embeddable explorer plugin

* Addressing review feedback part 1

* Simplify action context menu - remove support for nested actions/child panels, which was never exposed anyway.

* More review feedback

* Spread out orders to let developers inject their own actions in the middle.

* Remove check for overwriting ApplyFilterAction

* use createRegistry for EmbeddableFactoryRegistry

* Add comment for getInheritedInput

* Use kbn-es-query Filter types

* Fix missed file after createRegistry switch over for EmbeddableFactoryRegistry

* Use delete instead of setting to undefined

* upgrade EUI to match kibana version

* Add getIsContainer on base embeddable class

* Run functional tests of sample plugin

* move all tests classes outside __test__ and inside test_samples folder so not to potentially create issues with mocha

* fix: 🐛 remove unused imports

* fix: 🐛 set to undefined explicitly

* chore: refactored getRoot functionality

* fix: refactor miss from folder rename __test__ -> test_samples

* fix: add eui switch to let the user indicate “hide this title” to improve ux.

* fix: customize panel flout test

* Try to fix issue with multiple rxjs bundles I hit before.

See https://github.com/ReactiveX/rxjs/issues/3828

* Use an rxjs polyfill to work around the issue of multiple rxjs bundles

* chore: change customize panel flyout to modal post design feedback

* capitalize Reset

* fix: type errors in customize panel modal

* fix: remove extra line added to prevent EUICallout overflow from spilling over panel edges

The bug this was intended to fix doesn’t appear yet because dashboard isn’t using this, and it causes other issues, so for now, just remove.

* Clean up some classes and SASS

* Inline styles needed to get the containers to take up the full height of the app.

* Use the same old style of error messaging in panels

* chore: add untilEmbeddableLoaded tests, expose on interface, and use in embeddable_child_panel

* Remove unused styles, add padding

* Verify trigger Context containers an array of Filters for apply filter action

* Remove panel.embeddableId param, use panel.explicitInput.id instead

* Check `isCompatible` as well as the type guard needed for typescript.

* executeTriggerActions should account for getHref

* Remove unnecessary check for context being defined

* use npStart instead of getNewPlatform

* Conform to latest NP changes

* Use new np_mocks in all the tests

* Address review feedback on rxjs polyfill
2019-06-07 13:30:55 -04:00
Nathan Reese 8dbfbddb53
Fetch options for input control child select boxes (#38148) 2019-06-07 06:57:56 -06:00
Spencer acba93a38c
[jest] don't be crazy, run with caching enabled (#38332) 2019-06-06 16:56:52 -07:00
spalger c655a11ece [ci] disable firefox tests 2019-06-06 14:26:53 -07:00
Matthias Wilhelm e11277fc89
Undo setting of $scope.refreshInterval at dashboard (#37175)
* Add test for passing on dashboard url params to timepicker values

* Revert unnecessary setting of $scope.refreshInterval

refreshInterval is set at $scope.model, no need to set it directly at $scope like in discover and vis
2019-06-06 19:33:03 +02:00
Josh Dover 02ff1adcbd
[new-platform] Simplify the frontend integration with the legacy platform (#37734) 2019-06-05 17:46:03 -05:00
Luke Elmers 1e016a62a9
Fix broken filtering on metric visualizations. (#38029) 2019-06-05 11:48:30 -06:00
Vitali Haradkou a7dedb63d5
[TSVB] [AT] implement new test cases for time series formatter (#37506)
* implement new test cases for time series formatter
2019-06-05 18:13:04 +03:00
Dmitry Lemeshko 27e219e20b
functional tests/firefox wait for loading after page refresh (#38082) 2019-06-05 16:52:48 +02:00
Lee Drengenberg e9938a54b1
Add 1/2 second sleep to fix test (#37903) 2019-06-04 11:16:52 -05:00
Chandler Prall 86fea48875
Upgrade EUI to 11.0.1; support dynamic import() calls in UI code + eui (#36316)
* Upgrade EUI to 11.0.1; support dynamic import() calls in UI code + eui

* update snaps

* Clicking on the svg itself once loaded

* updated snaps

* update icon in snapshots

* Fix snapshot
2019-06-03 12:01:01 -04:00
Dmitry Lemeshko f82e92a077 FTR: add support for Firefox browser (#32509)
* skip and adjust functional tests for Firefox

* downgrade geckodriver to 0.22.0

* [ftr] add firefox specific config file

* remove hard coded firefox adjustments

* remove firefox specific screenshot directory

* run functional tests in firefox in x-pack

* pass the logger to readConfigFile()

* rename local var

* skip xpack firefox config

* run xpack firefox functional tests in separate command

* update report name for XPack firefox results

* adjust viz shared item test

* skip shared item test

* [test/feature_controls] increase timeout to 20 sec & use forceLogout

* FF timeout on TSVB, refresh page on failure for url navigation

* [feature_controls/visualize_security] increase timeout to 20 sec

* skip dev_tools_spaces tests on FF

* run all groups 3 times

* skip more func tests

* skip more tests

* skip all feature controls tests for Firefox

* revert back changes in feature controls tests

* rename xpack report for chrome

* skip tile map for FF, wait for render before saving

* Revert "run all groups 3 times"

This reverts commit 12b4f69627.

* revert refresh on login

* apply feedback
2019-05-31 15:49:18 -07:00
Maryia Lapata 64e36abef0
Import func tests "_metric_chart" to ciGroup10 (#36623)
* Add metric_chart tests to job and update them

* Revert removing file

* Remove obsolete test

* Move _metric_chart.js to ciGroup10
2019-05-31 14:03:29 +03:00
Vitali Haradkou b969fbf3ca
revert missing test for TSVB Time Series (#37336) 2019-05-31 14:01:06 +03:00
Matthias Wilhelm 953930be49
Support Elasticsearch date_nanos datatype (#36111)
* Add date_nanos to date type in kibana field types
* date_nanos by default is formatted by "Date Nanos" format
* Format computed date_nanos field to strict_date_time to prevent rounding
* Hide Discover - "View surrounding documents" btn for date_nanos (will be subject of another PR)
* Append number of nano seconds to formatted timeField
* Add new key dateNanosFormat to UI setting defaults
2019-05-31 08:52:32 +02:00
Nick Peihl 1ea3431c69
Skip tilemap zoom warning functional test on cloud (#37570) 2019-05-30 16:37:58 -07:00
Justin Kambic 109d10fcf5
Add a function to the time picker page object to set a commonly-used timespan option. (#37374) 2019-05-30 07:33:56 -04:00
Tim Roes 58ef3a3c49 Add addError function to toastNotifications (#32187) 2019-05-29 13:24:35 -05:00
Daniil Suleiman a2542d35c6 [Vis: Default editor] EUIficate order_agg param editor (#36984)
* EUIficate order_agg param editor

* Update browser tests

* Add types

* Update enzyme version in x-pack

* Fix functional tests

* Changes due to comments

* Update_terms_helper.tsx

Co-Authored-By: Maryia Lapata <mary.lopato@gmail.com>

* Fix code review comments

* Update yarn.lock
2019-05-29 15:53:06 +03:00
Vitali Haradkou 8007c3fb1b
[TSVB] [AT] TimeSeries refactor (#36987)
* move tsvb timeseries tests into new file
2019-05-29 12:10:27 +03:00
Daniil Suleiman 38b95b1cc1 [Vis: Default editor] EUIficate top_sort param editor (#36629)
* EUIficate top_sort param editor

* Set field if only one available

* Remove unused translations

* Fix functional tests

* Fix browser tests

* Rewrite functional test for combo_box field select

* Remove unused translations

* Update label
2019-05-29 11:43:47 +03:00
Dmitry Lemeshko ddc24b8255
[visualize/_shared_item] skip test due to #37130 (#37131) 2019-05-28 22:51:07 +02:00
Dmitry Lemeshko 7c556ca337
TSVB: functional test for color picker, preview disable and series clone (#37186)
* [visualize/_tsvb_chart] test for color picker, changing  preview and cloning series
2019-05-28 14:44:46 +02:00
Vitali Haradkou ed29276c5f
[TSVB] markdown variables(revert fix) (#34067)
* add markdown tests
2019-05-28 00:26:28 +03:00