Søren Louv-Jansen
16f05143ef
[APM] Fix missing transaction message ( #25353 ) ( #25411 )
2018-11-08 22:13:30 +01:00
Chandler Prall
0f56480e11
Update EUI to v5.0.0 ( #25316 ) ( #25408 )
...
* update EUI to v5.0.0
* update snapshots
* revert snapshot change
* revert snapshot change (2)
2018-11-08 12:54:52 -07:00
Spencer
8d139d508e
Fix File Upload fatal ( #25361 ) ( #25393 )
...
## Summary (fixes #25342 )
There is a fatal when using the File Upload control in the image upload control. While the fatal appears to originate within the File Upload control, it is actually [coming from](https://github.com/clintandrewhall/kibana/blob/file-upload/x-pack/plugins/canvas/public/components/loading/index.js#L15 ) `Loading`, which attempts to use `react-redux` to change the `backgroundColor` of the loading indicator based on the page.
I couldn't find an instance where we use this Loading indicator outside of a redux context, so I've opted to simply use the control directly. @rashidkpc agreed this would be a good fix for the moment.
In addition, I fixed a props error coming from the data-url field that made it read-only, so I fixed that, too, as well as a formatting issue with the Set button.
## Test Plan
Added a `setTimeout` call to simulate load. Toggled between data url and literal URL.
- Before
- After
- Fixed Warning
### Checklist
Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.
- [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility )
- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md )
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation ) was added for features that require explanation or tutorials~~
~~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility ) were updated or added to match the most common scenarios~~
~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist )~~
### For maintainers
~~- [] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process )~~
~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process )~~
2018-11-08 08:30:19 -08:00
Joe Fleming
57cffd692e
Fix: Asset preservation ( #25359 )
...
* fix: proptype error
* fix: correct proptype checking
* fix: add assets placeholder to initial state
* chore: add history formatting function
* fix: load workpad assets when ids change
this causes the correct assets to be used
2018-11-08 09:21:10 -07:00
Carlos Pérez-Aradros Herce
28ef6ae534
Relax hosts validation in Beats central management ( #25376 )
...
Current regexp was disallowing schema part of the URL (https://), so
https hosts couldn't be configured.
I opted for fully relaxing the reg exp here, as Beat will check it
anyway, and report errors in case it's wrong.
2018-11-08 07:47:56 -05:00
Matt Apperson
01d3fd648d
[BeatsCM] Allow for config based override of default user role ( #25364 )
...
* Allow for config based override of default user role
* [beats-cm] convert xpack.beats.defaultUserRole to array of roles
* [beats-cm] keep this context in #checkLicense
2018-11-08 07:22:35 -05:00
Matt Apperson
c49c8aa07c
[BeatsCM] text update ( #25297 )
...
* progress
* add missing text changes
* text tweak
* Update x-pack/plugins/beats_management/public/components/table/assignment_schema.ts
2018-11-08 07:22:08 -05:00
Lukas Olson
88daed8c81
Fix Canvas autocomplete to suggest all functions ( #25351 )
...
* fix: getFunctionDefinitions to load after the registry has been populated
* fix: use getBrowserRegistries instead of registry itself
2018-11-07 19:03:11 -07:00
Spencer
f754cf8019
[6.x] [canvas/gulp-scripts] replace script path in argv with gulp path ( #25352 ) ( #25354 )
...
Backports the following commits to 6.x:
- [canvas/gulp-scripts] replace script path in argv with gulp path (#25352 )
2018-11-07 16:40:29 -08:00
Jen Huang
0b449f34d8
[Rollups] Fix day of month only showing ordinals ( #25322 ) ( #25343 )
...
* Fix day of month only showing ordinals
2018-11-07 16:17:05 -08:00
joe fleming
9b10b04cb6
fix: restore canvas error dialog
2018-11-07 14:39:12 -07:00
Pete Harverson
785477219a
[ML] Fixes file data viz file size check and format as bytes ( #25295 ) ( #25311 )
...
* [ML] Fixes file data viz file size check and format as bytes
* [ML] Fix typo in file size error callout
2018-11-07 20:24:02 +00:00
Walter Rafelsberger
d42fb3cacf
[ML] Restore missing job timepicker modal. ( #25288 ) ( #25302 )
...
* [ML] Restore missing job timepicker modal.
* [ML] Added a karma/mocha test to verify dependencies are loaded correctly for new_job_controller.
* [ML] Use consistent import style.
2018-11-07 21:21:30 +01:00
Spencer
90588acbae
[canvas] move yarn scripts to node scripts ( #25258 )
...
* [canvas] move yarn scripts to node scripts
* [canvas/eslint] allow scripts to access devDeps
* [canvas/eslint] remove packageDir override
* [x-pack] move babel-register to deps for canvas
* [canvas] rename scripts from : to _
* [canvas] update readme with correct script paths
* [canvas] remove yarn.lock file
* Remove redundant require
(cherry picked from commit cfaa1783c3
2018-11-07 10:55:09 -08:00
Jen Huang
e161dc724b
Move call to standard index pattern fields for wildcard from client to server ( #25270 ) ( #25308 )
2018-11-07 10:44:13 -08:00
Brandon Kobel
6ef31d3531
Updating request to ^2.88 ( #25236 ) ( #25304 )
2018-11-07 10:25:34 -08:00
Felix Stürmer
ca57dcf2b7
[Infra UI] Remove duplicate "Overview" in detail page title ( #25283 ) ( #25292 )
...
This removes the duplicate word "Overview" from the title of the container details page.
2018-11-07 18:18:51 +01:00
Joe Fleming
113891cca1
Fix: Canvas babel build ( #25184 )
...
Closes https://github.com/elastic/kibana/issues/25154
Canvas' threading code uses babel-register for the runtime, much like Kibana does, so we can execute code that uses newer syntax (mostly es modules at this point...). The default configuration of babel-register ignores `node_modules`, and since x-pack is built into `node_modules`, this worked fine in dev mode and not at all in the build.
There was also an issue where Kibana's build step removes all bablerc files, which meant Canvas' threaded runtime also wasn't getting any of the settings.
This PR pulls in the configuration from Kibana, which has an exception for transpiling x-pack code, and allows the runtime to operate correctly in the build.
Huge thanks to @jbudz for helping me sort out the issue!
@spalger ~~know more about babel than I do, if we can just use `@kbn/babel-preset/node_preset` directly instead, that seems less likely to break going forward. I meant to try it but ran out of time yesterday to make another build.~~ Works! PR updated.
2018-11-07 10:00:25 -07:00
Spencer
313b908944
[canvas] unify eslint config in .eslintrc.js ( #25260 )
...
Simply remove the remaining eslint config files from canvas and merge with other canvas related overrides in `.eslintrc.js`
2018-11-07 09:34:09 -07:00
Chris Roberson
7d511a7cea
Use the newly added remote_cluster field for ccr ( #25248 ) ( #25293 )
2018-11-07 11:15:55 -05:00
Jason Rhodes
51b1f4febf
Fixes bug with rison decode on Kibana links ( #25214 ) ( #25284 )
...
* Fixes bug with rison decode vs encode
* Adds and updates tests for kibana link component
2018-11-07 11:01:28 -05:00
Felix Stürmer
f55b39d195
[6.x] [Infra UI] Work around IE11 flexbox alignment problems ( #25224 ) ( #25281 )
...
Backports the following commits to 6.x:
- [Infra UI] Work around IE11 flexbox alignment problems (#25224 )
2018-11-07 14:51:16 +01:00
Søren Louv-Jansen
9b04e556be
[APM] Additional clock skew fixes ( #25097 ) ( #25277 )
...
* Refactor service colors
* Calculate duration from full waterfall
* Ensure timeline label is not truncated
* Adjust child if it starts after parent has ended
* Add mark for traceRootDuration instead of xMax
* Fix tests
2018-11-07 13:32:34 +01:00
Pete Harverson
0863fb3bdf
[ML] Add user privilege check to Jobs List group selector control ( #25225 ) ( #25276 )
2018-11-07 11:38:48 +00:00
Melissa Alvarez
d68e9a7b8e
[ML] JobList search bar: Show useful error on invalid query ( #25153 ) ( #25227 )
...
* Show error on invalid query
* Additional undefined check for query
* Cleanup undefined check
2018-11-07 10:00:17 +00:00
Søren Louv-Jansen
b2e62cd9a4
[APM] Show message for missing transaction sample ( #25141 ) ( #25261 )
2018-11-07 10:27:51 +01:00
Tiago Costa
86dd567e60
Make canvas common lib ready for dependencies static analysis ( #24756 ) ( #25273 )
...
* refact(NA): make canvas common lib ready for static analysis.
* refact(NA): change export named to export all on canvas commmon lib datatable.
* tes(NA): fix isValid http url function name.
* refact(NA): rename parse to parseDataUrl
2018-11-07 05:24:52 +00:00
Matt Apperson
73ce55289b
[BeatsCM] error on issues dont disable ( #25149 )
...
* display error messages for failed checks vs disableing plugin
* update text
* change order of check
* tweak security check
* re-disable on invalid license, update text
* update text
* tweaks
* tweak text
2018-11-06 21:34:07 -05:00
Clint Andrew Hall
36de9e8325
Adding beta marker ( #25256 ) ( #25265 )
2018-11-06 19:45:11 -06:00
Matt Apperson
755b92b5ef
dont allow tag creation if id is invalid ( #25133 )
2018-11-06 19:01:02 -05:00
Matt Apperson
301dfae91e
[BeatsCM] Rework table controls to use the pattern now found in the rest of Kibana ( #25131 )
...
* Rework table controls to use the pattern now found in the rest of Kibana
* Fix TS errors
* better fix TS issue
* uncomment code removed for testing
2018-11-06 19:00:51 -05:00
Walter Rafelsberger
9ff005ae8f
[ML] Removes deprecated angularjs based jobs list and related code. ( #25216 ) ( #25240 )
2018-11-06 22:28:14 +01:00
Felix Stürmer
0879295771
[6.x] [Infra UI] Normalizing CPU usage for waffle map ( #25123 ) ( #25210 )
...
Backports the following commits to 6.x:
- [Infra UI] Normalizing CPU usage for waffle map (#25123 )
2018-11-06 17:39:26 +01:00
Leanid Shutau
33cbfd76b5
[I18n] Migrate enzyme helpers to TypeScript ( #25108 ) ( #25205 )
...
* [I18n] Migrate enzyme helpers to TypeScript
* Migrate src enzyme helpers
* Remove eslint comments
2018-11-06 18:09:13 +03:00
Chris Roberson
44c3dfed61
Unskip the mappings test ( #24667 ) ( #25162 )
2018-11-06 09:30:38 -05:00
Chris Roberson
a426b09ca6
Re-enable these tests ( #24600 ) ( #25161 )
2018-11-06 09:30:15 -05:00
Melissa Alvarez
4eedf46895
[ML] MultiMetric/Population Job creation: Allow model plot enablement via checkbox ( #24914 ) ( #25202 )
...
* Add route/api-mapping for validateCardinality
* Create directive for enableModelPlot checkbox
* Ensure model plot enabled prior to cardinality check
* Add callout when cardinality high
* ensure correct cardinality success check
* Population wizard: add enableModelPlot checkbox
* Update with suggested changes from review
* Remove warning when invalid. Add tests.
* Ensure checkbox updated on uncheck
2018-11-06 14:15:37 +00:00
Felix Stürmer
ccc6b25a36
[Infra UI] Add beta badge with tooltip to the header ( #25113 ) ( #25196 )
...
In accordance with #25008 , this adds a "Beta" badge with a corresponding tooltip to the header.
2018-11-06 14:51:20 +01:00
Stacey Gammon
74a7731814
Disable animations for xpack functional tests too ( #25148 ) ( #25169 )
2018-11-06 08:17:12 -05:00
Shaunak Kashyap
61ba781748
Infra UI: Fixing minor typo ( #25005 )
...
Resolves #25007 .
Outbound traffic is generally denoted with TX, abbreviation for Transmit, instead of RX, abbreviation of Receive.
This PR fixes this minor typo.
2018-11-06 01:28:02 -08:00
Nathan Reese
6228f6ce1b
fix typos ( #25176 ) ( #25181 )
2018-11-05 18:00:11 -07:00
CJ Cenizal
655b09c685
[Rollups] Improve Rollup Job Wizard error handling ( #25092 ) ( #25171 )
...
* Consistently format errors with showApiWarning and showApiError helpers.
* Use fatalError for unexpected errors.
* Localize errors.
* Surface error in Job List when the jobs can't be loaded.
2018-11-05 16:49:04 -08:00
Felix Stürmer
650b64c562
[6.x] [Infra UI] Rename InfraOps to Infrastructure ( #25135 ) ( #25159 )
...
Backports the following commits to 6.x:
- [Infra UI] Rename InfraOps to Infrastructure (#25135 )
2018-11-05 23:04:49 +01:00
Walter Rafelsberger
4f4f88b0a1
[ML] Fixes typo. ( #25130 ) ( #25144 )
...
Fixes "Dectector" Typo.
2018-11-05 22:41:30 +01:00
Ryan Keairns
a108e3a829
Security - convert LESS to SASS ( #25079 ) ( #25158 )
...
* convert security less to sass
* remove unused less styles from xpack_main
2018-11-05 15:39:12 -06:00
pavel06081991
656940ae80
Feature/translate license management ( #24341 ) ( #25119 )
...
Translate license management
2018-11-05 23:07:42 +03:00
Jen Huang
deda6739e2
Prepend ES endpoint with slash ( #25073 ) ( #25082 )
2018-11-05 09:45:08 -08:00
Chris Roberson
979ea04277
Ensure we probably init the route for the ccr page ( #25050 ) ( #25128 )
2018-11-05 12:24:31 -05:00
Stacey Gammon
4668af30e5
Added sort order to share menu options. ( #25058 ) ( #25096 )
...
* Added sort order to share menu options.
Sorts ascending on sort order first then ascending on name. Any menu item without a sort order gets set to zero.
* Moved new sortOrder property from node_modules
* Had to rerun the snapshot for the share menu with the sortOrder in it.
2018-11-05 11:28:37 -05:00
Matt Apperson
b1a344cdb1
[BeatsCM] Change Index template name ( #24835 )
...
* [BeatsCM] Change Index template name
* Update x-pack/plugins/beats_management/server/management_server.ts
* Update x-pack/plugins/beats_management/server/lib/adapters/database/__tests__/test_contract.ts
2018-11-05 10:07:17 -05:00
