* Initial copy/paste of components
Changes for pre-commit hooks were:
- Linting
- Lodash imports
- Fixed warnings for `jsx-a11y/mouse-events-have-key-events` with stubbed onFocus and onBlue events with FIXME comments
* Add server routes
* Remove reference to shared lib
This one-liner appears only once in ent-search so adding it here in the logic file`
* Fix paths
* Add types and fix TypeScript issues
* Replace FlashMessages with global component
* More explicit Result type
* Remove routes/http in favor of HttpLogic
* Fix server routes
`urlFieldIsLinkable` was missing and `detailFields` can either be an object or an array of objects
* Add base styles
These were ported from ent-search. Decided to use spacers where some global styles were missing.
* Kibana prefers underscores in URLs
Was only going to do display-settings and result-details but decided to YOLO all of them
* Use rxjs instead of jquery for eventBus.
* Fix comments
* Removed one check because property is private.
* Resolve comments
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Prevent error from being displayed when choosing action throttle
Addresses #83230.
This field was previously refactored to not require a callback prop;
simply updating the value via `field.setValue` is sufficient for our use
case.
This fix removes the errant code that assumed a callback prop, since
such a prop does not exist on the underlying component.
* Fix UI bug on ML Jobs popover
EUI links now add an SVG if they're an external link; our use of a div
was causing that to wrap. Since the div was only needed to change the
text size, a refactor makes this all work.
* Exercise editing of tags in E2E tests
These tests were recently skipped due to their improper teardown. Since
that's a broader issue across most of these tests, I'm reopening these
so we can get the coverage provided here for the time being.
* useFetchIndex defaults to isLoading: false
In the case where no index pattern is provided, the hook exits without
doing any work but does not update the loading state; this had the
downstream effect of disabling a form field that was waiting for this
hook to stop loading.
* Move situational action into ... the situation
We only need to clear existing tags in the case where we're editing the
rule (and it has tags); in all other cases, this method fails. This
fixes things by moving that conditional logic (clear the tags field)
into the test that needs it (editing custom rules).
* chore(NA): rebalance cigroup1 into cigroup5
* chore(NA): get list api integration into cigropup1 again
* chore(NA): get apm integration basic into cigropup1 again
* chore(NA): move back apm_api_integration trial tests into ciGroup1
* chore(NA): move exception operators data types into ciGroup1 again
* chore(NA): move detection engine api security and spaces back into ciGroup1
* chore(NA): add a new xpack cigroup11
* chore(NA): correctly create 11 xpack ci groups
* chore(NA): try to balance ciGroup2 and 8
* chore(NA): reset number of xpack parallel worker builds to 10
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Deprecating `kibana.index` setting
* Using ela.st service so this can be changed to the blog in the future
* Adding unit tests
* Revising deprecation log message
* Changing the deprecation log message to be more consistent with others
* Updating kibana.index docs also
* Using rename deprecation as the "standard" for the deprecation messages
* /s/'/`
* Trying to flesh out new tree route
* Working on the descendants query
* Almost working descendants
* Possible solution for aggs
* Working aggregations extraction
* Working on the ancestry array for descendants
* Making changes to the unique id for ancestr
* Implementing ancestry funcitonality
* Deleting the multiple edges
* Fleshing out the descendants loop for levels
* Writing tests for ancestors and descendants
* Fixing type errors and writing more tests
* Renaming validation variable and deprecating old tree routes
* Renaming tree integration test file
* Adding some integration tests
* Fixing ancestry to handle multiple nodes in the request and writing more tests
* Adding more tests
* Renaming new tree to handler file
* Renaming new tree directory
* Adding more unit tests
* Using doc value fields and working on types
* Adding comments and more tests
* Fixing timestamp test issue
* Adding more comments
* Fixing timestamp test issue take 2
* Adding id, parent, and name fields to the top level response
* Fixing generator start and end time generation
* Adding more comments
* Revert "Fixing generator start and end time generation"
This reverts commit 9e9abf68a6.
* Adding test for time
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Fix broken routes
Didn’t have a way to test these when created
* Get context from global state
No need to do this in 2 places now. There was a race condition where the default logic value for `isOrganization` was set to `false` We don’t need a useEffect call here because the value is synchronous and has no side effects. Calling the method directly fixes the race condition.
* Add the ‘path’ to the logic files for easier debugging
* Add SourceSubNav component
* Flip routes to match new convention
It was decided by Product that instead of keying off of `/org` to determine context, that we would now flip it where we key of provate with `/p`.
This means that /sources is now organization where before it was personal
* Convert routers to use children instead of props
This aligns with App Search and allows for easier telemtry and breadcrumbs
* Add breadcrumbs and basic telemetry
* Add in and refactor subnavigation
As a part of this commit, the approach for rendering subnavs was refactored to align with App Search.
There was a bug where some components weren’t rendering properly because the SourceLogic and GroupsLogic files were never unmounting. The reason for this is the subnav components use their respective logic files to get the IDs needed for rendering the subnav links. That is, SourceSubNav would call SourceLogic to get the ID to render the links and would stay rendered for the duration of the user’s time in the app. The result is that users would leave the source details page and navigate to add a new source and the logic file would never reset to a loading state and the UI would break.
The fix was to borrow from the pattern App Search uses and pass the subnavs as props. Because App Search only uses a single engines subnav, they only needed one prop. We use multiple props for each subnav.
Also, the subnav should not be rendered on the root routes (/sources, /p/sources, and /groups) so conditionals were added to only render the subnavs when not on those root routes.
* Add FlashMessages
* Fix some failed tests
Missed this in first commit
* Update SourceIcon to use EuiIcon
Before this change, the legacy styles were not ported over. This gives a uniform size for both wrapped and unwrapped icons. The icons are a bit smaller on the add source page but Eui has lowered it’s largest size ‘xxl’ and we would need to write manual overrides. IMO the change is not significant enough to override.
* Fix broken icons
* Replace legacy div with component
The eui.css file in ent-search is no longer up to date with current EUI and this was broken. The best fix was to use the component that renders as expected
* Add base styles for Sources
More in a future PR but this makes the majority of things look correct.
* Cleanup
Fix some type errors and rename constants
* Couple more failing tests
We have multiple `Layouts` now with the new subnavs
* Fix prepare routes
Like the first commit, missed these when porting over routes with no UI.
* Clean up the desgin of the source connect screen
The columns were way off in Kibana
* Remove ORG_PATH const
No longer needed since ‘/org’ is gone
* bump version to 4.1.1-rc
* fix code to run kbn bootstrap
* fix errors
* DO NOT MERGE. mute errors and ping teams to fix them
* Address EuiSelectableProps configuration in discover sidebar
* use explicit type for EuiSelectable
* update to ts v4.1.2
* fix ts error in EuiSelectable
* update docs
* update prettier with ts version support
* Revert "update prettier with ts version support"
This reverts commit 3de48db3ec.
* address another new problem
Co-authored-by: Chandler Prall <chandler.prall@gmail.com>
* move streams to kbn/std
* import streams from kbn/std
* fix styles
* remove unused shareWeakReplay
* move from kbn/std to kbn/utils
* import from subfolder since test mocks FS module and not compatible with kbn/utils
* remove new line at the end of json file
* [Vega] Tutorials should be updated to include new inspector
* Revert unnecessary changes
* Add titles to the screenshots. paste the link to vega inspector and remove experimental caption
* Update some captions
* Update docs/user/dashboard/tutorials.asciidoc
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
