Commit graph

10164 commits

Author SHA1 Message Date
James Gowdy
18df677da7
[ML] Fixing file import, module creation and results viewing permission checks (#72825)
* [ML] Fixing file import and module creation permission checks

* correcting searches on results index

* fixing test

* removing unnecessary index

* updating apidoc

* fixing test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-23 16:11:15 +01:00
Tyler Smalley
15ccdc36ca [test] Skips flaky uptime test
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2020-07-23 07:50:30 -07:00
Madison Caldwell
7280b69e99
[Security Solution][Exceptions] Preserve rule exceptions when updating rule (#72977)
* Send exceptions_list with rule edit

* Handle exceptions list checkbox

* whoops

* Don't lose data when associating with endpoint list

* syntax

* Filter out the endpoint lists when disassociating

* Add tests

* Refactor per PR suggestions

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-23 09:54:08 -04:00
Vadim Dalecky
304445f007
fix: 🐛 don't show actions if Discover app is disabled (#73017)
* fix: 🐛 don't show actions if Discover app is disabled

* style: collapse ifs
2020-07-23 15:27:06 +02:00
Nicolas Chaulet
06f142d586
[Ingest Manager] Fix config rollout move to limit concurrent config change instead of config per second (#72931) 2020-07-23 08:06:16 -04:00
Cauê Marcondes
9a22b95b97
[APM] Custom link: Removing async check for callAPMApi (#73004)
* removing async check for callAPMApi

* removing async check for callAPMApi
2020-07-23 13:46:09 +02:00
Kevin Logan
5f6b9353e7
[SECURITY_SOLUTION] update Elastic Endpoint text in rules (#72613) 2020-07-23 07:38:27 -04:00
Vadim Dalecky
8f8cba5013
fix: 🐛 don't show action in dashboard_only mode (#73010) 2020-07-23 13:36:52 +02:00
Pierre Gayvallet
2178a14519
Migrate status page app to core (#72017)
* move http.anonymousPaths.register('/status'); logic into core, remove status_page plugin

* move status_page to core & migrate lib

* migrate the status_app components to TS/KP APIs

* update rendering snapshots

* use import type syntax

* moves `/status` server-side route to core

* fix route registration

* update generated file

* change statusPage i18n prefix

* (temporary) try to restore legacy plugin to check behavior

* add some FTR tests

* do not import whole lodash

* update snapshots

* review comments

* improve / clean component unit tests

* change url for legacy status app

* set status app as chromeless

* fix FTR test due to chromeless app

* fix typings

* add unit test for CoreApp /status registration
2020-07-23 12:15:03 +02:00
James Gowdy
d4a362018a
[ML] Fixing link to index management from file data visualizer (#72863) 2020-07-23 09:23:19 +01:00
Joe Reuter
5cdd0801b2
fix bug (#72809) 2020-07-23 09:35:36 +02:00
Sonja Krause-Harder
8b4c4c0abc
Show step number instead of incomplete step. (#72866) 2020-07-23 08:45:01 +02:00
Pedro Jaramillo
ac8cdf34ba
Fix bug where user can't add an exception when "close alert" is checked (#72919)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-22 20:22:51 -04:00
Chris Roberson
bacf9f2aba
[Monitoring] Fix issues displaying alerts (#72891)
* Fix issues displaying alerts

* Fix type issues

* More support for multiple alerts

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-22 19:28:00 -04:00
John Schulz
1343643696
[Ingest Manager] Add more Fleet concurrency tests #71744 (#72338)
* Refactor to make more testable. Add more tests.

* Remove ts-ignores. Add comment re: testing limitation

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-22 18:24:04 -04:00
Yara Tercero
f7a1679395
[Security Solution][Exceptions] - Update UI exceptions builder nested logic (#72490)
## Summary

This PR is meant to update the exception builder logic to handle nested fields. If you're unfamiliar with nested fields, you can read up more on it [here](https://www.elastic.co/guide/en/elasticsearch/reference/current/nested.html) and [here](https://github.com/elastic/kibana/issues/44554). It also does a bit of cleanup, so though it may look like a lot of changes, parts of it were just moving some things around.
2020-07-22 18:21:40 -04:00
Melissa Alvarez
1889c68c6b
[ML] API integration tests for UPDATE data frame analytics endpoint (#72710)
* add df analytics update api integration tests

* remove unnecessary commented code

* remove unused constant

* fetch job to check it was updated correctly
2020-07-22 16:50:18 -04:00
Justin Kambic
24ebe0a189
[Uptime] Fix accessibility issue in Uptime app nav links (#72926)
* Fix accessibility issue in Uptime app nav links.

* Refresh outdated snapshot.

* Introduce aria-label for hidden content.
2020-07-22 16:49:21 -04:00
Nathan Reese
8b27b1e83c
[Maps] fix removing global filter from layer can cause app to start thrashing (#72763) 2020-07-22 13:37:18 -06:00
Nathan Reese
80da1c6a54
[Maps] fix blended layer aggregation error when using composite aggregation (#72759) 2020-07-22 13:26:22 -06:00
spalger
d39e97d972 fix unexpected arguments to unload command 2020-07-22 12:20:11 -07:00
Frank Hassanabad
4fa660c672
Limits the upload size of lists to 9 meg size (#72898)
## Summary

Limits the lists to 9 megs upload size so we don't blow up smaller Kibana installs. Users can change/override this using the switch of `xpack.lists.maxImportPayloadBytes` like so:

```
xpack.lists.maxImportPayloadBytes: 40000000
```

That will increase the amount of bytes that can pushed through REST endpoints from 9 megs to something like 40 megs if the end users want to increase the size of their lists and have enough memory in Kibana.

Metrics and suggestions from testing looks like:

```ts
Kibana with 1 gig of memory can upload ~10 megs of a list before possible out of memory issue
Kibana with 2 gig of memory can upload ~20 megs of a list before possible out of memory issue
```  

Things can vary depending on the speed of the uploads of the lists where faster connections to Kibana but slower connections from Kibana to Elastic Search can influence the numbers.  

### Checklist

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
2020-07-22 13:19:27 -06:00
Justin Kambic
ffd8ed2d97
[Uptime] Refactor overview filters reducer to use createAction (#69187)
* Refactor overview filters to use createAction.

* Refresh snapshot.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-22 15:18:08 -04:00
spalger
2ef9657ecf fix SIEM es_archiver command syntax 2020-07-22 12:07:49 -07:00
Quynh Nguyen
c9c2158682
[ML] Fix deleting DFA not showing index pattern check (#72904) 2020-07-22 14:05:53 -05:00
Søren Louv-Jansen
7e126bfab6
Update jobs_list.tsx (#72797) 2020-07-22 20:17:31 +02:00
Larry Gregory
39aa1f19c9
Unskipping DLS/FLS tests (#72858) 2020-07-22 13:57:27 -04:00
Nicolas Chaulet
90c8406dcf
[Ingest Manager] Use docker registry for fleet api integration tests (#72621) 2020-07-22 13:29:44 -04:00
Dmitry Lemeshko
8f7ccc752b
[QA] [Code Coverage] Fix maps functional test (#72848)
* [test/functional] wait for rendering in maps test

* move waitForRender in openNewMap
2020-07-22 19:28:39 +02:00
Melissa Alvarez
0dfc8a9dcd
[ML] DF Analytics creation wizard: default destination index to job id (#72758)
* wip: add destIndexSameAsId checkbox

* update functional tests

* switch default to false when cloned job

* move switch below description
2020-07-22 13:14:03 -04:00
Jen Huang
83b5c8401b
[Ingest Manager] Handle long agent config & package config names gracefully (#72761)
* Truncate name in package config table

* Clean up enrollment keys table

* Clean up other tables

* Handle long agent config names with no spaces

* Handle long agent config descriptions without spaces

* Fix types, add tooltips/aria labels

* Fix types again
2020-07-22 10:11:30 -07:00
Patrick Mueller
f974c242ab
[eventLog] fix FT event log tests to filter on event actions (#72445)
resolves https://github.com/elastic/kibana/issues/72207

The `getEventLog()` should have been filtering the events returned by the
actions requested in the parameters, but wasn't.

Also un-skips the describe block that was skipped because of this failure.
2020-07-22 13:06:28 -04:00
Devin W. Hurley
f9cbc99a93
[SIEM] [Detections] Fixes filtering with large value lists to use "ands" between lists (#72304)
* wip - comment and sample json for exceptions

* promise.all for OR-ing exception items and quick-start script

* logging, added/updated json sample scripts, fixed  missing await on filter with lists

* WIP

* bug fix where two lists when 'anded' together were not filtering down result set

* undo changes from testing

* fix changes to example json and fixes missed conflict with master

* update log message and fix type errors

* change log statement and add unit test for when exception items without a value list are passed in to the filter function

* fix failing test

* update expect on one test and adds a new test to ensure anding of value lists when appearing in different exception items

* update test after rebasing with master

* properly ands exception item entries together with proper test cases

* fix test (log statement tests - need to come up with a better way to cover these)

* cleans up json examples

* rename test and use 'every' in lieu of 'some' when determining if the filter logic should execute
2020-07-22 12:39:29 -04:00
Felix Stürmer
ba55ca9e86
[Logs UI] Add missing ML capabilities checks (#72606)
This adds several missing Machine Learning capabilities checks to the UI to make sure the user doesn't run into downstream errors resulting from the lack of permissions. It also updates the messages of the permission prompt screens to refer to the new Kibana Machine Learning permissions instead of the old built-in roles.
2020-07-22 18:32:17 +02:00
Andrew Cholakian
0ed55f2e18
[Uptime] Stop indexing saved object fields. (#72787)
Fixes https://github.com/elastic/kibana/issues/72782
2020-07-22 11:16:51 -05:00
spalger
b12d19f8fa skip flaky suite (#72803) 2020-07-22 09:11:20 -07:00
Larry Gregory
b23b3d9024
De-duplicates dashboard feature definition (#72834) 2020-07-22 12:03:45 -04:00
spalger
8305d9f775 skip flaky suite (#72864) 2020-07-22 08:48:20 -07:00
Jonathan Buttner
b346253a7a
Adding aggregations for endpoint events (#72705) 2020-07-22 11:32:55 -04:00
Mike Côté
9374a42a5c
Allow larger difference in index threshold jest test (#72506)
* Allow large difference in index threshold jest test

* Fix variable name
2020-07-22 11:27:38 -04:00
Marshall Main
0bab77147a
[Security Solution] Change query builder so N exception items don't nest N levels deep (#72224)
* Change query builder so N exceptions don't nest N levels deep

* Fix tests and clarify function naming

* Rename evaluateEntry to buildEntry for consistency

* Remove duplicate tests

* more test fixes

* Add tests with multiple exception list items

* Chunk exception list items in query to support up to 1000000

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-22 11:04:44 -04:00
Nathan Reese
fa11161fd0
[Maps] fix zoom in/zoom out buttons are not visible in dark mode (#72699)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-22 09:04:18 -06:00
Spencer
9655c87564
[kbn/es-archiver] move to a package (#72318)
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-22 08:02:39 -07:00
Steph Milovic
f6bc61f222
[Security solution] [Timeline] Bug fix for "Collapse event" button (#72552) 2020-07-22 08:03:41 -06:00
Gidi Meir Morris
4abe864f10
Adds Role Based Access-Control to the Alerting & Action plugins based on Kibana Feature Controls (#67157)
This PR adds _Role Based Access-Control_ to the Alerting framework & Actions feature using  Kibana Feature Controls, addressing most of the Meta issue: https://github.com/elastic/kibana/issues/43994

This also closes https://github.com/elastic/kibana/issues/62438

This PR includes the following:

1. Adds `alerting` specific Security Actions (not to be confused with Alerting Actions) to the `security` plugin which allows us to assign alerting specific privileges to users of other plugins using the `features` plugin.
2. Removes the security wrapper from the savedObjectsClient in AlertsClient and instead plugs in the new AlertsAuthorization which performs the privilege checks on each api call made to the AlertsClient.
3. Adds privileges in each plugin that is already using the Alerting Framework which mirror (as closely as possible) the existing api-level tag-based privileges and plugs them into the AlertsClient.
4. Adds feature granted privileges arounds Actions (by relying on Saved Object privileges under the hood) and plugs them into the ActionsClient
5. Removes the legacy api-level tag-based privilege system from both the Alerts and Action HTTP APIs
2020-07-22 14:45:57 +01:00
Chris Roberson
670520a253
[Monitoring] Revert direct shipping code (#72505)
* Backout these changes

* Fix test
2020-07-22 09:24:14 -04:00
Poff Poffenberger
82dd173b2a
Use server basepath when creating reporting jobs (#72722)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-22 08:05:53 -05:00
Cauê Marcondes
4dcf719edb
Adding api test for transaction_groups /breakdown and /avg_duration_by_browser (#72623)
* adding api test for transaction_groups /breakdown and /avg_duration_by_browser

* adding filter by transaction name

* adding filter by transaction name

* addressing pr comments

* fixing TS issue

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-22 15:01:29 +02:00
Gidi Meir Morris
a41633d8c5
[Task Manager] Addresses flaky test introduced by buffered store (#72815)
Removed unused functionality which we weren't using anyway and was causing some flaky behaviour.
2020-07-22 13:39:33 +01:00
Cauê Marcondes
cb0405eeae
[Observability] filter "hasData" api by processor event (#72810)
* filtering hasdata by processor event

* adding api test
2020-07-22 14:30:52 +02:00