Commit graph

242 commits

Author SHA1 Message Date
Tyler Smalley
1bcf848e46
Sets min_doc_count=0 for parent histogram of derivative aggregation (#61390)
From the docs: The specified metric must be numeric and the enclosing
histogram must have min_doc_count set to 0 (default for histogram
aggregations).

https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-pipeline-derivative-aggregation.html#search-aggregations-pipeline-derivative-aggregation

This is now enforced, and currently failing the promotion of the current
Elasticsearch build

Related to https://github.com/elastic/kibana/pull/61387

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2020-03-25 22:22:04 -07:00
Chris Roberson
6c8cc4cf74
Fix issue with no logstash monitoring data in the top end of the time series (#61273) 2020-03-25 13:35:45 -04:00
Chris Roberson
223f774c3f
[Monitoring] Update /api/stats to use core.metrics (#60974)
* Align api/stats with the monitoring logic for kibana ops metrics

* Align collectors

* Add in locale to kibana_settings

* More tweaks

* PR feedback

* PR feedback
2020-03-24 15:53:43 -04:00
Larry Gregory
b82cc6ed4a
Support for sub-feature privileges (#60563)
* initial server-side support for sub-feature privileges (#57507)

* initial server-side support for sub-feature privileges

* start addressing PR feedback

* renaming interfaces

* move privilege id collision check to security plugin

* additional testing

* change featurePrivilegeIterator import location

* fix link assertions following rebase from master

* Initial UI support for sub-feature privileges (#59198)

* Initial UI support for sub-feature privileges

* Address PR feedback

* display deleted spaces correctly in the privilege summary

* additional testing

* update snapshot

* Enables sub-feature privileges for gold+ licenses (#59750)

* enables sub-feature privileges for gold+ licenses

* Address PR feedback

* address platform review feedback
2020-03-24 11:12:49 -04:00
Alejandro Fernández Haro
452193fdba
[Telemetry] Server-side Migration to NP (#60485)
* [Telemetry] Migration to NP

* Telemetry management advanced settings section + fix import paths + dropped support for injectVars

* Fix i18nrc paths for telemetry

* Move ui_metric mappings to NP registerType

* Fixed minor test tweaks

* Add README docs (#60443)

* Add missing translation

* Update the telemetryService config only when authenticated

* start method is not a promise anymore

* Fix mocha tests

* No need to JSON.stringify the API responses

* Catch handleOldSettings as we used to do

* Deal with the forbidden use case in the optIn API

* No need to provide the plugin name in the logger.get(). It is automatically scoped + one missing CallCluster vs. APICaller type replacement

* Add empty start method in README.md to show differences with the other approach

* Telemetry collection with X-Pack README

* Docs update

* Allow monitoring collector to send its own ES client

* All collections should provide their own ES client

* PR feedback

* i18n NITs from kibana-platform feedback

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-23 18:49:38 +00:00
Chris Roberson
3a396027f6
[Monitoring] Migrate server to NP (#56675)
* First pass

* First pass

* Add new routes

* Getting closer

* Remove legacy server code, and other fixes

* Register the plugin with xpack

* Pass a legacy client to telemetry

* Suport callWithInternalUser

* Remove this

* More NP work

* Fix some tests

* Fix broken test

* Move over new telemetry changes, and fix other issues

* Fix TODO item

* Reuse the same schema as elasticsearch module

* Use a singular config definition here

* Disable this for now

* Use the right method

* Use custom config again

* Tweak the config to make this optional

* Remove these

* Remove these unnecessary files

* Fix jest test

* Fix some linting issues

* Fix type issue

* Fix localization issues

* Use the elasticsearch config

* Remove todos

* Fix this check

* Move kibana alerting over

* PR feedback

* Use new metrics core service

* Change config for xpack_api_polling_frequency_millis

* Make sure this is disabled for now

* Disable both

* Update this to the new function

* Tighten up legacy api needs

* Check for existence

* Fix jest tests

* Cleaning up the plugin definition

* Create custom type in our plugin

* Revert this change

* Fix CI issues

* Add these tests back

* Just use a different collector type

* Handle errors better

* Use custom type

* PR feedback

* Fix type issues

* PR feedback
2020-03-20 14:02:15 -04:00
Court Ewing
7ac8e4d9cc Move x-pack plugins/server/common to x-pack/legacy 2019-06-20 13:34:48 -04:00
Matthew Kime
80eb1e1583
d13n docTitle (#39162)
* refactor doc title so it can be used outside of angular service
2019-06-19 09:31:42 -05:00
Chris Roberson
b09e3a622f
[Monitoring] Metricbeat migration flyout and instructions (#35228)
* Initial attempt at a reactor of how this works

* Enter and exiting setup mode with migration buttons working

* Adding monitoring url step back in and some small cleanup

* Elasticsearch steps

* Add missing file

* Better organization here

* Remove this debug logic

* Clean up

* PR feedback

* Add in monospacing

* Persist monitoring url in local storage

* Rework the steps

* Change node to server, and add missing files

* Fix linting issues

* Fix api integration tests

* PR feedback

* Pass down if the product is the "primary" or not, then use that to show certain warnings in the UI (just supported for Kibana right now)

* Elasticsearch migration will work slightly differently in that all nodes must be partially migrated before we can disable internal collection

* More PR feedback

* PR feedback

* Better links

* Fix tests

* This should open in a new tab

* PR feedback

* Design and PR feedback

* Fix these tests

* PR feedback

* Remove debug

* PR feedback

* Update the import path

* Update this import path too

* PR feedback

* Fix i18n
2019-06-14 14:21:53 -04:00
Chris Roberson
b1a7bcb40a
Ensure we provide the cluster when toggling completed recoveries (#38543) 2019-06-13 12:44:29 -04:00
Chris Roberson
25802019ae
[Monitoring] Integrate logs source for Logs UI (#36929)
* Define and use an internal log ui source configuration

* Fix urls in tests

* Remove unnecessary code
2019-06-13 09:28:54 -04:00
Mike Place
6c0f83a515
Minor changes to text on Alerting in Stack Monitoring application (#38388)
* Minor changes to text.

* "Basic" is a proper name, so it should be capatalized.

* Cluster Alerts are plural.

* Fix tests to align with help text changes

* Missed one test file
2019-06-13 14:46:36 +02:00
igoristic
35a5706e16
Flooring number down to whole second (#38065) 2019-06-12 15:24:33 -04:00
Stacey Gammon
cde4fb6ed5
Small step to consolidating refresh interval types. Stop exporting from all embeddable apis. Conform to time filter one. (#38681) 2019-06-12 08:08:19 -04:00
Ahmad Bamieh
c308048f04
[Telemetry] move from xpack main (#35403)
* enabling xpack in new plugins

* move telemetry into separate new platform plugin

* remap constants

* resolved hacks issue

* remove extra dir

* js -> ts

* run linter

* fix tests

* reset kibana.yml

* reset kibana.yml

* ts types

* add telemetry translations to i18n

* use deprecated configs

* checkout config.yml

* fix test

* move telemetry from xpack_main in api_integration

* add telemetry apis

* hide banner

* remove routes/get_stats in favor of collectors/get_stats

* code review fixes
2019-06-12 13:53:48 +03:00
Peter Pisljar
8743027a07
removed Private/Provider from requestHandlers (#38522) 2019-06-11 06:33:03 +02:00
igoristic
44fc8c91d7
Issue 27126: Added a link to License Management (#37771)
* Added a link to License Management

* Added textAlign to EuiText instead
2019-06-07 16:05:33 -04:00
igoristic
01dccbfb75
Issue 28875: Using i18n instead of injectI18n (#37845)
* Using i18n instead of injectI18n

* Update x-pack/plugins/monitoring/public/components/apm/instance/status.js

Co-Authored-By: Ahmad Bamieh <ahmadbamieh@gmail.com>

* Update x-pack/plugins/monitoring/public/components/table/table.js

Co-Authored-By: Maryia Lapata <mary.lopato@gmail.com>

* Addressed PR code review feedback
2019-06-07 16:01:56 -04:00
Josh Dover
02ff1adcbd
[new-platform] Simplify the frontend integration with the legacy platform (#37734) 2019-06-05 17:46:03 -05:00
igoristic
0a9585f137
Optimized content to be more vertical for resizing consistancy (#37120)
* Optimized content to be more vertical for resizing consistancy

* Fixed snapshots

* Feedback changes

* Update _summary_status.scss

* Fixed column order for testing
2019-06-04 19:55:57 -04:00
Chandler Prall
86fea48875
Upgrade EUI to 11.0.1; support dynamic import() calls in UI code + eui (#36316)
* Upgrade EUI to 11.0.1; support dynamic import() calls in UI code + eui

* update snaps

* Clicking on the svg itself once loaded

* updated snaps

* update icon in snapshots

* Fix snapshot
2019-06-03 12:01:01 -04:00
igoristic
b75bbd6904
Issue 33025: Fixed CPU calculation for APM (#37230)
* Using the correct property for CPU calc

* Changed the name alias to a more relevant name

* Fixed unit tests
2019-05-30 15:28:02 -04:00
Chris Roberson
34e6c906b1
[Monitoring] Used fixed_interval explicitly for date_histogram aggregations (#37023)
* Used fixed interval explicitly

* Fix tests
2019-05-24 17:28:04 -04:00
Chris Roberson
1a2ec835e8
Remove improper usage (#37099) 2019-05-24 15:36:27 -04:00
igoristic
ec1dc71c37
Typecasting the attr boolean to the correct type (#37031) 2019-05-24 11:28:39 -04:00
igoristic
6b26b9c8c6
Swapped the anchor tag with EuiLink (#37020) 2019-05-24 10:05:44 -04:00
Chris Roberson
3da94ccb0d
Once the buffer has any events, the collector is always ready (#36995) 2019-05-24 09:08:38 -04:00
igoristic
92ebb088d1
Fix sorting of Monitoring nodes on CPU, Throttle, Heap columns (#36125)
* Complete rebase

* Testing

* Retest

* Made the get method more compatible
2019-05-23 13:29:25 -04:00
igoristic
29b20724eb
Displaying the default message if invalid value (#36737) 2019-05-23 02:07:29 -04:00
igoristic
851b1f6955
Added promise with cancel with typescript support (#36293)
* Added promise with cancel

* Fixed imports

* Fixed an async unit test
2019-05-23 02:02:00 -04:00
Matthew Kime
140978d28c
Remove angular i18n service calls (#36329)
* Remove angular i18n service calls
2019-05-21 09:00:52 -05:00
Chris Roberson
c87e8811cb
[Monitoring/Telemetry] Force collectors to indicate when they are ready (#36153)
* Initial code to force collectors to indicate when they are ready

* Add and fix tests

* Remove debug

* Add ready check in api call

* Fix prettier complaints

* Return 503 if not all collectors are ready

* PR feedback

* Add retry logic for  usage collection in the reporting tests

* Fix incorrect boomify usage

* Fix more issues with the tests

* Just add debug I guess

* More debug

* Try and handle this exception

* Try and make the tests more defensive and remove console logs

* Retry logic here too

* Debug for the reporting tests failure

* I don't like this, but lets see if it works

* Move the retry logic into the collector set directly

* Add support for this new collector

* Localize this

* This shouldn't be static on the class, but rather static for the entire runtime
2019-05-20 13:03:24 -04:00
Josh Dover
3dacef2901
Move Nav APIs to new platform (#34490)
This moves the core Nav APIs from `ui/chrome` into the `ChromeService` in the new platform.

- `ChromeStart` now exposes a sub-service for reading and making limited updates to navlinks. These are powered by apps registered with the `ApplicationService` and filtered by UI Capabilities before being exposed by the `ChromeService`.
- The `header-global-nav` directive now consumes navlinks from the new platform.
- The `lastSubUrl` feature utilized by legacy apps has been refactored and will remain in `ui/chrome`. This feature utilizes the limited fields that `ChromeService` exposes to updates by outside code.

This change is the main blocker to moving the Chrome UI to the new platform. This will be necessary to enable the new platform to control top-level routing.
2019-05-10 09:03:10 -05:00
igoristic
ed3ee40998
Added missing statusComponent (#36241) 2019-05-09 12:17:16 -04:00
igoristic
a0bdb538ec
Unmounting react components when a directive is destroyed (#35834) 2019-05-06 17:18:41 -04:00
igoristic
3d3e071c6e
Fixed default timestamp sort and added tests (#35640)
* Fixed default timestamp sort and added tests

* Removed duplicate functionality

* Fixed unit tests

* Removed debug code

* Update helpers.js
2019-05-03 11:32:28 -04:00
igoristic
1973b80940
Added the missing reactNodeId to the controller (#35822) 2019-05-03 09:56:19 -04:00
Chandler Prall
d449ff4e3f
Update EUI 10.1.0 -> 10.3.1 (#35970) 2019-05-02 12:27:36 -06:00
Ahmad Bamieh
27de17abbb
Monitoring telemetry collection interval (#34609)
* Only collect usage data once a day from kibana monitoring

* isUsageCollector

* bulk uploader tests

* linting

* condition filter

* checkout yarn.lock from master

* update mappings for functional tests

* debugging for refactoring

* support legacy mappings

* self code review

* isUsageCollector

* fix mock

* live coding session with pickypg

* self code review

* Update x-pack/plugins/xpack_main/server/lib/telemetry/monitoring/get_high_level_stats.js

Co-Authored-By: Bamieh <ahmadbamieh@gmail.com>

* update mappings
2019-04-27 03:38:05 +03:00
igoristic
d405d0c96b
Added uiCapabilities.logs check (#35562)
* Added uiCapabilities.logs check

* Fixed unit tests
2019-04-25 14:17:26 -04:00
Larry Gregory
e18bfc1497
Feature Controls - Allow telemetry to be toggled with advancedSettings feature privilege (#35250)
* Allow telemetry to be toggled with feature privileges
2019-04-25 11:43:42 -04:00
igoristic
b2dfcc4ba1
Showing node name instead of uid in breadcrumbs (#35553) 2019-04-24 19:48:44 -04:00
igoristic
172a91d794
Added sorting to all columns (#35410)
* Added sorting to all columns

* Added sorting to table wrapper instead

* Fixed condition

* Removed default sorting value

* Removed a log statement

* Converted beats directive into a controller
2019-04-23 15:52:26 -04:00
Chandler Prall
dc9b299903
Update EUI to v10.1.0 (#35402) 2019-04-22 09:41:51 -06:00
Greg Thompson
e05098dd27
Upgrade EUI to v10.0.1 (#35112)
* eui@10.0.0; tsconfig update

* limit key lookups to strings

* Search Profiler hightlight details flyout classes

* bump

* snapshot updates

* x-pack snapshot updates
2019-04-17 09:16:34 -05:00
Chris Roberson
33f1123dbe
[Monitoring] Metricbeat migration status logic (#34871)
* Initial logic and tests for this

* Improve test

* Some cleanup and adding api integration tests

* Add comments

* Account for no documents returned

* Add detection logic and tests

* Ensure these fields are optional

* Update detection logic

* Beats, logstash and apm can only possibly exist

* Fix some issues with APM

* Fix tests

* Small updates based on needing to also include the filebeat index

* Fix issue with the reduce

* PR feedback

* More PR feedback

* Add additional tests

* Add additional tests
2019-04-17 09:17:37 -04:00
igoristic
8fde4df6ce
Allow empty and null key types (#35016) 2019-04-16 03:14:41 -07:00
Shaunak Kashyap
b53fa5b3f6
Fix field name for "Events Ingested" in Logstash Node List page (#35122)
* Fix field name

* Updating jest snapshots

* s/events_ingested/events_out/g
2019-04-15 18:44:07 -07:00
Chris Roberson
5253c62b86
Update jest snapshot (#35082) 2019-04-15 11:11:00 -04:00
Chris Roberson
6a3aadc9f2
[Monitoring] Introducing Logs UI (#31275)
* Initial implementation

* More logs UI work

* Remove unnecessary code

* Add support to build a logs url based on the cluster and/or node uuid

* Deep link directly

* Update link

* Use CCS to access remote filebeat data

* Fix existing tests

* Add log specific api integration tests

* Localization

* Adding more localization

* Adding unit tests for logs ui

* Client side unit tests, configuration for log fetch count, adding visual callout for why we can't detect logs

* Remove debug

* Fix localization issue

* Update tests

* PR feedback

* Update import

* Format the count to avoid a huge string of numbers

* Use @timestamp instead

* Handle scenario where the time period is not right but the type exists

* Update jest tests

* Update api tests

* Text changes

* Add periods

* Update tests
2019-04-15 08:45:47 -04:00