Commit graph

3816 commits

Author SHA1 Message Date
Alexey Antonov
21b9b36c94
[Vega] add functional tests for Vega visualization (#74097)
* [Vega] [Inspector] add functional tests for Request tab

* add some tests for Vega Debug tab

* add clipboard permissions for webdriver

* add smoke tests for data grid

* fix CI

* add some tests for vega expression funcitons

* change order

* Update _vega_chart.ts

* Rename dagta_grid.ts to data_grid.ts

* Update index.ts

* Update data_grid.ts

* stabilize tests

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-12 14:05:23 +03:00
Stratoula Kalafateli
78689b7ecd
[Functional Tests] Adds a wait time between setting the index pattern and the time field on TSVB (#74736)
* Adds a wait time between setting the index pattern and the time field on tsvb

* Char by char to set indexpattern to give more time to load the time field

* Add more time

* uncomment commented lines
2020-08-11 20:17:08 +03:00
Alejandro Fernández Haro
0c16ca4649
[Telemetry][API Integration] size_in_bytes to be a number (#74664) 2020-08-11 10:44:32 +01:00
Constance
697cd6412e
[Enterprise Search] Update the browser/document title on plugin navigation (#74392)
* Rename kibana_breadcrumbs to kibana_chrome

- in anticipation of upcoming refactor where SetPageChrome now handles document title as well as Kibana breadcrumbs
+ cleanup exports

* Add generate_title helpers

- will be used by new set_chrome helper

* Add setDocTitle context + behavior to set_chrome

+ refactor set_chrome.test.tsx:
  - add title tests
  - add SetWorkplaceSearchChrome test to increase coverage
  - clean up inner/outer call in favor of simpler mocks/imports
  - simplify isRoot tests

* Update plugins to set product titles
- on mount but before render

* Copy feedback - change pipe separator to hyphen

- to match ' - Elastic'

* Add functional tests confirming that document titles updated
2020-08-10 10:37:12 -07:00
Matthew Kime
cccf15a3f4
Index pattern field class refactor (#73180)
- Better distinction and relationship between IndexPatternField and its spec
- IndexPatternField class is no longer defined via object mutation
- Reduction of dependencies
- UI code moved into Index Pattern class (will be removed in next ticket)
- IndexPattern field list was previously composed of IndexPatternFields or specs, now only IndexPatternFields
- IndexPattern field list was previously redefined when loading fields, now only its contents are replaced.
2020-08-10 07:35:12 -05:00
Devon Thomson
dad5c72a0c
[Fix] Lose OriginatingApp Connection on Save After Create new (#74420)
Fixed typo created in #72725 which caused the originatingApp connection not to be lost properly after Create new
2020-08-06 13:24:54 -04:00
Anton Dosov
3064c6eceb
Improve state sync error handling (#74264)
Fixes #71461 regression since 7.7

New state syncing utils didn't properly handle errors,
Errors happening during URL parsing or writing wasn't handled, so state syncing could stop or in worth case blow out. (see #71461)

There are not much scenarios where missing proper error handling could really impact users, except the one described in #71461:

Kibana users state:storeInSessionStorage
Users often intuitively share hashed dashboard urls directly
When someone opens those urls - there is a blank screen with warning
In 7.6 - dashboard would still load with default state.
Since 7.7 these still could be achieved by removing query params for URL, but it is not obvious for regular users.

This PR makes sure that behaviour is similar to one we had before 7.7.


Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-06 15:34:32 +02:00
Mikhail Shustov
88c0631344
Update @typescript-eslint to ensure compatibility with TypeScript v3.9 (#74091)
* bump @typescript-eslint deps

* update rules

* fix errors in pacakges

* fix src/

* fix x-pack

* fix test

* fix typings

* fix examples

* allow _ as prefix and suffix

* roll back prefix and suffix changes

* add eslint-plugin-eslint-comments

* report unused rules

* remove unused eslint comments from tests

* remove unused eslint comments 2nd pass

* remove unused eslint comments from src/

* remove unused comments in x-pack

* use no-script-url and no-unsanitized/property for ts files

* remove unused eslint comments

* eui/href-or-on-click removed when not complained

* no import/* rules for ts files

* cleanup

* remove the unused eslint-disable

* rollback unnecessary changes

* allow underscore prefix & sufix in type name

* update docs

* fix type error in enterprise search plugin mocks

* rename platform hack __coreProvider --> _coreProvider

* rollback space removal in src/core/public/legacy/legacy_service.test.ts

* fix naming convention in APM
2020-08-05 17:32:19 +02:00
Brian Seeders
ea4d36f713
[CI] Fix xpack kibana build dir in xpack visual regression script 2020-08-04 15:27:04 -04:00
Brian Seeders
0ca8e99a9f
[CI] Add pipeline task queue framework and merge workers into one (#71268) 2020-08-04 13:13:51 -04:00
Marco Liberati
c78da24708
[ Functional Tests ] TVSB charts flaky tests on index pattern switch fix (#74110)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-04 14:44:16 +02:00
Matthias Wilhelm
10f8beae8e
[Discover] Context unskip date nanos functional tests (#73781)
* Use _source value of timestamp for search_after since ES allows this now

* Unskip functional tests

* Remove unused convertIsoToNanosAsStr
2020-07-31 11:52:00 +02:00
Matthias Wilhelm
39cca0e55d
[Discover] Improve saveSearch functional test handling (#73626)
* Check for submit button to be disabled, before submitting the form to prevent occasional flakiness
2020-07-31 06:52:36 +02:00
Mikhail Shustov
585d58c202
[KP] Expose new es client (#73651)
* mark legacy ES client types as deprecated

* expose es client to plugins and update mocks

* ElasticSearchClientMock --> ElasticsearchClientMock

* expose es client mocks

* expose es client via RequestHandlerContext

* convert test/plugin_functional/config into ts

* convert top_nav test into ts

* add an integration test for the es client

* update comments to refer to the new es client

* fix import paths. do not use extensions

temp

* update docs

* fix other refs

* add test for a custom client

* fix context

* add test for scoped client

* update docs
2020-07-30 19:12:37 +02:00
Daniil Suleiman
6fc193ceb9
Fix visualize a field through discover app (#73652)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-30 16:36:13 +03:00
Mikhail Shustov
896e87a7ce
check that pathname has been updated. ignore other parts (#73689)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-30 08:51:56 +02:00
spalger
c102c4fe18 skip failing suite (#58815) 2020-07-29 14:41:22 -07:00
Matthias Wilhelm
4f8e7baa3e
Set timeRange to default to trigger the error message (#73629) 2020-07-29 16:57:34 +02:00
Liza Katz
14144156f6
[Data] Query Input String manager (#72093)
* improve test stability

* query string input manager (needed for search demo)

* docs

* dashboard

* Fix jest

* mock fix

* Allow restoring a saved query

* sync url

* Luke's fix to test

* cleanup

* lens jest tests

* docs

* use queryStringManager.getDefaultQuery
Don't sync query to global state

* Update app.test.tsx

lens mock

* jest fix

* jest

* use new api in the example

* Rename state param to query to match url state

* Apply changes to discover

* Update src/plugins/data/public/query/query_string/index.ts

Co-authored-by: Anton Dosov <dosantappdev@gmail.com>

* Improve query string state manager

* Cleanup dashboard code

* Handle refresh button

* Set initial dashboard state

* visualize state

* remove unused

* docs

* fix example

* fix jest

* fix filter app state in discover

* fix maps test

* jest

Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
Co-authored-by: Anton Dosov <dosantappdev@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-29 10:48:23 +03:00
Stratoula Kalafateli
0dbfde4f4d
[Functional Tests] Increase the timeout on getting the legend value on timeseries (#73279) 2020-07-28 17:34:40 +03:00
Marco Liberati
8c710aae3a
[ Functional test ] Increase the waiting time for the filter bar request (#73424) 2020-07-28 14:21:24 +02:00
Mikhail Shustov
c0826a3273
Fix App status flaky test (#72853)
* wait for link to be updated

* await, please!

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-28 10:37:37 +02:00
Stratoula Kalafateli
5ea28702f6
[Functional Tests] Increase the timeout when locating the tableview] (#73243) 2020-07-28 11:15:58 +03:00
Stratoula Kalafateli
a696f6c79b
[Functional Tests] Increase waitTime for timelion to fetch the results (#73255)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-28 10:29:47 +03:00
Stratoula Kalafateli
7b29ecf0b5
[Functional Tests] Fix flakiness on TSVB chart on switching index patterns test (#73238) 2020-07-28 10:29:33 +03:00
liza-mae
88aebc9fe1
Remove ca cert path for cloud testing (#73317) 2020-07-27 15:10:33 -06:00
Spencer
dd4796cfdd
Remove karma (#73126)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-07-27 11:07:58 -07:00
Tim Roes
9c2056d2ea
Remove flaky note from gauge tests (#73240) 2020-07-27 11:58:11 +02:00
Joe Reuter
6a53b0021e
Convert functional vega tests to ts and unskip tests (#72238)
* convert to ts and unskip tests

* relax tests and remove unused imports

* remove test exclusion

* remove inspector test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-27 10:45:23 +02:00
Mikhail Shustov
2a82ff9566
[KP] use new ES client in SO service (#72289)
* adapt retryCallCluster for new ES client

* review comments

* retry on 408 ResponseError

* remove legacy retry functions

* use Migrator Es client in SO migration

* update migration tests

* improve ES typings and mocks

* migrate decorate ES errors

* add repository es client

* use new es client in so repository

* update repository tests

* fix migrator integration tests

* declare _seq_no & _primary_term on get response. _source expect to be a string

* make _sourceIncludes and refresh compatible with the client

* add test for repository_es_client

* move ApiResponse to es client mocks

* TEMP: handle wait_for as true for deleteByNamespace

* add tests for migration_es_client

* TEMP: skip test for deleteByNamespace refresh

* pass ignore as transport option in mget

* log both es client and response errors

* fix update method test failures

* update deleteByNamespace refresh settings

es doesn't support 'refresh: wait_for' for `updateByQuery` endpoint

* update repository tests. we do not allow customising wait_for

* do not delegate retry logic to es client

* fix type errors after master merged

* fix repository tests

* fix security solutions code

SO doesn't throw Error with status code anymore. Always use SO error helpers

* switch error conditions to use SO error helpers

* cleanup

* address comments about mocks

* use isResponseError helper

* address comments

* fix type errors

Co-authored-by: pgayvallet <pierre.gayvallet@elastic.co>
2020-07-25 11:59:56 +02:00
Matthew Kime
5a1972b834
Index patterns on alias - reenable functional tests (#71802)
* reenable test
* nav to management
2020-07-23 17:46:26 -05:00
Marta Bondyra
f4bc846a03
unskip test to make sure if it passes (#73014)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-23 20:38:45 +02:00
Devon Thomson
0103cd3424
[Fix] Lose OriginatingApp Connection on Save As (#72725)
Reset originatingApp in lens and visualize when return to dashboard on saving is false
2020-07-23 12:21:31 -04:00
Daniil Suleiman
2d9eaf013b
Fix view saved search through a visualization (#73040) 2020-07-23 18:00:52 +03:00
Matthew Kime
2cf37a5326
Don't skip index pattern creation test (#73032) 2020-07-23 09:34:56 -05:00
Stratoula Kalafateli
1ee3cdb03d
[Functional Tests] Unskip tsvb timeseries test (#73011)
* [Functional Tests] Unskip tsvb timeseries test

* Add retry to dropdown selection when element is not found to headless mode
2020-07-23 17:00:16 +03:00
Pierre Gayvallet
2178a14519
Migrate status page app to core (#72017)
* move http.anonymousPaths.register('/status'); logic into core, remove status_page plugin

* move status_page to core & migrate lib

* migrate the status_app components to TS/KP APIs

* update rendering snapshots

* use import type syntax

* moves `/status` server-side route to core

* fix route registration

* update generated file

* change statusPage i18n prefix

* (temporary) try to restore legacy plugin to check behavior

* add some FTR tests

* do not import whole lodash

* update snapshots

* review comments

* improve / clean component unit tests

* change url for legacy status app

* set status app as chromeless

* fix FTR test due to chromeless app

* fix typings

* add unit test for CoreApp /status registration
2020-07-23 12:15:03 +02:00
Marco Liberati
6befacfc19
Fix Firefox TSVB flaky test with switch index patterns (#72882) 2020-07-23 10:40:21 +02:00
Lee Drengenberg
e9ec039e8e
un-revert login_page change for SAML (#72892) 2020-07-22 14:00:57 -05:00
Matthias Wilhelm
0a3170ffa0
Unskip dashboard filter bar code coverage test (#72799) 2020-07-22 17:09:38 +02:00
Spencer
9655c87564
[kbn/es-archiver] move to a package (#72318)
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-22 08:02:39 -07:00
Joe Reuter
78ea171a80
Stabilize closing toast (#72097)
* stabilize closing toast

* unskip test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-22 11:28:23 +02:00
Joe Reuter
b9aede40d6
stabilize failing test (#72086) 2020-07-22 11:26:37 +02:00
Joe Reuter
edaea1e341
Stabilize filter bar test (#72032) 2020-07-22 11:26:04 +02:00
Joe Reuter
1810dd1fe7
Unskip vislib tests (#71452) 2020-07-22 11:25:41 +02:00
Alexey Antonov
e1ffcccb96
Add inspector for VEGA (#70941)
* [WIP] Add inspector for VEGA

Closes: #31189

* view -> dataset

* cleanup

* add spec viewer

* cleanup code

* use rx to retrieve data from adapters

* Make custom inspector adapters registerable from the visType

* fix flex-box size

* cleanup

* remove visTypesWithoutInspector from visualize_embeddable

* fix PR comments

* add vega folder to sass-lint

* fix jest

* Update src/plugins/vis_type_vega/public/vega_inspector/components/data_viewer.tsx

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

* use addSignalListener

* cleanup

* add onColumnResize handler

* EuiCodeEditor -> CodeEditor

* fix type_check

* fix issue with pagination

* fix extra vertical scroll

* add area-label for EuiButtonIcon

* add area-label for EuiComboBox

* Design Commit

- Fixing up layout trying to remove any `.eui` classes and uses flex instead of percentage
- Fixing text to use `Sentence case` not `Title Case`

* Wrapper around signal viewer table

* fix Jest snapshot

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
Co-authored-by: cchaos <caroline.horn@elastic.co>
2020-07-21 14:45:51 +03:00
Matthias Wilhelm
7f6cd5148a
[Discover] Improve histogram tests (#72235) 2020-07-21 07:09:25 +02:00
Spencer
a1753ffffd
[ftr/webdriver] retry on all errors, use Rx so that timers are canceled (#72540)
* [ftr/webdriver] retry on all errors, use Rx so that timers are canceled

* throw if attemptToCreateCommand() aborts by resolving to undefined

Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-07-20 20:35:15 -07:00
spalger
5741a868bc Revert "skip flaky suite (#72146)"
This reverts commit 45a4393459.
2020-07-20 09:32:41 -07:00
Joe Reuter
96d965d4e3
Unskip dashboard embeddable rendering tests (#71824) 2020-07-20 17:55:27 +02:00