Commit graph

212 commits

Author SHA1 Message Date
Tim Sullivan
274617de59
Stats API: implement the "kibana status" spec from the Monitoring data model for stats (#20577)
* [Stats API] Set API field names per spec

* fix jest tests

* fix api integration test

* trash the original metrics collector

- constantly accumulating stats over time does not align with the existing behavior, which is to reset the stats to 0 whenever they are pulled

* move some logic out of the collector types combiner into inline

- change the signature of sourceKibana

* Make a new stats collector for the API

- to not clear the data when pulling via the api
- fetching is a read-only thing

* isolate data transforms for api data and upload data

* no static methods

* remove external in bytes

* remove the _stats prefix for kibana and reporting

* update jest test snapshot

* fix collector_types_combiner test

* fix usage api

* add test suite todo comment

* reduce some loc change

* roll back mysterious change

* reduce some more loc change

* comment correction

* reduce more loc change

* whitespace

* comment question

* fix cluster_uuid

* fix stats integration test

* fix bulk uploader test, combineTypes is no longer external

* very important comments about the current nature of stats represented and long-term goals

* add stats api tests with/without authentication

* fix more fields to match data model

* fix more tests

* fix jest test

* remove TODO

* remove sockets

* use snake_case for api field names

* restore accidental removal + copy/paste error

* sourceKibana -> getKibanaInfoForStats

* skip usage test on legacy endpoint

* fix api tests

* more comment

* stop putting a field in that used to be omitted

* fix the internal type to ID the usage data for bulk uploader

* correct the kibana usage type value, which is shown as-is in the API

* more fixes for the constants identifying collector types + test against duplicates

* add a comment on a hack, and a whitespace fix
2018-07-18 16:37:04 -07:00
James Gowdy
3c74d30bee
[ML] Adding close jobs menu item (#20927)
* [ML] Adding close jobs menu item

* changing icon

* updates based on review

* adding extra check for close failure

* adding extra guard against missing response
2018-07-18 17:47:44 +01:00
Walter Rafelsberger
651013b89c
[ML] Moves tooltip of info icon to top to avoid overlapping with corresponding form fields. (#20874) 2018-07-18 14:20:05 +02:00
CJ Cenizal
a36b87ad3e
Add SearchStrategyRegistry and defaultSearchStrategy to support existing search behavior, and integrate it with CallClient. (#20497)
* Add SearchStrategyRegistry and defaultSearchStrategy to support existing search behavior, and integrate it with CallClient.
* Move fetch param logic from CallClient into defaultSearchStrategy.
* Move defaultSearchStrategy configuration into kibana plugin via search uiExport to avoid race conditions with other plugins.
* Add call-out react directive.
* Show error in Discover if user tries to access a rollup index pattern without the right search strategy. Sentence-case copy in field chooser.
* Add tests with multiple searchStrategies and fix errors in logic.
2018-07-17 18:49:46 -07:00
Stacey Gammon
e90f652875
Bump eui (#20774)
* bump eui

* Fixed breaking `EuiPage` changes

Mainly adding `EuiPageBody`’s where there were none

* bump to 3.0, remove duplicate declaration of EuiFlyoutBody, update jest snapshots

* bump eui

* bump to 3.0, remove duplicate declaration of EuiFlyoutBody, update jest snapshots

* Update jest snapshots in xpack
2018-07-17 19:28:07 -04:00
Hendrik Muhs
a0a22cfc12
[Monitoring/ML] add number of forecasts to monitoring overview (#20758)
Add forecasts (Number of forecasts for an ml jobs) as column to the ML Jobs monitoring page. Related to: elastic/elasticsearch#31647
2018-07-17 16:41:19 +02:00
James Gowdy
492fb01f8c
[ML] Better error notifications in jobs list (#20880)
* [ML] Better error notifications in jobs list

* removing test data
2018-07-17 14:27:28 +01:00
Pete Harverson
6939f5073c
[ML] Adds page to ML Settings for viewing and editing filter lists (#20769)
* [ML] Add page to ML Settings for viewing and editing filter lists

* [ML] Edits to Filter Lists Settings page following review
2018-07-17 09:47:26 +01:00
Tim Sullivan
8ba773a498
Add Beats module and input info to Telemetry (#20648)
* fix metrics field name (stats)

* add state info

* add module name count

* use a set for the unique hosts instead of a map

* fix getting beats_state info

* fix unit test

* processBeatsStatsResults and processBeatsStateResults
2018-07-16 12:57:26 -07:00
James Gowdy
54cf83d360
[ML] Jobs list bug fixes (#20823) 2018-07-16 16:33:59 +01:00
James Gowdy
6ddc9db376
[ML] Removing hardcoded datafeed ID in jobs list (#20815) 2018-07-16 12:44:59 +01:00
Chris Roberson
276f08ccbb
[Monitoring] Capitalize the license type (#20683)
* Capitalize the license type in monitoring

* Revert "Capitalize the license type in monitoring"

This reverts commit 38ad3a516d.

* Pass in the type capitalized

* Revert "Pass in the type capitalized"

This reverts commit 6a05bb12f3.

* Capitalize type in license status directly so consumers do not need to worry about it
2018-07-13 16:24:57 -04:00
Aleh Zasypkin
34a44289aa
[Reporting] Blacklist Transfer-Encoding HTTP header for PDF report generation. (#20755) 2018-07-13 15:51:13 +03:00
Casper Hübertz
ecefab55e6
[APM] Add section titles to span detail modal (#20717)
* Adding fontSize from variables

* SectionHeader style added

* Adding section headers

Needed titling for DB statement and Stacktrace on the page

* Pluralization

* Adding fontSize variable

* Creating new header title style

* Moving title into Stacktrace container

* Updated snapshots
2018-07-13 09:15:28 +02:00
Søren Louv-Jansen
423a961a1f
Redux should update after timefilter has changed (not before) (#20719) 2018-07-12 17:17:14 +02:00
James Gowdy
da1acd0367
[ML] removing unnecessary privileges provider (#20671) 2018-07-12 09:31:23 +01:00
Walter Rafelsberger
65081ccdce
[ML] Ignore mouse events on pseudo element. (#20668)
The pseudo-element agg-type-select-wrapper::after which represents the dropdown's arrow didn't react to the click element of the dropdown itself. pointer-events: none is now added to the pseudo-elements to let the click pass through to the element intented to react on the click.
2018-07-12 09:58:32 +02:00
Søren Louv-Jansen
32505afd3d
Ensure timefilter updates correctly (#20677) 2018-07-11 21:35:45 +02:00
Walter Rafelsberger
0dbb819563
[ML] Fixes a regression bug which made the progress bar invisible. (#20618)
Fixes a regression introduced by #19794. This PR added a 5px top margin to the affected charts. The hard coded bottom margin of the progress bars wasn't adjusted accordingly so the progress bars ended up being hidden behind the actual chart. This PR fixes the problem by taking the chart's top margin into account for progressBarMarginBottom.
2018-07-11 15:21:39 +02:00
Walter Rafelsberger
8baf89006c
[ML] Migrate ml-info-icon to React/EUI. Fixes related IE11 error. (#20610)
- Migrates the ml-info-icon directive to use React/EUI. This fixes a related error in IE11.
- For now a hard-coded override is used to size the icon because EuiIconTip doesn't pass on the size attribute to the wrapped EuiIcon directive.
- The (simple) React component is kept within the directive's, because previously the directive template also wasn't in a separate file.
- Removes the unused mlJsonTooltipService angular service.
2018-07-11 14:27:30 +02:00
gchaps
739139ec45
[COPYEDIT] Management: Fixes capitalization in Extend your trial (#20627)
* [COPYEDIT] Management:  Fixes capitalization in Extend your trial

* [DOCS] Updated snapshot file
2018-07-10 13:30:50 -07:00
Søren Louv-Jansen
bf3aa086c9
[APM] Add kuery to apm ui (#19469)
* Add Kuery to APM UI

* Format bool queries

* Fix test

* Add min-height

* Updated css to vars

* Added loading indicators

* Update breadcrumbs

* Update Discover links

* Add search button

* Fix readcrumb test

* Remove debounce

* Fix “undefined” kuery

* Handle missing index pattern

* Fix race condition in data fetching

* Fix legacy url encoding

* Filter out field-suggestions starting with "span*"

* Convert KuiTable to EuiTable for service overview

* Convert KuiTable to EuiTable for transaction overview

* Convert KuiTable to EuiTable for error overview

* Updated empty state messages

* Bump CI jo

* updated snapshots

* Add beta tooltip and update to EuiSearch

* Fixed issue with focus

* Submit when clicking search button

* Submit when clearing input

* Handle missing index pattern

* Remove query from spans
2018-07-10 21:00:54 +02:00
Nathan Reese
2084842e36
Add _bulk_create endpoint to /api/saved_objects (#20498)
* add _bulk_create rest endpoint

* document bulk_create api

* provide 409 status code when conflicts exist

* add overwrite and version to documenation

* clean up assert statements and 2 places where bulkCreate is getting used with new output

* properly stub bulkCreate return

* remove version of documenation example
2018-07-10 07:38:39 -06:00
Tim Roes
cb5ee01c6a
Increase prettier line width to 100 (#20535)
* Increase prettier line width to 100

* Fix packages JS prettier

* Change style guide to 100 width

* Fix line-width in latest master changes
2018-07-09 22:50:37 +02:00
CJ Cenizal
49139d2218
Replace uses of Notifier with toastNotifications in Watcher. (#20538) 2018-07-09 13:29:48 -07:00
James Gowdy
646f1d7f2c
[ML] disabling time range selector on jobs list (#20563) 2018-07-09 18:05:18 +01:00
Tim Sullivan
c043788c97
[Telemetry] move x-pack/monitoring collector classes to src/server/usage (#20248)
* [Monitoring/Telemetry] Move Usage service from Monitoring to Kibana core

* fix tests

* fix reporting integration

* roll back more diffs

* roll logger into bulk uploader to remove file duplication

* fix xpack usage api

* subclass constructor is not needed

* collectorSet has factory methods for collector object creation

* fix reporting usage jest test
2018-07-09 09:32:02 -07:00
Justin Kambic
d4d5fe1368
[PipelineViewer] Test PipelineViewer sub-components (#20329)
* Rename config view to PipelineViewer.

* Decouple CollapsibleStatement from if/else using props.children.

* Add tests for PipelineViewer component.

* Test Metric component.

* Test CollapsibleStatement component.

* Test PluginStatement component.

* Test Queue component.

* Test StatementListHeading component.

* Test StatementSection component. Move StatementList component to dedicated file.

* Test StatementList component.

* Test Statement component.

* Run prettier on edited files.
2018-07-09 11:51:52 -04:00
James Gowdy
d44840cd19
[ML] Adding jobs stats bar to top of jobs list (#20527)
* [ML] Adding jobs stats bar to top of jobs list

* unsetting update function

* changing node variable name

* small refactor

* using props copy of `updateJobStats`

* adding proptypes

* adding fixed height
2018-07-09 14:59:10 +01:00
Chris Davies
e34dbd0817
Fix issue w/ running chromium headless over http (#20528)
Remove the referrer header from report requests.
2018-07-06 15:30:10 -04:00
CJ Cenizal
8b8e5a0a8d
Convert various uses of notifier to toastNotifications. (#20420)
* Add MarkdownSimple component.
* Replace Context use of notifier with toastNotifications.
* Replace field.js use of notifier with toastNotifications.
* Replace State use of notifier with toastNotifications.
* Replace reporting use of notifier with toastNotifications.
* Convert Logstash to use toastNotifications.
* Convert Security to use toastNotifications.
2018-07-06 08:33:04 -07:00
James Gowdy
d9fe439671
[ML] Using kibana's auto-refresh for jobs list (#20496)
* [ML] Using kibana's auto-refresh for jobs list

* better auto refresh management

* fixing typo

* increasing default interval

* variable rename

* kill interval on page change

* updating comment

* adding minimum refresh interval

* correctly clearing the interval
2018-07-06 11:32:49 +01:00
James Gowdy
c6ba696127
[ML] Adding permission checks to jobs list (#20487)
* [ML] Adding permission checks to jobs list

* adding comment

* removing horizontal line

* changes based on review
2018-07-06 08:57:54 +01:00
James Gowdy
9d57acc867
[ML] Allow job cloning via wizards (#20227)
* [ML] [WIP] Allow job cloning via wizards

* updating clone link

* removing-created-by-data-when-editing-job

* removing commented out code

* changes based on review
2018-07-04 16:51:23 +01:00
James Gowdy
c4756b183f
[ML] Adding filter bar to jobs list (#20415)
* [ML] Adding filter bar to jobs list

* fixing page index when filtering

* refreshing job selection after actions have happened

* adding job counts to groups

* catching multi-select start datafeed errors

* style tweaks

* more style tweaks

* changes based on review

* refactoring search logic
2018-07-04 13:57:25 +01:00
Søren Louv-Jansen
90528194da
[APM] ML integration (#19791) 2018-07-04 14:18:19 +02:00
Pete Harverson
ea0395fd1e
[ML] Add endpoints and service for ML filters (#20406)
* [ML] Add endpoints and service for ML filters

* [ML] Replace getFilter(s) with single filters function
2018-07-04 13:00:16 +01:00
CJ Cenizal
e024d3dfa1
Refactor SearchSource interface (#20334)
* Removed the dynamically assigned type, query, filter, sort, highlight, highlightAll, aggs, from, searchAfter, size, source, version, and fields methods.
* The accessor interface now consists of getField and setField methods which throw errors if an unrecognized property name is provided, in addition to getFields, setFields, getOwnField, and getId methods.
* Linked-list interface now consists of setParent and getParent.
* Factory interface now consists of create, createCopy, and createChild.
* Removed the unused unused enable, disable, and addFilterPredicate, and the redundant toString (method only used internally) and extend method (superseded by createChild).
* Internally, renamed the _state property to _data and grouped methods by concern.
2018-07-03 16:53:48 -07:00
James Gowdy
93d9baafff
[ML] Rewrite of jobs list using react and eui (#19758)
* [ML] [WIP] New jobs list

* adding JSON tab

* adding datafeed and forecast tabs

* adding action menu functionality

* removing comments

* forcing change in file that is missing

* removing unnecessary change

* rolling back accidental change

* adding job group badges to main list

* adding multi-job action buttons

* adding start/stop actions

* showing start/end modal for multi-jobs

* adding multi-job delete

* changing delete warning

* initial edit job functionality

* adding space for custom url editing

* adding jobs summary endpoints

* fixing job loading for edit flyout

* adding calendars to jobs

* adding group loading endpoint for edit flyout

* adding audit message icons

* icon style change

* adding job messages in expanded job row

* removing log statements

* adding proptypes

* fixing expanded row table cell color

* removing log message

* renaming jobs endpoint provider

* changing case of button label

* renaming closeModal function

* adding missing proptypes

* changes based on review

* adding basic table sorting

* refactoring modal and flyout show/hide functions

* fixing sorting issues

* fixing overflow in groups
2018-07-03 10:36:45 +01:00
Justin Kambic
f763c3eb67
[Pipeline Viewer] Refactor collapsible statement component to wrap props.children (#20252)
* Rename config view to PipelineViewer.

* Decouple CollapsibleStatement from if/else using props.children.

* Modify function to take params instead of single object.
2018-07-02 13:59:42 -04:00
Tim Sullivan
f7070890d4
fix monitoring elasticsearch nodes listing sort and filtering (#20321)
closes https://github.com/elastic/kibana/issues/20132
2018-07-02 10:11:44 -07:00
Felix Stürmer
75309fffd6
Upgrade styled-components to 3.3.3 (#20257)
* Upgrade styled-components to 3.3.3

* Update test style snapshots

The upgrade seems to have affected the order in which the css classes
are serialized in the snapshot. The css rules within these classes look
identical.

* Update Kibana's yarn.lock

* Update kbn-i18n lockfile in anticipation of #20301
2018-07-01 22:58:12 +02:00
Justin Kambic
f4d9e08b45
[PipelineViewer] Replace bare img tags with euiicon (#20330)
* Remove direct references to EUI SVG. Remove bare img tag from DetailDrawer.

* Update DetailDrawer test snapshots.
2018-07-01 15:37:19 -04:00
Bill McConaghy
2cce4ff29f
fixing issues with bad error message for low permission users (#20275)
* fixing issues with bad error message for low permission users

* fixing stats, settings, and mappings error message and removing unused file
2018-06-29 13:49:49 -04:00
Bill McConaghy
d29e612ec0
improving warnings for delete and force merge (#20264)
* improving warnings for delete and force merge

* PR feedback
2018-06-29 12:08:34 -04:00
Bill McConaghy
3af5ef813b
fix sorting for index management (#20266)
* fix sorting for index management

* PR feedback
2018-06-29 12:07:25 -04:00
Bill McConaghy
c5be83bbd6
clearing error message when upload component mounts (#20268)
* clearing error message when upload component mounts

* fixing tests
2018-06-29 12:06:00 -04:00
Stacey Gammon
435eccb3dc
remove unused fn and variable (#20111) 2018-06-28 17:48:31 -04:00
Stacey Gammon
db1aad03bb
Remove _behaviors abstraction in Chromium reporting (#20106)
* remove over abstraction.

* delete unused file
2018-06-28 14:03:19 -04:00
CJ Cenizal
3ea4c3e0bc
Simplify Courier interface and organize internals (#20060)
**Interface changes**

There are two goals behind the interface changes:

* Make it clearer which courier modules are meant for public consumption by exporting them from the top level.
* Simplify the courier object by removing responsibilities and focusing its responsibility solely on scheduling search requests via the fetch method and timefilter.refreshInterval Angular event.

I did this by taking the following steps:

* Removing redirectWhenMissing, indexPatterns, SearchSource, and SavedObject from the courier object. I also removed some unused methods from its interface.
* redirectWhenMissing is now a service registered on the kibana/url Angular module.
* indexPatterns is now a service registered on the kibana/index_patterns Angular module.
* SearchSourceProvider and SavedObjectProvider are now top-level exports of ui/courier.
* migrateFilter, decorateQuery, buildQueryFromFilters, and luceneStringToDsl are now top-level exports of ui/courier.

**Internal changes**

I also made some internal changes in an effort to organize the code clearly and reduce unnecessary complexity.

* I refactored the async code in CallClient to appear sync with async/await and encapsulated chunks of logic in helper functions. I also used an isAborted flag instead of overwriting the esPromise var with an enum.
* I combined Looper and SearchLooper into a single class and deleted unused functions.
* I reorganized the courier/fetch/request code into SearchRequest, SegmentedSearchRequest, and serializeFetchParams modules.
* Renamed various other methods and variables to improve clarity.
2018-06-27 16:58:19 -07:00