Commit graph

19428 commits

Author SHA1 Message Date
Tim Sullivan 2a1eaadeb8
[Reporting] Stabilize ILM test for Cloud (#117003)
Closes https://github.com/elastic/kibana/issues/109456
2021-11-02 06:57:52 -07:00
Mark Hopkin f130759e82
[Fleet] Fix add agent help not closing when button clicked (#117104)
* close help popover when button clicked

* reduce popover z-index to hide behind modals
2021-11-02 13:12:14 +00:00
Tiago Costa 4d8363a92d
skip flaky suite (#116881) 2021-11-02 13:02:14 +00:00
Tiago Costa 0de567aa99
skip flaky suite (#116070) 2021-11-02 12:51:58 +00:00
Nicolas Chaulet 63cf1d0ab5
[Fleet] Delete non existing streams in overrideInputs (#116998) 2021-11-02 08:43:22 -04:00
Miriam c7b53f16b7
[APM] Apm errors api tests (#116764)
* changes after review

* move file to errors folder
2021-11-02 12:25:17 +00:00
Joe Portner 61ab4a3c59
Fix sample data for share-capable objects (#116378) 2021-11-02 07:57:21 -04:00
Or Ouziel f2b9acf67b
replace any with unknown in http client and types (#114265) 2021-11-02 13:53:56 +02:00
Stratoula Kalafateli 29e807f2e2
[Lens] Allows users to not render suggestions (#115946)
* [Lens] Allows users to not render suggestions

* Improve the transitions

* change implementation and use EuiAccordion instead

* Fixes the scrolling problem on the suggestions panel

* Apply PR comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-11-02 13:05:46 +02:00
Dima Arnautov b03a8695df
[ML] Replace console statement, add status code check (#116999) 2021-11-02 11:53:37 +01:00
Dario Gieselaar 6d5ba9be5e
[APM] Use Synthtrace in Cypress tests (#116948)
Co-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-11-02 10:48:05 +00:00
Walter Rafelsberger 0593c614a9
[ML] APM Correlations: Fix percentiles values. (#116639)
A change in the ES range agg no longer accepts numbers with decimals if the underlying field is typed as long. This PR fixes the issue by rounding the percentiles values we pass on to the range agg.
2021-11-02 10:40:58 +00:00
Gloria Hornero c7f7cd39f5
[Security Solution] Fixes upgrade tests (#116425)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-11-02 10:34:09 +00:00
Miriam 95cadcc9f1
Replace noHits variable (#116438)
* Replace noHits variable

* fix types

* changes after review
2021-11-02 10:10:24 +00:00
Walter Rafelsberger 6edabd1216
[ML] Fix boolean field support. (#116608)
Fixes support for boolean field types to be accepted as field candidates for APM correlation and failed transaction analysis.
2021-11-02 10:25:48 +01:00
Pete Hampton 56d3efdcab
[Telemetry] Migrate off unix epoch to UTC ISO Timestamp. (#116744)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-11-02 09:24:46 +00:00
Pablo Machado 74bee4bc17
Add column-gap to HeaderSectionComponent (#115952)
* Add column-gap to HeaderSectionComponent

* Please code review by using gutterSize instead of flex column-gap

* Add eui-textBreakNormal to header_section title

It makes sure that words in the title don't break into a new line

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-11-02 09:59:37 +01:00
David Sánchez cc366dd888
[Security Solution][Endpoint] Fix error when searching with special characters in policies filter (#116444)
* Fix error when searchin with special characters in policies filter

* remove unused brackets

* Refactor test uses userEvent instead of fireEvent to supress act() usage

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-11-02 09:48:29 +01:00
Oliver Gupte 2d1a088447
[Integration] Fix landing page for Add APM Integration link in Observability (#116847) (#116851) 2021-11-02 07:28:33 +00:00
Chris Cowan aafbc8cad0
[Metrics UI] Finish removing enabled for code base (#114731)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-11-02 00:44:23 +00:00
Constance 80ef314abc
Upgrade to EUI v40.1.0 (#116692)
* Upgrade EUI to v40.1.0

* [Discover] Remove temp fix + update snapshot

* Fix deprecated `popperPlacement` prop

* Update test snapshots with table cell change

Co-authored-by: Uladzislau Lasitsa <Uladzislau_Lasitsa@epam.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-11-01 14:31:04 -07:00
Davey Holler f5f12088da
UI copy changes for adaptive relevance (#117016)
* UI copy changes for adaptive relevance

* UI copy changes for adaptive relevance

* Update x-pack/plugins/enterprise_search/public/applications/app_search/components/curations/views/curations_settings/curations_settings.tsx

Co-authored-by: Byron Hulcher <byronhulcher@gmail.com>

Co-authored-by: Byron Hulcher <byronhulcher@gmail.com>
2021-11-01 21:19:32 +00:00
Nathan Reese 7170a64fec
[Maps] use single layer for map labels (#116840)
* [Maps] use single layer for map labels

* simplify filter expressions further

* eslint

* update mapbox_style expect statements

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-11-01 15:10:18 -06:00
Kyle Pollich a564e9fa65
[Fleet] Set keep_policies_up_to_date during package installation (#116993)
* Set `keep_policies_up_to_date` during preconfiguration

Don't rely on only our 7.16 migration set this flag, ensure it gets set
to `true` for any package that appears in `DEFAULT_PACKAGES` during
preconfiguration

Closes #116982

* Move default logic to installation

* Revert conflict change in preconfiguration.ts
2021-11-01 20:27:46 +00:00
Tyler Smalley 2a95b16c02 Revert "[APM] Adding api tests for error group (#116771)"
This reverts commit f2402cef37.
2021-11-01 12:36:38 -07:00
Thomas Neirynck 7bd984ba46
[Maps] Remove cruft (#116986) 2021-11-01 14:45:02 -04:00
Jen Huang e793b3a225
[Fleet] Allow user-configured namespace for managed policies (#116523)
* Disable agent monitoring settings in UI for managed policies

* Allow namespace to be changed for preconfigured managed policies

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-11-01 11:22:18 -07:00
Dario Gieselaar 2c887539d5
[APM] Synthtrace ES Client (#116770)
Co-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com>
2021-11-01 18:19:29 +00:00
Kyle Pollich d703f53412
Fix bug w/ keep policies up to date setting (#116974)
Previously, we were only honoring the "keep policies up to date"
setting for policies generated during preconfiguration. This fix ensure
we honor it for all policies.

Closes #116435
2021-11-01 13:43:38 -04:00
Stacey Gammon f65b3f694f
Fix mixspelt team name in plugin (#116899)
* Update kibana.json

* Make App Services team name consistent
2021-11-01 13:12:44 -04:00
Paul Tavares 08d0131c64
[Security Solution][Endpoint] Add tooltip to Name and Description on the ArtifactEntryCollapsableCard when collapsed (#116839)
* Add `withTooltip` prop to `TextValueDisplay` and use it in CardCompressedHeader
* Add UT
2021-11-01 13:11:57 -04:00
Cauê Marcondes f2402cef37
[APM] Adding api tests for error group (#116771)
* adding api tests for error group

* addresing pr changes
2021-11-01 16:31:06 +00:00
Giorgos Bamparopoulos 4feeeeb34f
Add API tests for top dependencies (#116788)
* Add top dependencies API tests

Co-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com>
2021-11-01 16:22:01 +00:00
Tyler Smalley 12af558898 skip flaky suite (#116980) 2021-11-01 09:12:00 -07:00
Mark Hopkin dcdc0f8e8f
[Fleet] Use event.ingested where possible for data stream last activity (#116641)
* use event.ingested for datastream last activity

* remove ms precision from datastream dates

* add timestamp check to test

* fix type error

* split test out to be less complex and more reliable 🤞

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-11-01 15:51:12 +00:00
Felix Stürmer 96a1d3186b
[Logs UI] Respect the advanced settings for queries (#116485)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-11-01 16:49:34 +01:00
Candace Park d905cacc1d
[Security Solution][Endpoint][Cases] Add cases path to sourcerer init so browser fields load (#116464)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-11-01 11:32:39 -04:00
Jean-Louis Leysens d9bbe9c9be
[Reporting] Remove banner from reports (#116147)
* remove banner from reports

* added types file

* updated types references and imports

* added screenshot mode public mock

* added jest tests for when screenshot mode is enabled

* Update x-pack/plugins/banners/public/plugin.test.tsx

Co-authored-by: Michael Dokolin <dokmic@gmail.com>

* Update x-pack/plugins/banners/public/plugin.test.tsx

Co-authored-by: Michael Dokolin <dokmic@gmail.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Michael Dokolin <dokmic@gmail.com>
2021-11-01 15:31:56 +00:00
Corey Robertson 25426708a8
Fix undo/redo and SO.resolve redirect issues (#116773)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-11-01 11:22:29 -04:00
Paul Tavares fa79ebeabd
[Security Solution][Endpoint] Fix display of long description text values (with no spaces) on Artifact Entry Cards (#116780)
* New DescriptionField component for artifact cards
* Use new DescriptionField in ArtifactCardEntry
* Added `eui-textBreakWord` class name to TextValueDisplay component in artifact cards
* Use `DescriptionField` in `CardCompressedHeader`
* Fix i18n of Description label on minified card
* Use DescriptionField in ArtifactEntryMinified
2021-11-01 11:01:54 -04:00
Shahzad 48a6585423
[Exploaratory View ] Styling: Fix duplicate labels for operation select (#115936)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-11-01 14:43:32 +00:00
Or Ouziel 9e4bab31b5
replace ts_ignore with ts_expect_error (#113768) 2021-11-01 16:41:10 +02:00
Giorgos Bamparopoulos e40ec9bfbd
Update testing dev docs for APM (#116664) 2021-11-01 10:10:19 -04:00
Georgii Gorbachev 2431a08d2b
[Security Solution][Detections] Reading last 5 failures from Event Log v1 - raw implementation (#115574)
**Ticket:** https://github.com/elastic/kibana/issues/106469, https://github.com/elastic/kibana/issues/101013

## Summary

TL;DR: New internal endpoint for reading data from Event Log (raw version), legacy status SO under the hood.

With this PR we now read the Failure History (last 5 failures) on the Rule Details page from Event Log. We continue getting the Current Status from the legacy `siem-detection-engine-rule-status` saved objects. Rule Management page also gets data from the legacy saved objects.

- [x] Deprecate existing methods for reading data in `IRuleExecutionLogClient`: `.find()` and `.findBulk()`
- [x] Introduce new methods for reading data in IRuleExecutionLogClient:
  - for reading last N execution events for 1 rule from event log
  - for reading current status and metrics for 1 rule from legacy status SOs
  - for reading current statuses and metrics for N rules from legacy status SOs
- [x] New methods should return data in the legacy status SO format.
- [x] Update all the existing endpoints that depend on `IRuleExecutionLogClient` to use the new methods.
- [x] Implement a new internal endpoint for fetching current status of the rule execution and execution events from Event Log for a given rule.
- [x] The API of the new endpoint should be the same as `rules/_find_statuses` to minimise changes in the app.
- [x] Use the new endpoint on the Rule Details page.

## Near-term plan for technical implementation of the Rule Execution Log (https://github.com/elastic/kibana/issues/101013)

**Stage 1. Reading last 5 failures from Event Log v1 - raw implementation** - ✔️ done in this PR

TL;DR: New internal endpoint for reading data from Event Log (raw version), legacy status SO under the hood.

- Deprecate existing methods for reading data in `IRuleExecutionLogClient`: `.find()` and `.findBulk()`
- Introduce new methods for reading data in IRuleExecutionLogClient:
  - for reading last N execution events for 1 rule from event log
  - for reading current status and metrics for 1 rule from legacy status SOs
  - for reading current statuses and metrics for N rules from legacy status SOs
- New methods should return data in the legacy status SO format.
- Update all the existing endpoints that depend on `IRuleExecutionLogClient` to use the new methods.
- Implement a new internal endpoint for fetching current status of the rule execution and execution events from Event Log for a given rule.
- The API of the new endpoint should be the same as `rules/_find_statuses` to minimise changes in the app.
- Use the new endpoint on the Rule Details page.

**Stage 2: Reading last 5 failures from Event Log v2 - clean implementation**

TL;DR: Clean HTTP API, legacy Rule Status SO under the hood.

🚨🚨🚨 Possible breaking changes in Detections API 🚨🚨🚨

- Design a new data model for the Current Rule Execution Info (the TO-BE new SO type and later the TO-BE data in the rule object itself).
- Design a new data model for the Rule Execution Event (read model to be used on the Rule Details page)
- Think over changes in `IRuleExecutionLogClient` to support the new data model.
- Think over changes in all the endpoints that return any data related to rule monitoring (statuses, metrics, etc). Make sure to check our docs to identify what's documented there regarding rule monitoring.
- Update `IRuleExecutionLogClient` to return data in the new format. 
- Update all the endpoints (including the raw new one) to return data in the new format.
- Update Rule Details page to consume data in the new format.
- Update Rule Management page to consume data in the new format.

**Stage 3: Reading last 5 failures from Event Log v3 - new SO**

TL;DR: Clean HTTP API, new Rule Execution Info SO under the hood.

- Implement a new SO type for storing the current rule execution info. Relation type: 1 rule - 1 current execution info.
- Swap the legacy SO with the new SO in the implementation of `IRuleExecutionLogClient`.

**Stage 4: Cleanup and misc**

- Revisit the problem of deterministic ordering ([comment](https://github.com/elastic/kibana/pull/115574#discussion_r735803087))
- Remove rule execution log's glue code: adapters, feature switch.
- Remove the legacy rule status SO.
- Mark the legacy rule status SO as deleted in Kibana Core.
- Encapsulate the current space id in the instance of IRuleExecutionLogClient. Remove it from parameters of its methods.
- Introduce a Rule Execution Logger scoped to a rule instance. For use in rule executors.
- Add test coverage.

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-11-01 14:40:14 +01:00
James Gowdy c9ccfad32e
[ML] Renaming index patterns for job wizards (#116250)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-11-01 12:50:21 +00:00
Esteban Beltran 602e15d8dd
[Security Solution] Show searchbar when a search doesn't return results in Host isolation exceptions. (#116767) 2021-11-01 12:49:52 +00:00
Giorgos Bamparopoulos ab092300f6
Add API tests for dependencies metadata (#116648)
* Add API tests for dependencies metadata

* Rename metadata tests to event metadata

Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
2021-11-01 12:40:09 +00:00
Ashokaditya 8fd02151e9
[Security Solution][Endpoint] Add tests for pending status API changes (#115998)
* add tests for pending status api changes

related to elastic/kibana/pull/115441

refs elastic/security-team/issues/1705

* update mock

refs elastic/kibana/pull/116214

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-11-01 11:56:07 +01:00
Christos Nasikas 2f55e68d02
[Cases] Do not show deprecated callout on deleted connectors (#116615)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-11-01 10:36:53 +02:00
Thomas Watson 8a39a113a0
Finalize removal of legacy audit logger (#116282) 2021-10-30 22:33:37 +01:00