Commit graph

43 commits

Author SHA1 Message Date
Steph Milovic
2bb23291c7
[Security Solution] [Cases] rename case dir/plugin/context/i18n to cases (#94149) 2021-03-10 08:58:51 -07:00
Jonathan Buttner
9dd395b452
[Security Solution][Case][Bug] Only update alert status in its specific index (#92530)
* Writing failing test for duplicate ids

* Test is correctly failing prior to bug fix

* Working jest tests

* Adding more jest tests

* Fixing jest tests

* Adding await and gzip

* Fixing type errors

* Updating log message

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-03 13:28:59 -05:00
Jonathan Buttner
4739eab490
[Security Solution][Case][Bug] Prevent closing collection when pushing (#93095)
* Prevent closing collection when pushing

* Fixing translations
2021-03-01 17:11:47 -05:00
Christos Nasikas
31889a589d
[Security Solution][Case] Migrate category & subcategory fields of ServiceNow ITSM connector (#93092) 2021-03-01 16:21:00 -05:00
Jonathan Buttner
d9043c1c46
[Security Solution][Case][Bug] Removing empty collections when filtering on status (#92048)
* Removing empty collections when not filtering on status

* Fixing add comment response

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-01 14:47:38 -05:00
Jonathan Buttner
b5cd44e7ac
[Security Solution][Case][Bug] Only add rule object for alert comments (#92977)
* Adding test for alert rule fields migration

* Fixing directory issue

* Add more descriptive message

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-01 11:14:14 -05:00
Christos Nasikas
c2877a6d96
[Security Solution][Case] Fix subcases bugs on detections and case view (#91836)
Co-authored-by: Jonathan Buttner <jonathan.buttner@elastic.co>
2021-02-26 15:35:43 +02:00
Jonathan Buttner
3c29f38adf
[Security Solution][Case] Adding tests for updating the status of alerts (#91301)
* Adding tests for updating the status of alerts

* Adding more alert tests and unskipping
2021-02-22 19:21:25 -05:00
Jonathan Buttner
a108469ec7
Allowing deletion of collections (#91926) 2021-02-19 10:50:35 -05:00
Angela Chuang
97d391a636
[Security Solution] Detection rules for case UI (#91434)
* Adding type field to client

* Removing context and adding association type

* Handle alerts from multiple indices

* Adding flow for adding a sub case

* Making progress on creating alerts from rules

* Refactored add comment to handle case and sub case

* Starting sub case API and refactoring of case client

* Fleshing out find cases

* Finished the find cases api

* Filtering comments by association type

* Fixing tests and types

* Updating snapshots

* Cleaning up comment references

* Working unit tests

* Fixing integration tests and got ES to work

* Unit tests and api integration test working

* Refactoring find and get_status

* Starting patch, and update

* script for sub cases

* Removing converted_by and fixing type errors

* Adding docs for script

* Removing converted_by and fixing integration test

* init expanded rows

* Adding sub case id to comment routes

* Removing stringify comparison

* styling

* clean up

* add status column

* styling

* hide actions if it has sub-cases

* Adding delete api and tests

* generated alert

* Updating license

* missed license files

* Integration tests passing

* Adding more tests for sub cases

* wip

* Find int tests, scoped client, patch sub user actions

* fixing types and call cluster

* fixing get sub case param issue

* Adding user actions for sub cases

* Preventing alerts on collections and refactoring user

* Allowing type to be updated for ind cases

* subcases attached to api

* combine enum on UI for simplification

* Refactoring and writing tests

* Fixing sub case status filtering

* add alerts count

* Adding more tests not allowing gen alerts patch

* Working unit tests

* Push to connector gets all sub case comments

* Writing more tests and cleaning up

* Updating push functionality for generated alerts and sub cases

* Adding comment about updating collection sync

* use CaseType to check if it is a sub-case

* fix types and disable selection if it has subcases

* isEmpty

* Detection rule correctly adding alerts to sub case

* update api and functionality to accept sub case

* integration part I

* fix integration with case connector

* Fix manual attach

* Fix types

* Fix bug when updating

* Fix bug with user actions

* Fix react key error

* Fix bug when pushing a lot of alerts

* fix lint error

* Fix limit

* fix title on sub case

* fix unit tests

* rm bazel

* fix unit tests and cypress test

* enable delete case icon

* revert change

* review

* Fix the scripts alerts generation code

* temp work

* Fix rule types and add migration

* fix types

* fix types error

* Remove query alerts

* Fix rules

* fix types

* fix lint error

* fix types

* delete a sub case

* rm unused i18n

* fix delete cases

* fix unit tests

* fix unit test

* update Case type

* fix types

* fix unit test

* final integration between rule and case

* fix integration test

* fix unit test + bring back connector in action of rule

Co-authored-by: Jonathan Buttner <jonathan.buttner@elastic.co>
Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>
2021-02-17 20:32:40 -05:00
Jonathan Buttner
f8b8d5b33d
[Case] Detection rules for case (#88726)
* Adding type field to client

* Removing context and adding association type

* Handle alerts from multiple indices

* Adding flow for adding a sub case

* Making progress on creating alerts from rules

* Refactored add comment to handle case and sub case

* Starting sub case API and refactoring of case client

* Fleshing out find cases

* Finished the find cases api

* Filtering comments by association type

* Fixing tests and types

* Updating snapshots

* Cleaning up comment references

* Working unit tests

* Fixing integration tests and got ES to work

* Unit tests and api integration test working

* Refactoring find and get_status

* Starting patch, and update

* script for sub cases

* Removing converted_by and fixing type errors

* Adding docs for script

* Removing converted_by and fixing integration test

* Adding sub case id to comment routes

* Removing stringify comparison

* Adding delete api and tests

* Updating license

* missed license files

* Integration tests passing

* Adding more tests for sub cases

* Find int tests, scoped client, patch sub user actions

* fixing types and call cluster

* fixing get sub case param issue

* Adding user actions for sub cases

* Preventing alerts on collections and refactoring user

* Allowing type to be updated for ind cases

* Refactoring and writing tests

* Fixing sub case status filtering

* Adding more tests not allowing gen alerts patch

* Working unit tests

* Push to connector gets all sub case comments

* Writing more tests and cleaning up

* Updating push functionality for generated alerts and sub cases

* Adding comment about updating collection sync

* Refactoring update alert status for sub cases and removing request and cleaning up

* Addressing alert service feedback

* Fixing sub case sync bug and cleaning up comment types

* Addressing more feedback

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-12 09:03:53 -05:00
Christos Nasikas
a9f2c91673
[Security Solution][Case] ServiceNow ITSM: Add category & subcategory fields (#90547) 2021-02-11 13:08:39 +02:00
Christos Nasikas
a0d4b04155
[Security Solution][Case] ServiceNow SIR Connector (#88655)
Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
2021-02-09 12:28:43 +02:00
Brandon Kobel
4584a8b570
Elastic License 2.0 (#90099)
* Updating everything except the license headers themselves

* Applying ESLint rules

* Manually replacing the stragglers
2021-02-03 18:12:39 -08:00
Christos Nasikas
f7fdda5db7
[Security Solution][Case] Fix patch cases integration test with alerts (#88311)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-18 09:59:26 +02:00
spalger
05f5192d1d skipping flaky suite (#87988) 2021-01-13 08:51:30 -07:00
Tyler Smalley
d306c85d03 skip flaky suite (#88130) 2021-01-12 21:18:29 -08:00
Christos Nasikas
a1931acdc5
[Security Solution][Case] Attach alerts to cases: Tests (#86305)
Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-11 17:44:35 +02:00
Steph Milovic
b0ba4f47ab
[Security Solution] [Case] Fixes "Case connector cannot be updated when created with a wrong field" (#87223) 2021-01-05 15:33:36 -07:00
Steph Milovic
335cd1f6fc
[Security Solution] [Cases] Move field mappings from actions to cases (#84587) 2020-12-15 07:06:11 -07:00
Christos Nasikas
ea4e2224a9
[Security Solution][Case] Sync cases with alerts (#84731) 2020-12-14 21:11:53 +02:00
Christos Nasikas
fcccb016f4
[Security Solution][Case] Add in-progress status to case (#84321) 2020-12-04 21:36:23 +02:00
Tiago Costa
9ee1ec7f30
chore(NA): rebalance x-pack cigroups (#84099)
* chore(NA): rebalance cigroup1 into cigroup5

* chore(NA): get list api integration into cigropup1 again

* chore(NA): get apm integration basic into cigropup1 again

* chore(NA): move back apm_api_integration trial tests into ciGroup1

* chore(NA): move exception operators data types into ciGroup1 again

* chore(NA): move detection engine api security and spaces back into ciGroup1

* chore(NA): add a new xpack cigroup11

* chore(NA): correctly create 11 xpack ci groups

* chore(NA): try to balance ciGroup2 and 8

* chore(NA): reset number of xpack parallel worker builds to 10

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-24 21:33:47 +00:00
Christos Nasikas
52c6b7b81b
[Security Solution][Case] Create comment types (#82715) 2020-11-20 21:03:05 +02:00
Christos Nasikas
7abb1e3033
[Security Solution][Case] Case action type (#80870)
* Init connector

* Add test

* Improve comment type

* Add integration tests

* Fix i18n

* Improve tests

* Show unknown when username is null

* Improve comment type

* Pass connector to case client

* Improve type after PR #82125

* Add comment migration test

* Fix integration tests

* Fix reporter on table

* Create case connector ui

* Add connector to README

* Improve casting on executor

* Translate name

* Improve test

* Create comment type enum

* Fix type

* Fix i18n

* Move README to cases

* Filter out case connector from alerting

Co-authored-by: Mike Côté <mikecote@users.noreply.github.com>

Co-authored-by: Mike Côté <mikecote@users.noreply.github.com>
2020-11-04 12:07:17 +02:00
Christos Nasikas
ca8b03823b
[Security Solution][Cases] Fix bug with case connectors (#80642)
* Fix bug with case connectors

* Improve isCaseOwned function
2020-10-16 18:07:11 +03:00
Christos Nasikas
85ad8a4f3d
[Security Solution][Case] Fix bug when changing connectors (#80002) 2020-10-09 09:25:47 +03:00
Christos Nasikas
287541891e
[Security Solutions][Case] Settings per case per connector (#77327)
Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-06 20:03:46 +03:00
Tiago Costa
574205dc72
chore(NA): remove non existing plugin paths from case api integration tests (#79127)
* chore(NA): remove non existing plugin paths from case api integration tests config

* chore(NA): remove unused import
2020-10-01 18:14:59 +01:00
Christos Nasikas
22b4e40ea0
[Alerting][Connectors] Refactor IBM Resilient: Generic Implementation (phase one) (#74357)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-11 10:24:46 +03:00
Christos Nasikas
db5652e020
[Alerting][Connectors] Refactor Jira: Generic Implementation (phase one) (#73778) 2020-09-09 16:17:11 +03:00
Yuliia Naumenko
f28a9e6e2d
Rename Whitelist to AllowList in Actions and Alerting (#75099)
* Rename Whitelist to AllowList in Actions and Alerting

* revert not related change

* Fixed due to comments and tests failing

* Fixed failing tests

* Fixed due to comments
2020-08-24 16:25:05 -07:00
Steph Milovic
9111d50965
fix tests and enable in CI (#75313) 2020-08-19 13:15:55 -06:00
Mikhail Shustov
88c0631344
Update @typescript-eslint to ensure compatibility with TypeScript v3.9 (#74091)
* bump @typescript-eslint deps

* update rules

* fix errors in pacakges

* fix src/

* fix x-pack

* fix test

* fix typings

* fix examples

* allow _ as prefix and suffix

* roll back prefix and suffix changes

* add eslint-plugin-eslint-comments

* report unused rules

* remove unused eslint comments from tests

* remove unused eslint comments 2nd pass

* remove unused eslint comments from src/

* remove unused comments in x-pack

* use no-script-url and no-unsanitized/property for ts files

* remove unused eslint comments

* eui/href-or-on-click removed when not complained

* no import/* rules for ts files

* cleanup

* remove the unused eslint-disable

* rollback unnecessary changes

* allow underscore prefix & sufix in type name

* update docs

* fix type error in enterprise search plugin mocks

* rename platform hack __coreProvider --> _coreProvider

* rollback space removal in src/core/public/legacy/legacy_service.test.ts

* fix naming convention in APM
2020-08-05 17:32:19 +02:00
Aleh Zasypkin
c6e2fed1c6
Register privileges in Kibana Platform Security plugin and remove legacy getUser API. (#65472) 2020-06-05 08:11:58 +02:00
Yuliia Naumenko
ce45dad8b6
Changed alerting API endpoints urls, bodies and params to follow Kibana STYLEGUIDE (#66838)
* Changed alerting API endpoints urls, bodies and params to follow Kibana STYLEGUIDE

* Changed alerting REST API to keep the pattern 'alerts/alert/{id}'

* fixed tests

* fixed tests

* Fixed jest tests

* Renamed plugin from alerting to alerts

* fixed tests

* fixed tests

* Fixed alert type check error

* Fixed find api

* fixed type checks

* fixed tests security issues

* Fixed view in app

* -

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-01 18:45:36 -07:00
Christos Nasikas
ce18e6e9ec
[SIEM][CASE] Improve api integration test (#67249) 2020-05-28 10:30:35 +03:00
Yuliia Naumenko
d09bd63786
Changed actions API endpoints urls to follow Kibana STYLEGUIDE (#65936)
* Changed actions API endpoints urls to follow Kibana STYLEGUIDE

* Fixed tests

* fixed test

* fixed test

* resolved conflicts

* Fixed siem tests

* Fixed failing test

* fixed readme and test

* Changed actions api urls to follow the template 'api/{plugin}/{type}/{id}

* Fixed type checks

* Fixed tests and API

* fixed tests

* Fixed type checks

* fixed type check
2020-05-24 20:27:42 -07:00
restrry
bf04235dae apply prettier styles 2020-05-22 09:08:58 +02:00
Christos Nasikas
d17489790c
[SIEM][CASE] Fix bug when connector is deleted. (#65876) 2020-05-15 14:43:02 +03:00
Steph Milovic
2082648678
[SIEM] [Cases] Case API tests (#65777) 2020-05-11 14:27:02 -06:00
Christos Nasikas
808e02564b
[SIEM][CASE] Moves functional tests from "legacyEs" to "Es" (#65851) 2020-05-08 21:24:44 +03:00
Christos Nasikas
a145aa9d5e
[SIEM][CASE] Api Integration Tests: Configuration (#63948)
* Init

* Init get_connectors

* Test post_configuration

* Test patch_configuration

* Rename folder

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-23 22:42:22 +03:00