Commit graph

2149 commits

Author SHA1 Message Date
Spencer
2e232c2e31
[@kbn/expect] "fork" expect.js into repo (#33761)
* [@kbn/expect] "fork" expect.js into repo

* [eslint] autofix references to expect.js

* [tslint] autofix all expect.js imports

* now that expect.js is in strict mode, avoid reassigning fn.length
2019-03-25 09:56:48 -07:00
Oliver Gupte
2c48da2417
[APM] Rename "Tags" -> "Labels" in span flyout (#33688)
* [APM] Closes #33486. Rename "Tags" -> "Labels" in span flyout.

* Remove unused translation 'xpack.apm.transactionDetails.spanFlyout.tagsTabLabel'
2019-03-25 09:26:53 -07:00
Liza Katz
53323d3d8a
Deleted unused directives from angular-boostrap (#33564)
* Deleted unused directives
 - alert
 - pagination
 - pager
 - bar
 - tooltipPopup
 - tooltipHtmlUnsafePopup
2019-03-24 11:00:52 +02:00
Spencer
96206bd092
[eslint] merge custom rules into a single plugin (#33733)
I'd like to add another custom eslint rule, but there isn't a very good place to do that right now. We have the `eslint-plugin-kibana-custom` package, which is super simple but isn't in the `@kbn` namespace and isn't included in the root eslint config, and `@kbn/eslint-plugin-license-header` is too specific, so I've merged those two packages into `@kbn/eslint-plugin-eslint`, which is a little redundant but allows is to refer to the rules within it as `@kbn/eslint/{rule}`, which feels nice.

Thoughts?

_**NOTE:**_ merging the eslint rules from the two packages means enabling prettier for the code from `@kbn/eslint-plugin-license-header`, all those changes are made in 42c7da6fe2. [View the changes without the prettier updates](b647f2b...74e07a0)
2019-03-22 17:12:14 -07:00
Spencer
96c39b695d
[jest/integration] set default test timeout to 30 seconds (#33718)
* [jest/integration] set default test timeout to 30 seconds

* move into dev/jest/setup directory
2019-03-22 15:13:08 -07:00
Spencer
b647f2ba6a
[reporting/extract] replace fixtures that look like source (#33739)
The fixtures used by reporting's `extract()` tests have tripped me and others up several times because from the outside they look and behave like source files, but require updating archive fixtures whenever the source is touched. The source of this file is irrelevant though, since the tests are just making sure that the extraction is accurate.

This PR updates the fixture to a markdown file with Lorem Ipsum in it, so it won't look relevant to people making broad strokes changes to files like https://github.com/elastic/kibana/pull/33733
2019-03-22 14:46:04 -07:00
Lisa Cawley
4c152965b6
Fixes broken link (#33724) 2019-03-22 11:57:06 -07:00
Pete Harverson
5ff422d353
[ML] Skip invalid modules when data recognizer lists matches (#33703)
* [ML] Skip invalid modules when data recognizer lists matches

* [ML] Append error to data recognizer module load console logs
2019-03-22 16:45:01 +00:00
Thomas Neirynck
41d4172fe5
[Maps] coerce string doc-values to numbers if used in styling (#33657) 2019-03-22 11:51:31 -04:00
Jonathan Budzenski
4d60e86287
[monitoring] only create license check if separate monitoring cluster (#33590) 2019-03-22 10:22:11 -05:00
Søren Louv-Jansen
ed2874bf54
[APM] Fix Datepicker double loading and move date parsing to urlParams (#33560) 2019-03-22 15:56:57 +01:00
Jason Rhodes
721161f3d1
Upgrades EUI to 9.5 (#33672)
* Updates EUI to 9.5.0

* Remove duplicate type

* Updates snapshots and fixes a few type errors

* Updates x-pack snapshots
2019-03-22 10:28:37 -04:00
Oliver Gupte
8ccd5715ab
[APM] Related error count in transaction timeline (#33100)
* Closes #29688 by adding related error count in timeline with links to error
overview filtered by the related trace/transaction ids. Also update the errors
link in the sticky transaction properties to match the timeline pattern.

* [APM] leverage EUI theme colors, tweak sticky transaction properties column
sizes, and reorder timeline error count to show duration after only on hover

* [APM] Renamed ErrorsOverviewLink -> ErrorCountBadge. Differentiate the labeled
vs non-labeled variaions of ErrorCountBadge. Replace state hooks for hovered
styles with plain css :hover

* [APM] Revert duration display on hover to render display all the time.

* remove unnecessary props object spread
2019-03-21 21:38:14 -07:00
Josh Dover
b21e646dcb
Replace start with setup lifecycle event (#33455)
* Move `start` lifecycle functions to `setup` in core/server

* Move `start` lifecycle functions to `setup` in core/public
2019-03-21 13:27:59 -05:00
Robert Monfera
7b5d559f4d
[Canvas] Fix: no stuck hover on key based page back/forth (#33631)
* Fix: no stuck hover on key based page back/forth

* Fix: no stuck hover on key based page back/forth
2019-03-21 18:55:16 +01:00
Aleh Zasypkin
e7e26b05b9
Typesciptify SAML Authentication provider. (#33559) 2019-03-21 16:56:33 +01:00
Liza Katz
3cc70257b8
New platform dropdown (#33520)
* Removed old dropdown code from dev tools consle

* Removed old dropdown from vega tools

* Deleted dropdown directives from angular bootstrap

* Deleted ui.bootstrap.dropdown test (irrelevant, since directive was deleted)
2019-03-21 15:02:27 +02:00
Robert Monfera
e110de3e59
Refactor: make interaction target acquisition faster and more robust (#33503) 2019-03-20 23:17:10 +01:00
Catherine Liu
9563c49d21
[Canvas] Show current workpad in workpad loader (#33531)
* Bolds loaded workpad in workpad loader

* Extracted helper function
2019-03-20 14:25:21 -07:00
Melissa Alvarez
a650dc172d
Add missing whitespace to modelPlotCardinality + cardinalityNotValid messages (#33599) 2019-03-20 16:12:25 -04:00
Liza Katz
e9863f386e
New platform cleanup tabs (#33425)
This PR includes the removal of the angular-boostrap directives:

* tabset
* tab

To achieve that, tabs were replaced in 2 places in the code (screenshots attached) with a simple React + EUI implementation.

* search profiler
* timelion app help documentation
2019-03-20 20:11:17 +02:00
Justin Kambic
d15a6771de
[Uptime] Change copy on empty state component (#33044)
* Change copy on Uptime empty state component to use "collecting" instead of "logging".

* Update jest snapshot for changed component.

* Update empty prompt link to send users to Add Data tutorial.

* Update empty state tests for new changes.
2019-03-20 14:10:08 -04:00
Justin Kambic
df89596e92
[Uptime] Add Global Help support to uptime (#31493)
* Add comments to kibana framework adapter file's render function for better annotation.

* Add global help link for uptime.

* Add return function to help API handler.
2019-03-20 14:09:30 -04:00
Josh Dover
14cce19c67
[UA] Move Kibana stacktrace from UI to logs (#33150) 2019-03-20 12:16:38 -05:00
Melissa Alvarez
2a695a4294
[ML] Anomaly explorer add/remove filter via Anomalies table (#33377)
* create utils file for kqlFilterBar

* add filer icons to influecer cell

* wip: apply filter from table

* update filterbar value from table

* error handling for filter by table

* Add filtering icons in expanded row

* Add tests + keep filterBar utils in same dir

* don't add filter if exists already

* update error message

* update error message and add link

* update entityCell comment + add getQueryPattern test

* Update entityCell comment

* update job switch handling with icon filter changes
2019-03-20 11:52:19 -04:00
Aleh Zasypkin
4b1dd01188
Exclude .test.ts files from x-pack build. (#33565) 2019-03-20 14:28:44 +01:00
Liza Katz
3ac95dc213
moved btn-radio directive to vis editor (#33373) 2019-03-20 11:54:51 +02:00
Robert Monfera
dfd9401cf0
[Canvas] No dummy commit for keyboard events (#33414)
* Chore: typo fix

* Chore: no longer use possibly obsolete `states`

* Fix: cause update to component upon keyboard shortcut interactions

* Refactor: more honest name for the React rerender enforcer call

* Chore: we know we return falsey
2019-03-20 08:11:54 +01:00
Peter Pisljar
40fce1aad8
adding interpreter uiExports (#33391) 2019-03-20 06:41:37 +01:00
Oliver Gupte
46fbe88f93
[APM] Closes #32626 by setting a unique key on the HeightRetainer element per transaction. (#33473) 2019-03-19 17:01:25 -07:00
Jason Rhodes
e8c1bff8cd
Removes refresh logic, updates tests, fixes back button problem when updated url is the same except for encoding (#33278) 2019-03-19 18:10:03 -04:00
Melissa Alvarez
3db0b45d42
[ML] Anomaly explorer clear filter when switching to jobs with no influencers (#33512)
* Remove race condition: trigger reload if job selection not in progress

* clear filter on job change when no influencers

* remove commented code

* update indexPattern comment for clarity
2019-03-19 14:34:12 -04:00
Chandler Prall
0e23ac1134
Upgrade EUI to 9.4.2 (#33511)
* Upgrade EUI to 9.4.1

* Upgrade EUI to 9.4.2
2019-03-19 12:31:04 -06:00
Liza Katz
7c0a776312
Removed popover directive (#33437)
* Deleted popover directive from angular-bootstrap
Copied a part of popover to ml angular bootstrap patch
Deleted unused dropdown directives from ml angular bootstrap patch

* Removed unused dropdown css
2019-03-19 19:55:16 +02:00
Brandon Morelli
d4a3f18004
update apm documentation links (#33435) 2019-03-19 07:46:09 -07:00
Pete Harverson
b1b9552812
[ML] Make layout of Edit Filter List consistent with other settings pages (#33421) 2019-03-19 09:47:14 +00:00
Sébastien Loix
effebd8c05
Move testbed utils to x-pack/test_utils (#32893) 2019-03-19 08:12:19 +01:00
Oliver Gupte
47272c464f
[APM] Add new agent name 'rum-js' (#33212)
* [APM] Closes #32643 by adding new agent name 'rum-js' for telemetry and docs links

* [APM] replaced enum with union type + set, and consolidated util functions operating on agent names

* [APM] code cleanup and fixing comments

* [APM] move AgentName type def to es_schemas, and the agent name functions to
common, leverage object hash to reference names

* [APM] code cleanup and improve type assertion between AgentName type and object mapping
2019-03-18 16:16:02 -07:00
Catherine Liu
7721b85def
Fixes esdocs to support uppercase index (#33442) 2019-03-18 13:47:26 -07:00
Thomas Neirynck
d1df04163c
[Maps] add some padding around mouse pointer (#33415) 2019-03-18 16:36:34 -04:00
Felix Stürmer
04f816bdd4
[Logs UI] Fix font size references after EUI upstream change (#33411)
This fixes the `small` font scale of the log viewer to correctly reference the EUI font size again. Before this fix, the `small` font scale was rendered larger than `medium`. Similarly, the tick labels of the log minimap were being rendered too large.

Both resulted from a breaking change of the exported variable names in elastic/eui#1590.

fixes #32759
2019-03-18 19:50:56 +01:00
Joel Griffith
71b1123408
Chore/update headless shell to pptr@1.13.0 (#33272) 2019-03-18 10:30:27 -07:00
Jonathan Budzenski
670943b7f4
[logstash/pipeline-workers] show 0 when 0 (#33253) 2019-03-18 11:04:18 -05:00
Kerry Gallagher
4b2c2bd63f
[InfraUI] Infrastructure navigation changes (#32892)
* Reorganise primary and sub navigation of Infrastructure

Add routed_tabs component

Amend routing (use an index and nested routes) and reorganise directory structure

Shift hosts / kubernetes / docker selection to subnavigation

Change path

Amend existing URLs

Use proper types

Amend document_title component

Reorganise title / source config button / info text

Maintain compatibility with old URLs

* Remove dead code

* Bump z-index on suggestions panel

* Ensure documentTitle responds to updates

* Use the same noop function and remove disabled option

* Use buttonSize="m" and add "Hosts" translation back

* Remove all "Home" wording

* Remove unused translations with script

* Don't nest <Link /> within a tab

* Comment out metrics-explorer tab until needed

* Don't create duplicate History entries
2019-03-18 14:11:16 +00:00
Felix Stürmer
76eff0afab
[Logs UI] Revert unintended inversion of loading state meaning (#33152)
This fixes a problem introduced with #32009, in which the meaning of the `isLoading` property for the `<ProgressEntry>` component was inverted.
2019-03-18 13:28:15 +01:00
Felix Stürmer
52084705a6
[Logs UI] Use react-intl FormattedRelative instead of a custom component (#33146)
This replaces the custom relative time component in the Logs UI live streaming inline loading indicator with the one from `react-intl`. This was not done at the time of the initial i18n introduction (#25213), because of #26237, which apparently has since been resolved via #26468. Visual changes should be limited to `now` being shown instead of `0s ago`.
2019-03-18 12:18:54 +01:00
Søren Louv-Jansen
7993be2c6b
[APM] Fix performance issue on metric charts (#33387) 2019-03-18 11:55:21 +01:00
Liza Katz
9b627e297b
New platform cleanup (#33244)
* delete file upload directive

* delte focus on directive

* delete confirm-click directive

* delete input-base-sixty-four directive

* delete input-date-time directive

*  delete string-to-number directive

*  delete validate-index-pattern directive

*  delete validate-lowercase directive

*  delete ui-select-focus-on directive

*  delete dismiss-on-timeout directive

*  delete accordion angular-bootstrap directive

*  delete collapse angular-bootstrap directive

*  delete collapse angular-bootstrap directive

* remove elastic-textarea directive

* remove color-picker directive

* remove rating directive

* remove btn-checkbox directive

* removed angular dateparser service

* remove unused string
2019-03-17 09:54:27 +02:00
Søren Louv-Jansen
f200f1509d
[APM] Fix problems with tilde in transaction name (#33309) 2019-03-16 00:40:06 +01:00
Robert Monfera
45d6453fa7
Test: TypeScript type specification strength tests (#32905)
* Test: TypeScript type specification strength tests

* Chore: post-merge lint

* Post-merge conflict fix
2019-03-15 23:58:25 +01:00