* Adding api test for custom link transaction example
* expecting specific fields
* expecting specific fields
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
The app can show more than 1 Resolver at a time. Each instance has a unique ID called the `resolverComponentInstanceID`.
When the user interacts with Resolver it will add values to the query string. The query string values will contain the `resolverComponentInstanceID`. This allows each Resolver to keep its state separate. When resolver unmounts it will remove any query string values related to it.
If Resolver's `resolverComponentInstanceID` changes it should remove query string values related to the old instance ID. It does not. This PR fixes that.
Note: I don't know if it was possible for this bug to actually happen. I can't make it happen, but depending on how Resolver is mounted by its consumers it *could*
* [Reporting] Update more Server Types for TaskManager
* remove some task manager references
* more strict
* more strict 2
* simplify
* fix test
* fix test
* routing validation unused types cleanup
* remove more casting in route handlers
* feedback changes
* original comment was fine
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Update design-specific GH code-owners
Created a `@elastic/stack-design` encompassing all product designers associated with the stack+solutions (Kibana repo contributors, not cloud). The `@elastic/kibana-design` team has been reduced to the actual Kibana design team. Then other individual design teams have been added as code-owners to their respective folders containing SASS changes.
* First few processors of the first batch
- Also refactored options to live in scoped objects to avoid
overriding type (important fix!)
- Have not polished copy or form layout.
* add type to shared imports
* Refactors for repeated fields and added forms
- date_index_name
- dissect
- dot_expander
- drop
Fields refactored:
- Field
- Ignore missing
* Fix broken imports and some other small refactors
* added text editor field and updated pattern and if fields
* Large copy improvements and updates and other small refactors
- Added help text for all fields
- Updated layout so that required fields are always on first
- Replaced circle radio group with a select drop down
* update circle shape type field to select
* Added "long" option for convert type
* fix path import
* fix types and i18n
* add validation for dot expander fix append value to be a combobox
* fix i18n
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Fixes flaky tests in Task Manager and Alerting.
The fix in #73244 was correct, but it missed an edge case which causes the already running task to be rescheduled over and over.
This prevents that edge case which was effecting both TM in general and Alerting specifically.
## Summary
This is the basics of end to end tests, so there could be a lot more, but this ties to cover the basics of the tests.
Test with:
```ts
node scripts/functional_tests --config x-pack/test/lists_api_integration/security_and_spaces/config.ts
```
Adds these tests for the route counter parts:
* create_exception_list_items.ts
* create_exception_lists.ts
* delete_exception_list_items.ts
* delete_exception_lists.ts
* find_exception_list_items.ts
* find_exception_lists.ts
* read_exception_list_items.ts
* read_exception_lists.ts
* update_exception_list_items.ts
* update_exception_lists.ts
Fixes a few minor strings, other tests, but no large bugs found with these tests
### Checklist
- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
## Summary
Addresses https://github.com/elastic/kibana/issues/73567.
ML Users (role: `machine_learning_user`) were previously able to invoke the ML Recognizer API, which we use to get not-yet-installed ML Jobs relevant to our index patterns. As of https://github.com/elastic/kibana/pull/64662 this is not true, and so we receive errors from components using the underlying hook, `useSiemJobs`.
To solve this I've created two separate hooks to replace `useSiemJobs`:
* `useSecurityJobs`
* used on ML Popover
* includes uninstalled ML Jobs
* checks (and returns) `isMlAdmin` before fetching data
* `useInstalledSecurityJobs`
* used on ML Jobs Dropdown and Anomalies Table
* includes only installed ML Jobs
* checks (and returns) `isMlUser` before fetching data
Note that we while we now receive the knowledge to do so, we do not always inform the user in the case of invalid permissions, and instead have the following behaviors:
#### User has insufficient license
* ML Popover: shows an upgrade CTA
* Anomalies Tables: show no data
* Rule Creation: ML Rule option is disabled, shows upgrade CTA
* Rule Details: ML Job Id is displayed as text
#### User is ML User
* ML Popover: not shown
* Anomalies Tables: show no data
* Rule Creation: ML Rule option is disabled
* Rule Details: ML Job Id is displayed as text
#### User is ML Admin
* ML Popover: shown
* Anomalies Tables: show data __for installed ML Jobs__
* This is the same as previous logic, but worth calling out that you can't view historical anomalies
* Rule Creation: ML Rule option is enabled, all ML Jobs available
* Rule Details: ML Job Id is displayed as hyperlink, job status badge shown
### Checklist
- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
### For maintainers
- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
* Migrated last pieces of legacy fixture code
* Implemented own server for webhook simulator
* Fixed type checks. Moved slack simulator to own server
* close server after tests run
* Fixed due to comments
* fixed failing tests
* Add basic layout/sidebar blocking
- note: we should *not* set left: 0 / top: 0 etc., as this can interfere with Kibana's existing UI (e.g. docked navigation, telemetry callout)
* Add sidebar styles + static links
* Refactor SideNav to be a reusable component
- So that Workplace Search can reuse the same layout but pass in their own custom nav
+ Refactor AppSearch to use Layout in router
* Refactor all views to account for in-router Layout
* Fix root redirects not working as expected
- If enterpriseSearchUrl hasn't been set, all pages should redirect to SetupGuide, not just root
- The engines redirect simply wasn't working at all - it would always show a blank page when '/' was clicked in the Kibana breadcrumbs. Not sure if this is a Kibana issue - had to change to a component load to fix
+ Simplify index.test.tsx (probably unreasonable and not super helpful to add assertions for each new route)
* Implement active styling for links
* Fix failing location tests
- By adding a new useLocation mock
+ add SideNavLink active class test
TODO: I should probably rename react_router_history.mock to just react_router.mock
* Add responsive toggle + styling
* Add navigation accessibility attributes/controls
* [Feedback] Update mobile UX to close menu on link click/navigation
- This requires updating our EUI/React Router components to accept and run custom onClick events
- Also requires adding a new ReactContext to pass down closeNavigation, but that's not too onerous thanks to useContext
