Commit graph

35680 commits

Author SHA1 Message Date
Mike Côté d56b792e9c
Make the alerts plugin support generics (#72716)
* Initial work

* Expand generic support to alert instances

* Convert index threshold to use generics

* Make fixture alert types use generics

* Make alert instance related types use unknown

* Fix typecheck failures

* Cleanup + add instance generic support to registry.get API

* Shallow clone

* Rename some TS variables

* Fix failing api integration tests

* Change code for easier review and keep more history

* Fix

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-14 12:52:42 -04:00
Melissa Alvarez 8559ed87d1
[ML] DF Analytics creation: display explain error message (#75006)
* display explain error message to the user

* fix translation

* update error message
2020-08-14 12:44:42 -04:00
Greg Thompson bbee1f92b0
Upgrade EUI to v27.4.0 (#74004)
* eui to 27.1.0

* eui to 27.2.0

* buttoniconside type

* euiselectable type

* update onScroll callback and polyfill size references

* findTestSubject ts

* buttoncontent and collapsiblenav src snapshot updates

* update prop retrieval

* xpack snapshots

* jest updates

* type fixes

* more snapshots

* virtual list changes

* more virtualization changes

* merge

* fix functional tests

* data-test-subj for indexPatter-switcher

* storyshots

* eui to 27.3.1

* Fix unit tests

* Fix broken unit test

* Updated snapshots

* Fixed types

* search for value in euiselectable before selection

* select the correct element

* mock virtualized dep

* ts fix

* reinstate storyshot

* ts fix

Co-authored-by: Chandler Prall <chandler.prall@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-14 10:31:15 -06:00
Quynh Nguyen f1ad1f1b7b
[ML] Add new storeInHashQuery and replaceUrlQuery (#74955)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-14 10:34:08 -05:00
Jean-Louis Leysens 344e1de7e1
[Upgrade Assistant] Fix potentially long URI (#74485)
* _cluster/state/metadata/* and added a comment to function

* add another comment regarding why we are asking for *

* update jest test

* refactor and clean up use of cluster status to get index state

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-14 17:14:03 +02:00
Stratoula Kalafateli 458bf9fb0d
Fix bug on TopN weird behavior with zero values (#74942) 2020-08-14 17:57:08 +03:00
Wylie Conlon ec5112b9cc
[Lens] Fix table sorting bug (#74902)
* [Lens] Fix table sorting bug

* Fix types
2020-08-14 10:54:43 -04:00
Kevin Logan 8aa8b04cee
[SECURITY_SOLUTION] Retry on ingest setup (#75000) 2020-08-14 10:06:51 -04:00
Nathan Reese 187a13075b
[file upload] lazy load to reduce page load size (#74967)
* [file upload] lazy load to reduce page load size

* tslint
2020-08-14 07:15:16 -06:00
Alexey Antonov f6f59ec261
Drilldowns for TSVB / Vega / Timelion (#74848)
* Drilldowns for TSVB / Vega

Closes: #60611

* fix PR comment

* fix PR comments

* add support for Timelion

* rename vis.API.events.brush -> vis.API.events.applyFilter
2020-08-14 15:46:55 +03:00
Patrick Mueller 67e28ac8b4
[EventLog] Populate alert instances view with event log data (#68437)
resolves https://github.com/elastic/kibana/issues/57446

Adds a new API (AlertClient and HTTP endpoint) `getAlertStatus()` which returns
alert data calculated from the event log.
2020-08-14 08:34:26 -04:00
Anton Dosov 7bd014abb3
[UiActions] pass trigger into action execution context (#74363)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-14 12:07:04 +02:00
Cauê Marcondes bcf8719824
Adding API test for custom link transaction example (#74238)
* Adding api test for custom link transaction example

* expecting specific fields

* expecting specific fields

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-14 09:55:39 +02:00
Shahzad 7cf0e49c89
[Uptime] Singular alert (#74659)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-14 09:45:02 +02:00
Tim Roes 4d6592edc8
Revert "attempt excluding a codeowners directory" (#75023)
This reverts commit 250a0b17b0.
2020-08-14 09:17:43 +02:00
Chris Cowan 1632391f35
[Metrics UI] Remove TSVB dependency from Metrics Explorer APIs (#74804)
* [Metrics UI] Remove TSVB dependency from Metrics Explorer APIs

* Update x-pack/plugins/infra/public/pages/metrics/metrics_explorer/components/chart_title.tsx

Co-authored-by: Zacqary Adam Xeper <Zacqary@users.noreply.github.com>

* Update x-pack/plugins/infra/server/lib/metrics/lib/calculate_bucket_size/calculate_auto.ts

Co-authored-by: Zacqary Adam Xeper <Zacqary@users.noreply.github.com>

* Update x-pack/plugins/infra/server/lib/metrics/lib/calculate_bucket_size/calculate_auto.ts

Co-authored-by: Zacqary Adam Xeper <Zacqary@users.noreply.github.com>

* Update x-pack/plugins/infra/server/lib/metrics/lib/convert_histogram_buckets_to_timeseries.ts

Co-authored-by: Zacqary Adam Xeper <Zacqary@users.noreply.github.com>

* Update x-pack/plugins/infra/server/lib/metrics/lib/convert_histogram_buckets_to_timeseries.ts

Co-authored-by: Zacqary Adam Xeper <Zacqary@users.noreply.github.com>

* Update x-pack/plugins/infra/server/routes/metrics_explorer/lib/find_interval_for_metrics.ts

Co-authored-by: Zacqary Adam Xeper <Zacqary@users.noreply.github.com>

* Fixing some names, changing some units

* Reverting TSVB calculate_auto; fixing names in infra

* Fixing translation names

* Fixing typo

Co-authored-by: Zacqary Adam Xeper <Zacqary@users.noreply.github.com>

Co-authored-by: Zacqary Adam Xeper <Zacqary@users.noreply.github.com>
2020-08-13 18:45:47 -07:00
Josh Dover 24c2e0a452
Remove degraded state from ES status service (#75007) 2020-08-13 18:15:11 -06:00
Tim Sullivan 447854d992
[Reporting/Functional] unskip pagination test (#74973)
* [Reporting/Functional] unskip pagination test

* change to js file for flaky test runner

* fix ts
2020-08-13 15:06:59 -07:00
Robert Austin 1729091ddf
[Resolver] Stale query string values are removed when resolver's component instance ID changes. (#74979)
The app can show more than 1 Resolver at a time. Each instance has a unique ID called the `resolverComponentInstanceID`. 
When the user interacts with Resolver it will add values to the query string. The query string values will contain the `resolverComponentInstanceID`. This allows each Resolver to keep its state separate. When resolver unmounts it will remove any query string values related to it.

If Resolver's `resolverComponentInstanceID` changes it should remove query string values related to the old instance ID. It does not. This PR fixes that. 

Note: I don't know if it was possible for this bug to actually happen. I can't make it happen, but depending on how Resolver is mounted by its consumers it *could*
2020-08-13 17:50:10 -04:00
Scotty Bollinger 875f7701c3
Add public url to Workplace Search plugin (#74991) 2020-08-13 16:45:16 -05:00
Tim Sullivan a8ed1f4b16
[Reporting] Update more Server Types for TaskManager (#74915)
* [Reporting] Update more Server Types for TaskManager

* remove some task manager references

* more strict

* more strict 2

* simplify

* fix test

* fix test

* routing validation unused types cleanup

* remove more casting in route handlers

* feedback changes

* original comment was fine

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-13 14:33:27 -07:00
Ahmad Bamieh ee9a8d29b1
[I18n] verify select icu-message options are in english (#74963)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-13 23:44:17 +03:00
Luke Elmers fe017f52dd
Make data.search.aggs available on the server. (#74472) 2020-08-13 13:38:16 -06:00
Michael Olorunnisola c34e30ed0b
[Security Solution][Resolver] Graph Control Tests and Update Simulator Selectors (#74680)
Co-authored-by: oatkiller <robert.austin@elastic.co>
2020-08-13 14:55:43 -04:00
spalger 250a0b17b0 attempt excluding a codeowners directory 2020-08-13 11:41:52 -07:00
Melissa Alvarez 479a991b98
[ML] DF Analytics: allow failed job to be stopped by force via the UI (#74710)
* allow force stop from ui if job is failed

* update wording in confirm modal
2020-08-13 14:17:33 -04:00
Ryan Keairns ad3d87517f
Add kibana-core-ui-designers team (#74970) 2020-08-13 12:38:57 -05:00
Zacqary Adam Xeper cdc7d25561
[Metrics UI] Fix inventory footer misalignment (#74707) 2020-08-13 12:21:29 -05:00
Spencer 4c810be335
Remove legacy optimizer (#73154)
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-13 09:08:44 -07:00
Caroline Horn d21d100030
Update design-specific GH code-owners (#74877)
* Update design-specific GH code-owners

Created a `@elastic/stack-design` encompassing all product designers associated with the stack+solutions (Kibana repo contributors, not cloud). The `@elastic/kibana-design` team has been reduced to the actual Kibana design team. Then other individual design teams have been added as code-owners to their respective folders containing SASS changes.
2020-08-13 11:44:22 -04:00
Jonathan Budzenski 6a85e893f7 skip test Reporting paginates content #74922 2020-08-13 10:31:11 -05:00
Zacqary Adam Xeper 8095c7ba15
[Metrics UI] Add Jest tests for alert previews (#74890) 2020-08-13 09:32:14 -05:00
Uladzislau Lasitsa acc8ffed29
Fixed tooltip (#74074)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-13 16:38:57 +03:00
Jean-Louis Leysens 50f332867a
[Ingest Pipelines] Processor forms for processors A-D (#72849)
* First few processors of the first batch

- Also refactored options to live in scoped objects to avoid
  overriding type (important fix!)
- Have not polished copy or form layout.

* add type to shared imports

* Refactors for repeated fields and added forms

- date_index_name
- dissect
- dot_expander
- drop

Fields refactored:

- Field
- Ignore missing

* Fix broken imports and some other small refactors

* added text editor field and updated pattern and if fields

* Large copy improvements and updates and other small refactors

- Added help text for all fields
- Updated layout so that required fields are always on first
- Replaced circle radio group with a select drop down

* update circle shape type field to select

* Added "long" option for convert type

* fix path import

* fix types and i18n

* add validation for dot expander fix append value to be a combobox

* fix i18n

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-13 14:57:04 +02:00
Cauê Marcondes c7a46d583a
[Observability] change ingest manager link (#74928)
* chaning ingest manager link

* chaning ingest manager link
2020-08-13 13:41:39 +02:00
Gidi Meir Morris eb03295f85
[Task manager] Prevents edge case where already running tasks are reschedule every polling interval (#74606)
Fixes flaky tests in Task Manager and Alerting.

The fix in #73244 was correct, but it missed an edge case which causes the already running task to be rescheduled over and over.

This prevents that edge case which was effecting both TM in general and Alerting specifically.
2020-08-13 12:20:38 +01:00
Angela Chuang 1a09c878b1
[Security Solution] Fix the status of timelines' bulk actions (#74560)
* fix bulk actions

* fix lint error

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-13 10:24:40 +01:00
Liza Katz 290f9bfde2
Data plugin: Suggested enhance pattern (#74505)
* improve test stability

* Enhance pattern

* fix tests

* fix test

* Rename enhance to __enhance

* Deleted unnecessary attribute

* ISearchInterceptor interface

* docs

* Clean up internal docs

* jest

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-13 11:28:39 +03:00
Walter Rafelsberger b249af128e
Use jest.useFakeTimers instead of hard coded timeout for tooltip tests. (#74642)
Refactor to use jest.useFakeTimers().
2020-08-13 09:38:15 +02:00
Frank Hassanabad db357a212d
[Security Solution][lists] Adds tests for exception lists and items part 2 (#74815)
## Summary

This is the basics of end to end tests, so there could be a lot more, but this ties to cover the basics of the tests.

Test with:
```ts
node scripts/functional_tests --config x-pack/test/lists_api_integration/security_and_spaces/config.ts
```

Adds these tests for the route counter parts:
* create_exception_list_items.ts
* create_exception_lists.ts
* delete_exception_list_items.ts
* delete_exception_lists.ts
* find_exception_list_items.ts
* find_exception_lists.ts
* read_exception_list_items.ts
* read_exception_lists.ts
* update_exception_list_items.ts
* update_exception_lists.ts

Fixes a few minor strings, other tests, but no large bugs found with these tests

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2020-08-12 22:32:05 -06:00
Brent Kimmel e2ef219a7c
[Security Solution][Resolver] fix presentation role on edgeline (#74869)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-12 21:02:00 -04:00
Ryland Herrick 4ca52e678a
[Security Solution][Detections] Refactor ML calls for newest ML permissions (#74582)
## Summary

Addresses https://github.com/elastic/kibana/issues/73567.

ML Users (role: `machine_learning_user`) were previously able to invoke the ML Recognizer API, which we use to get not-yet-installed ML Jobs relevant to our index patterns. As of https://github.com/elastic/kibana/pull/64662 this is not true, and so we receive errors from components using the underlying hook, `useSiemJobs`.

To solve this I've created two separate hooks to replace `useSiemJobs`:

* `useSecurityJobs`
  * used on ML Popover
  * includes uninstalled ML Jobs
  * checks (and returns) `isMlAdmin` before fetching data
* `useInstalledSecurityJobs`
  * used on ML Jobs Dropdown and Anomalies Table
  * includes only installed ML Jobs
  * checks (and returns) `isMlUser` before fetching data

Note that we while we now receive the knowledge to do so, we do not always inform the user in the case of invalid permissions, and instead have the following behaviors:

#### User has insufficient license
* ML Popover:  shows an upgrade CTA
* Anomalies Tables: show no data
* Rule Creation: ML Rule option is disabled, shows upgrade CTA
* Rule Details: ML Job Id is displayed as text
#### User is ML User
* ML Popover:  not shown
* Anomalies Tables: show no data
* Rule Creation: ML Rule option is disabled
* Rule Details: ML Job Id is displayed as text
#### User is ML Admin
* ML Popover:  shown
* Anomalies Tables: show data __for installed ML Jobs__
  * This is the same as previous logic, but worth calling out that you can't view historical anomalies
* Rule Creation: ML Rule option is enabled, all ML Jobs available
* Rule Details: ML Job Id is displayed as hyperlink, job status badge shown

### Checklist

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
2020-08-12 18:26:06 -06:00
Spencer a735a9f825
[bin/kibana-plugin] support KP plugins instead (#74604)
* [cli/kibana-plugin] support KP plugins instead

* fix some Logger imports from cli/kibana_keystore

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-12 16:38:08 -07:00
Matthew Kime 981fdda966
Reduce number of indexed fields in index pattern saved object (#74817)
* reduce number of indexed fields in index pattern saved object
2020-08-12 18:31:30 -05:00
Josh Dover 0eee111cf3
[reporting] Pass along generic parameters in high-order route handler (#74892) 2020-08-12 15:24:29 -06:00
Yuliia Naumenko 124bd126f8
Migrated last pieces of legacy fixture code (#74470)
* Migrated last pieces of legacy fixture code

* Implemented own server for webhook simulator

* Fixed type checks. Moved slack simulator to own server

* close server after tests run

* Fixed due to comments

* fixed failing tests
2020-08-12 14:08:02 -07:00
Caroline Horn 5b64a4cdfe
Empty index patterns page re-design (#68819)
Empty index patterns page re-design
2020-08-12 15:58:16 -05:00
Spencer c97916ea81
[babel] coalese some versions to prevent breaking yarn install (#74864)
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-12 12:45:49 -07:00
Devon Thomson 2e5140d67b
[Dashboard First] Decouple Attribute Service and By Value Embeddables (#74302)
* Added an interface that determines if an embeddable can be treated as either by reference or by value
2020-08-12 15:31:44 -04:00
Josh Dover 5d82ac15cb
Revert "[reporting] Pass along generic parameters in high-order route handler" (#74891)
This reverts commit 041b78cec1.
2020-08-12 12:46:13 -06:00