Commit graph

47784 commits

Author SHA1 Message Date
Zacqary Adam Xeper 6693ef371f
[Logs UI][Metrics UI] Remove deprecated config fields from APIs and SavedObjects (#115874)
* [Logs UI][Metrics UI] Remove deprecated config fields from APIs

* Fix typecheck

* Fix typecheck

* Fix typecheck

* Fix jest

* Fix functional test

* Remove extraneous timeField args

* Typecheck fix

* Consolidate log file changes to ResolvedLogSourceConfiguration

* Fix merge

* Revert additional logs files

* Revert inventory models

* Revert log_analysis api

* Fix timefield reference in process list

* Restore logs page files, fix typecheck on mock

* Fix functional test

* Restore inventory models index

* Fix typecheck on getFilteredMetrics

* Look CI if you don't tell me all the type errors at once I can't fix them all

* Maybe this is the last typecheck fix who knows
2021-10-29 12:12:26 -04:00
Zacqary Adam Xeper c0d005db62
[Metrics UI] Fix OR logic on redundant groupBy detection (#116695) 2021-10-29 16:07:04 +00:00
Esteban Beltran ddf092f38c
[Security Solution] Host isolation exceptions - fixes for QA issues (#116089)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-28 15:54:17 +00:00
Quynh Nguyen d4f4e64426
[ML] Re-enable explorer link jest test (#116324)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-28 15:53:05 +00:00
Tyler Smalley d295156eb8
Removes master>main sync (#116553)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2021-10-28 08:45:58 -07:00
Xavier Mouligneau 24e5bd244c
[SECURITY] Remove flaky test on edit user page (#116467)
* no more flaky test

* fix eslint

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-28 11:21:53 -04:00
Cauê Marcondes 155a16ed2f
[APM] Errors api test: error_groups/main_statistics (#116337)
* use apmApiClient

* refacroting

* fixing errors groups main statistics tests

* refactoring

* fixing error group detailed stats test

* fixing ts issue

* renaming empty archiver
2021-10-28 16:20:51 +01:00
Nicolas Chaulet a23d5e29a4
[Fleet] Fix edit package policy save button (#116482) 2021-10-28 11:17:47 -04:00
Josh Dover d5963884b6
Include failure reason when packages cannot be installed during setup (#116612) 2021-10-28 15:47:26 +01:00
Gloria Hornero b102846c82
adds import Timeline test (#114703) 2021-10-28 15:34:19 +01:00
Marshall Main d280f12757
[Security Solution] Security RAC migration follow up bug fixes (#116386)
* Add compatibility aliases to alerts as data indices

* Fix dupe mitigation, allow more fields in mapping

* Remove legacy signals fields from new RAC alerts

* Fix cypress test

* Remove outdated comment

* Reduce flakiness in time based test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-28 10:21:51 -04:00
Paul Tavares 2f3d4fcb48
[Security Solution][Endpoint] Fix bug where users without superuser role are not able to see Endpoint data on Host Details (#116202)
* Add `.catch()` statement to ES calls in order to get better stacktraces
* Improve efficiency of getHostEndpoint() search strategy method
* Refactor `getHostEndpoint()` to use new Metadata service as well as the internal kibana ES client
2021-10-28 15:18:50 +01:00
Paul Tavares 7c12ffffee
[Security Solution][Endpoint] Un-skip Policy Details FTR test suite and fix bug in Policy Details page when saving changes (#115662)
* unskip test suite
* Fix functional tests and some refactoring
* Refactor Policy Details test and centralize getting of Agent Policy combined input for endpoint
* Change approach for checking policy data in fleet pages
* Change Policy Settings displayed in Fleet to a) show a loader while retrieving settings and b) show loading errors if any
* Close any visible toasts before clicking on the save button
2021-10-28 15:10:32 +01:00
Baturalp Gurdin 24c6d6583d
fix: move concurrency parameters to substep (#116461)
Concurrency parameters were not in the correct place which made concurrency settings not in effect.
Moved it to to performance.sh step which also has parallelism in the same level.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-28 14:59:44 +01:00
Oliver Gupte 2856e19db7
[APM] Adds missing legacy key for apm-server.secret_token (#116385) (#116554) 2021-10-28 09:46:41 -04:00
Frank Hassanabad b2f4c821f3
[Security Solutions] Adds console logging and relaxes the 200 checks in a 2 areas of the e2e tests (#116548)
## Summary

Adds console logging and relaxes a few 200 checks in the end to end tests in two areas of:
* createExceptionListItem
* importFile

As recently the tests are failing around these parts and possibly we can get information on the next failures if it is from these two areas or if it's from somewhere else we are not expecting.

Also outputs the body message so if it fails in these areas we can see the message with the conflict that might help us see where the issue is arising.

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-10-28 15:27:45 +02:00
Shahzad 9e7f1c8e35
[Global search] Prevent unnecessary /internal/global_search/find http call at startup (#112535)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-28 15:26:28 +02:00
Yaroslav Kuznietsov aba80059ce
[Canvas] Fixes Reveal Image background is not contained. (#116403)
* Fixed the problem with `backgroundSize` and `backgroundRepeat`.
2021-10-28 16:18:51 +03:00
Jean-Louis Leysens 1e88abbb31
[Reporting] Remove Boom (#116289)
* remove use of boom from info response handler; also changed unauthd response to forbidden to avoid client logging user out

* rather return 500 with err.message

* added jest tests for common cases on the info route

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-28 14:18:22 +01:00
Walter Rafelsberger 0f73b57cfd
[ML] Anomaly Detection: Functional tests for anomaly detection forecasts. (#116140)
Functional tests for anomaly detection forecasts.
2021-10-28 14:18:53 +02:00
Robert Oskamp 753da1ac1d
[ML] Functional tests - remove monitor cluster privilege from test role (#116581)
This PR removes the `monitor` cluster privilege from the `ft_ml_ui_extras` test role as it's no longer required by the categorization wizard and we want to stay close to the minimum set of required privileges for our test users.
2021-10-28 13:55:20 +02:00
Yulia Čech 9b14bab5dc
[ILM] Fixed skipped a11y and functional tests (#116207)
* [ILM] Fixed ILM a11y test by creating a snapshot repo that is now required in the ILM API

* [ILM] Fixed functional test by creating a snapshot repository

* [ILM] Updated the params after es client update

* [ILM] Added filtering by policy name to the a11y test to find the correct ILM policy in the list

* [ILM] Added filtering by policy name to the a11y test to find the correct ILM policy in the list

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-28 12:54:09 +01:00
Christos Nasikas 5338e1965f
[Cases] Fix configure cases flaky test (#116575) 2021-10-28 12:47:36 +01:00
Mark Hopkin f598c43435
[Fleet] Add missing documentation link on integrations page (#116453)
* add missing doc link

* node scripts/check_published_api_changes.js --accept
2021-10-28 12:40:33 +01:00
Quynh Nguyen 21cd11a851
[ML] Fix Transforms not retaining _meta on clone (#116206)
* [ML] Retain _meta on clone

* [ML] Fix validation on schema to only check it it's defined/not null

* [ML] Remove validation because es should handle the validation already

* Change type to unknown
2021-10-28 12:24:52 +01:00
Gloria Hornero 0e1d42d400
skips exceptions tests (#116568) 2021-10-28 12:11:36 +01:00
Dzmitry Lemechko f79b94faed
[load testing] add default package to simulation class (#116375)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-28 13:11:24 +02:00
Shahzad 4a92e3bc36
[Exploratory View]added loading state for metric selector (#115748)
Co-authored-by: Dominique Clarke <doclarke71@gmail.com>
2021-10-28 11:36:27 +01:00
spalger acf0426194 skip flaky suite (#89369) 2021-10-28 09:19:16 +00:00
spalger 8a34170b2f skip flaky suite (#90536) 2021-10-28 09:13:26 +00:00
spalger c760db6a01 skip flaky suite (#115307) 2021-10-28 09:08:47 +00:00
Giorgos Bamparopoulos e0764bd1d0
Update examples in the elastic-apm-synthtrace CLI section (#116574) 2021-10-28 05:04:01 -04:00
spalger 42857a4da9 skip flaky suite (#116537) 2021-10-28 09:03:16 +00:00
Rudolf Meijering 2e4c87211c
[docs] Fix anchor link to saved objects migrations testing (#116427) 2021-10-28 10:36:57 +02:00
Søren Louv-Jansen 01503c5d5d
Add stale bot for APM issues (#116432)
* Add stale bot for APM issues

* Update stale.yml

* Update stale.yml
2021-10-28 04:14:40 -04:00
Joe Reuter 2b15dc9b10
retry reading suggestion list (#116405)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-28 09:36:52 +02:00
Frank Hassanabad 3424f94fb4
Unskips tests and fixes a few of them. (#116469)
## Summary

* For the test of `create_endpoint_exceptions.ts` code was changed to try to reduce/remove flake. I put the code back to where it was and with the sorting introduced it all should pass
* Added `await waitForSignalsToBePresent(supertest, 1, [id]);` to areas of code that were missing.
* The `.flat` should be an added layer of protection for flakes.


### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-10-27 21:31:18 -06:00
Tiago Costa a78e50ca94
skip flaky suite (#116059) 2021-10-28 03:13:46 +01:00
Nathan L Smith cca0a082d2
e2e tests for dependencies (#116369)
Also fix a link in testing readme.

References #116290.
2021-10-27 21:07:08 -05:00
Spencer 9e6e84571f
Revert "[Canvas] By-Value Embeddables (#113827)" (#116527)
This reverts commit bacd7f91dd.

Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-10-27 20:38:43 -05:00
Nicolas Chaulet ede3882e18
[Fleet] Fix back button when adding integration from multiple integrations package (#116352) 2021-10-28 01:55:23 +01:00
Joey F. Poon 4efabacd4e
[Security Solution] fix endpoint being visible after unenrolling agent (#116372)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-27 17:38:53 -05:00
Spencer 17df3a2654
[ci] bump timeout for cigroups until we figure out the slowdown (#116506)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-10-27 17:03:37 -05:00
spalger 83288af8bd skip failing suite (#72874) 2021-10-27 21:34:41 +00:00
Devon Thomson dc2bea778c
Lowered bundle size limits for dashboard and presentationUtil (#116478) 2021-10-27 16:43:00 -04:00
Tiago Costa edc8f9583b
chore(NA): bump version to 8.1.0 (#116429)
* chore(NA): bump version to 8.1.0

* chore(NA): update non supported plugins

* chore(NA): update non supported plugins

* chore(NA): skip failing tests

* chore(NA): update jest snapshots

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-27 21:24:48 +01:00
Tiago Costa 9978803893
chore(NA): adds backport config for 8.1.0 bump (#116431) 2021-10-27 21:24:35 +01:00
Frank Hassanabad ae7b5a9be9
[Security Solutions] Adds bsearch service to FTR e2e tests to reduce flake, boilerplate, and technique choices (#116211)
## Summary

Fixes flake tests of:
https://github.com/elastic/kibana/issues/115918
https://github.com/elastic/kibana/issues/103273
https://github.com/elastic/kibana/issues/108640
https://github.com/elastic/kibana/issues/109447
https://github.com/elastic/kibana/issues/100630
https://github.com/elastic/kibana/issues/94535
https://github.com/elastic/kibana/issues/104260

Security solution has been using `bsearch` and has encountered flake in various forms. Different developers have been fixing the flake in a few odd ways (myself included) which aren't 100%. This PR introduces a once-in-for-all REST API retry service called `bsearch` which will query `bsearch` and if `bsearch` is not completed because of async occurring due to slower CI runtimes it will continuously call into the `bsearch` with the correct API to ensure it gets a complete response before returning.


## Usage

Anyone can use this service like so:
```ts
const bsearch = getService('bsearch');
const response = await bsearch.send<MyType>({
 supertest,
 options: {
   defaultIndex: ['large_volume_dns_data'],
}
  strategy: 'securitySolutionSearchStrategy',
});
```

If you're using a custom auth then you can set that beforehand like so:
```ts
const bsearch = getService('bsearch');
const supertestWithoutAuth = getService('supertestWithoutAuth');
const supertest supertestWithoutAuth.auth(username, password);
const response = await bsearch.send<MyType>({
 supertest,
 options: {
   defaultIndex: ['large_volume_dns_data'],
  }
  strategy: 'securitySolutionSearchStrategy',
});
```

## Misconceptions in the tests leading to flake
* Can you just call the bsearch REST API and it will always return data first time? Not always true, as when CI slows down or data increases `bsearch` will give you back an async reference and then your test will blow up.
* Can we wrap the REST API in `retry` to fix the flake? Not always but mostly true, as when CI slows down or data increases `bsearch` could return the async version continuously which could then fail your test. It's also tedious to tell everyone in code reviews to wrap everything in `retry` instead of just fixing it with a service as well as inform new people why we are constantly wrapping these tests in `retry`.
* Can we manually parse the `bsearch` if it has `async` for each test? This is true but is error prone and I did this for one test and it's ugly and I had issues as I have to wrap 2 things in `retry` and test several conditions. Also it's harder for people to read the tests rather than just reading there is a service call. Also people in code reviews missed where I had bugs with it. Also lots of boiler plate.
* Can we just increase the timeout with `wait_for_completion_timeout` and the tests will pass for sure then? Not true today but maybe true later, as this hasn't been added as plumbing yet. See this [open ticket](https://github.com/elastic/kibana/issues/107241). Even if it is and we increase the timeout to a very large number bsearch might return with an `async` or you might want to test the `async` path. Either way, if/when we add the ability we can increase it within 1 spot which is this service for everyone rather than going to each individual test to add it. If/when it's added if people don't use the bsearch service we can remove it later if we find this is deterministic enough and no one wants to test bsearch features with their strategies down the road.

## Manual test of bsearch service
If you want to manually watch the bsearch operate as if the CI system is running slow or to cause an `async` manually you manually modify this setting here:
https://github.com/elastic/kibana/blob/master/src/plugins/data/server/search/strategies/ese_search/request_utils.ts#L61

To be of a lower number such as `1ms` and then you will see it enter the `async` code within `bsearch` consistently

## Reference PRs
We cannot set the wait_for_complete just yet
https://github.com/elastic/kibana/issues/107241 so we decided this was the best way to reduce flake for testing for now. 

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-10-27 14:22:45 -06:00
Byron Hulcher c3f207a071
Revert "[App Search] Load curation settings at root /curations/ path (#115690)" (#116462) 2021-10-27 21:18:19 +01:00
Gloria Hornero 136d322bdd
adds lists plugin to security solution cypress tests execution (#116442) 2021-10-27 20:55:55 +01:00