I'd like to add another custom eslint rule, but there isn't a very good place to do that right now. We have the `eslint-plugin-kibana-custom` package, which is super simple but isn't in the `@kbn` namespace and isn't included in the root eslint config, and `@kbn/eslint-plugin-license-header` is too specific, so I've merged those two packages into `@kbn/eslint-plugin-eslint`, which is a little redundant but allows is to refer to the rules within it as `@kbn/eslint/{rule}`, which feels nice.
Thoughts?
_**NOTE:**_ merging the eslint rules from the two packages means enabling prettier for the code from `@kbn/eslint-plugin-license-header`, all those changes are made in 42c7da6fe2. [View the changes without the prettier updates](b647f2b...74e07a0)
The fixtures used by reporting's `extract()` tests have tripped me and others up several times because from the outside they look and behave like source files, but require updating archive fixtures whenever the source is touched. The source of this file is irrelevant though, since the tests are just making sure that the extraction is accurate.
This PR updates the fixture to a markdown file with Lorem Ipsum in it, so it won't look relevant to people making broad strokes changes to files like https://github.com/elastic/kibana/pull/33733
* Add first draft of uptime docs.
* Add first draft of uptime docs.
* Implement PR feedback.
* Add role info to uptime docs
* Impelement some more PR feedback.
* Attempt to add more copy focusing on the 'why' of each piece of the docs.
* uptime docs: grammar, formatting, order
* move location of uptime docs
* Implement more PR feedback.
* Add screenshots.
This adds the new source configuration ui to the documentation of both the Infrastructure UI and the Logs UI. It also removes the `BETA` badge to reflect the status change.
fixeselastic/kibana#31124
Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
* Closes#29688 by adding related error count in timeline with links to error
overview filtered by the related trace/transaction ids. Also update the errors
link in the sticky transaction properties to match the timeline pattern.
* [APM] leverage EUI theme colors, tweak sticky transaction properties column
sizes, and reorder timeline error count to show duration after only on hover
* [APM] Renamed ErrorsOverviewLink -> ErrorCountBadge. Differentiate the labeled
vs non-labeled variaions of ErrorCountBadge. Replace state hooks for hovered
styles with plain css :hover
* [APM] Revert duration display on hover to render display all the time.
* remove unnecessary props object spread
* Removed old dropdown code from dev tools consle
* Removed old dropdown from vega tools
* Deleted dropdown directives from angular bootstrap
* Deleted ui.bootstrap.dropdown test (irrelevant, since directive was deleted)
* Moved auto_select_if_only_one directive
* Moved validate-date-interval directive
* Moved scroll-bottom directive
* Moved input number directive + Fix validate-date-interval directive
* Moved validate ip and validate cidr mask directives
* Moved validate date math and documentation href directives
* Moved validate agg directive
* Moved click focus directive
* removed validate date interval from autoload
* refetch autocomplete info after updating dev console settings
* address review feedback
* only update autocomplete settings if user has changed settings
* refactor code to only refetch autocomplete settings on change
* simplify logic based on review feedback
* address review feedback
This PR includes the removal of the angular-boostrap directives:
* tabset
* tab
To achieve that, tabs were replaced in 2 places in the code (screenshots attached) with a simple React + EUI implementation.
* search profiler
* timelion app help documentation
* Change copy on Uptime empty state component to use "collecting" instead of "logging".
* Update jest snapshot for changed component.
* Update empty prompt link to send users to Add Data tutorial.
* Update empty state tests for new changes.
* Add comments to kibana framework adapter file's render function for better annotation.
* Add global help link for uptime.
* Add return function to help API handler.
This modifies the PluginService to expose a Map of UI plugins and their manifests, in topological order by their dependencies. That data is then exposed to injectedMetadata via the ui_render_mixin in the legacy platform, and read back out via the new platform's client-side InjectedMetadataService, preserving the topological order.
* Chore: typo fix
* Chore: no longer use possibly obsolete `states`
* Fix: cause update to component upon keyboard shortcut interactions
* Refactor: more honest name for the React rerender enforcer call
* Chore: we know we return falsey